[PATCH 12/15] trace_output.c: adjust conditional expression formatting.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Sharp
Date: Friday, December 3, 2010 - 5:13 pm

Formatting change only to improve readability. No code changes except to
introduce intermediate variables.

Signed-off-by: David Sharp <dhsharp@google.com>
---
 kernel/trace/trace_output.c |   26 +++++++++++++++-----------
 1 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
index 02272ba..9e33b1f 100644
--- a/kernel/trace/trace_output.c
+++ b/kernel/trace/trace_output.c
@@ -533,20 +533,24 @@ seq_print_ip_sym(struct trace_seq *s, unsigned long ip, unsigned long sym_flags)
  */
 int trace_print_lat_fmt(struct trace_seq *s, struct trace_entry *entry)
 {
-	int hardirq, softirq;
 	int ret;
-
-	hardirq = entry->flags & TRACE_FLAG_HARDIRQ;
-	softirq = entry->flags & TRACE_FLAG_SOFTIRQ;
+	int hardirq = entry->flags & TRACE_FLAG_HARDIRQ;
+	int softirq = entry->flags & TRACE_FLAG_SOFTIRQ;
+
+	const char irqs_off = 
+		(entry->flags & TRACE_FLAG_IRQS_OFF) ? 'd' :
+		(entry->flags & TRACE_FLAG_IRQS_NOSUPPORT) ? 'X' :
+		'.';
+	const char need_resched =
+		(entry->flags & TRACE_FLAG_NEED_RESCHED) ? 'N' : '.';
+	const char hardsoft_irq =
+		(hardirq && softirq) ? 'H' :
+		hardirq ? 'h' :
+		softirq ? 's' :
+		'.';
 
 	if (!trace_seq_printf(s, "%c%c%c",
-			      (entry->flags & TRACE_FLAG_IRQS_OFF) ? 'd' :
-				(entry->flags & TRACE_FLAG_IRQS_NOSUPPORT) ?
-				  'X' : '.',
-			      (entry->flags & TRACE_FLAG_NEED_RESCHED) ?
-				'N' : '.',
-			      (hardirq && softirq) ? 'H' :
-				hardirq ? 'h' : softirq ? 's' : '.'))
+			      irqs_off, need_resched, hardsoft_irq))
 		return 0;
 
 	if (entry->preempt_count)
-- 
1.7.3.1

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[Patch 00/15] Reduce tracing payload size., David Sharp, (Fri Dec 3, 5:13 pm)
[PATCH 04/15] ftrace: pack event structures., David Sharp, (Fri Dec 3, 5:13 pm)
[PATCH 10/15] ftrace: fix event alignment: jbd2:*, David Sharp, (Fri Dec 3, 5:13 pm)
[PATCH 11/15] ftrace: fix event alignment: ext4:*, David Sharp, (Fri Dec 3, 5:13 pm)
[PATCH 12/15] trace_output.c: adjust conditional expressio ..., David Sharp, (Fri Dec 3, 5:13 pm)
Re: [PATCH 10/15] ftrace: fix event alignment: jbd2:*, Steven Rostedt, (Fri Dec 3, 6:52 pm)
Re: [PATCH 11/15] ftrace: fix event alignment: ext4:*, Steven Rostedt, (Fri Dec 3, 6:53 pm)
Re: [Patch 00/15] Reduce tracing payload size., Andi Kleen, (Mon Dec 6, 6:22 am)
Re: [Patch 00/15] Reduce tracing payload size., Ted Ts'o, (Mon Dec 6, 6:56 am)
Re: [Patch 00/15] Reduce tracing payload size., Andi Kleen, (Mon Dec 6, 7:58 am)
Re: [Patch 00/15] Reduce tracing payload size., Steven Rostedt, (Mon Dec 6, 9:17 am)
Re: [Patch 00/15] Reduce tracing payload size., Miguel Ojeda, (Mon Dec 6, 9:31 am)
Re: [Patch 00/15] Reduce tracing payload size., Andi Kleen, (Mon Dec 6, 9:41 am)
[PATCH] tracing: Add an 'overwrite' trace_option., David Sharp, (Wed Dec 8, 2:46 pm)
Re: [PATCH 08/15] ftrace: fix event alignment: mce:mce_record, Frederic Weisbecker, (Thu Dec 9, 6:33 am)
Re: [PATCH 13/15] small_traces: Add config option to shrin ..., Frederic Weisbecker, (Thu Dec 9, 7:55 am)
Re: [PATCH 13/15] small_traces: Add config option to shrin ..., Frederic Weisbecker, (Thu Dec 9, 8:28 am)
Re: [PATCH] tracing: Add an 'overwrite' trace_option., David Sharp, (Mon Dec 13, 5:39 pm)