Home » Mailing list archives » linux-kernel » 2010 » December » 31

Re: [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.

Previous thread: [PATCH RFC v2] Consider E820 non-RAM and E820 gaps as 1-1 mappings. by Konrad Rzeszutek Wilk on Thursday, December 30, 2010 - 12:48 pm. (1 message)

Next thread: [PATVH] media, dvb, IX2505V: Remember to free allocated memory in failure path (ix2505v_attach()). by Jesper Juhl on Thursday, December 30, 2010 - 4:11 pm. (8 messages)
[view original message]
From: Justin P. Mattock
Subject: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Thursday, December 30, 2010 - 4:07 pm

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/spi/dw_spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
index 0838c79..7c3cf21 100644
--- a/drivers/spi/dw_spi.c
+++ b/drivers/spi/dw_spi.c
@@ -592,7 +592,7 @@ static void pump_transfers(unsigned long data)
 		spi_set_clk(dws, clk_div ? clk_div : chip->clk_div);
 		spi_chip_sel(dws, spi->chip_select);
 
-		/* Set the interrupt mask, for poll mode just diable all int */
+		/* Set the interrupt mask, for poll mode just disable all int */
 		spi_mask_intr(dws, 0xff);
 		if (imask)
 			spi_umask_intr(dws, imask);
-- 
1.6.5.2.180.gc5b3e

--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: [PATCH 04/15]drivers:staging:comedi:drivers:das800.c Typo change diable to disable.
Date: Thursday, December 30, 2010 - 4:07 pm

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/staging/comedi/drivers/das800.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/comedi/drivers/das800.c b/drivers/staging/comedi/drivers/das800.c
index aecaedc..3ecae47 100644
--- a/drivers/staging/comedi/drivers/das800.c
+++ b/drivers/staging/comedi/drivers/das800.c
@@ -450,7 +450,7 @@ static irqreturn_t das800_interrupt(int irq, void *d)
 		/* otherwise, stop taking data */
 	} else {
 		spin_unlock_irqrestore(&dev->spinlock, irq_flags);
-		disable_das800(dev);	/* diable hardware triggered conversions */
+		disable_das800(dev);	/* disable hardware triggered conversions */
 		async->events |= COMEDI_CB_EOA;
 	}
 	comedi_event(dev, s);
-- 
1.6.5.2.180.gc5b3e

--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: [PATCH 05/15]drivers:staging:vt6655:rf.c Typo change diable to disable.
Date: Thursday, December 30, 2010 - 4:07 pm

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/staging/vt6655/rf.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index b8ec783..cdd9165 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -496,11 +496,11 @@ bool s_bAL7230Init (unsigned long dwIoBase)
 
     //Calibration
     MACvTimer0MicroSDelay(dwIoBase, 150);//150us
-    bResult &= IFRFbWriteEmbeded(dwIoBase, (0x9ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW)); //TXDCOC:active, RCK:diable
+    bResult &= IFRFbWriteEmbeded(dwIoBase, (0x9ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW)); //TXDCOC:active, RCK:disable
     MACvTimer0MicroSDelay(dwIoBase, 30);//30us
-    bResult &= IFRFbWriteEmbeded(dwIoBase, (0x3ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW)); //TXDCOC:diable, RCK:active
+    bResult &= IFRFbWriteEmbeded(dwIoBase, (0x3ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW)); //TXDCOC:disable, RCK:active
     MACvTimer0MicroSDelay(dwIoBase, 30);//30us
-    bResult &= IFRFbWriteEmbeded(dwIoBase, dwAL7230InitTable[CB_AL7230_INIT_SEQ-1]); //TXDCOC:diable, RCK:diable
+    bResult &= IFRFbWriteEmbeded(dwIoBase, dwAL7230InitTable[CB_AL7230_INIT_SEQ-1]); //TXDCOC:diable, RCK:disable
 
     MACvWordRegBitsOn(dwIoBase, MAC_REG_SOFTPWRCTL, (SOFTPWRCTL_SWPE3    |
                                                      SOFTPWRCTL_SWPE2    |
-- 
1.6.5.2.180.gc5b3e

--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: [PATCH 08/15]drivers:scsi:lpfc:lpfc_init.c Typo change diable to disable.
Date: Thursday, December 30, 2010 - 4:07 pm

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/scsi/lpfc/lpfc_init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index b306579..a921f16 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -7661,7 +7661,7 @@ lpfc_pci_remove_one_s3(struct pci_dev *pdev)
 	 * the HBA.
 	 */
 
-	/* HBA interrupt will be diabled after this call */
+	/* HBA interrupt will be disabled after this call */
 	lpfc_sli_hba_down(phba);
 	/* Stop kthread signal shall trigger work_done one more time */
 	kthread_stop(phba->worker_thread);
-- 
1.6.5.2.180.gc5b3e

--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.
Date: Thursday, December 30, 2010 - 4:08 pm

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/media/video/cx18/cx23418.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/cx18/cx23418.h b/drivers/media/video/cx18/cx23418.h
index 2c00980..7e40035 100644
--- a/drivers/media/video/cx18/cx23418.h
+++ b/drivers/media/video/cx18/cx23418.h
@@ -177,7 +177,7 @@
    IN[0] - Task handle.
    IN[1] - luma type: 0 = disable, 1 = 1D horizontal only, 2 = 1D vertical only,
 		      3 = 2D H/V separable, 4 = 2D symmetric non-separable
-   IN[2] - chroma type: 0 - diable, 1 = 1D horizontal
+   IN[2] - chroma type: 0 - disable, 1 = 1D horizontal
    ReturnCode - One of the ERR_CAPTURE_... */
 #define CX18_CPU_SET_SPATIAL_FILTER_TYPE     	(CPU_CMD_MASK_CAPTURE | 0x000C)
 
-- 
1.6.5.2.180.gc5b3e

--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: [PATCH 12/15]drivers:media:video:tvp7002.c Typo change diable to disable.
Date: Thursday, December 30, 2010 - 4:08 pm

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/media/video/tvp7002.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/tvp7002.c b/drivers/media/video/tvp7002.c
index e63b40f..c799e4e 100644
--- a/drivers/media/video/tvp7002.c
+++ b/drivers/media/video/tvp7002.c
@@ -789,7 +789,7 @@ static int tvp7002_query_dv_preset(struct v4l2_subdev *sd,
  * Get the value of a TVP7002 decoder device register.
  * Returns zero when successful, -EINVAL if register read fails or
  * access to I2C client fails, -EPERM if the call is not allowed
- * by diabled CAP_SYS_ADMIN.
+ * by disabled CAP_SYS_ADMIN.
  */
 static int tvp7002_g_register(struct v4l2_subdev *sd,
 						struct v4l2_dbg_register *reg)
-- 
1.6.5.2.180.gc5b3e

--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: [PATCH 14/15]include:media:davinci:vpss.h Typo change diable to disable.
Date: Thursday, December 30, 2010 - 4:08 pm

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 include/media/davinci/vpss.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/media/davinci/vpss.h b/include/media/davinci/vpss.h
index c59cc02..b586495 100644
--- a/include/media/davinci/vpss.h
+++ b/include/media/davinci/vpss.h
@@ -44,7 +44,7 @@ struct vpss_pg_frame_size {
 	short pplen;
 };
 
-/* Used for enable/diable VPSS Clock */
+/* Used for enable/disable VPSS Clock */
 enum vpss_clock_sel {
 	/* DM355/DM365 */
 	VPSS_CCDC_CLOCK,
-- 
1.6.5.2.180.gc5b3e

--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: [PATCH 15/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Thursday, December 30, 2010 - 4:08 pm

The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/spi/dw_spi.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
index 7c3cf21..a3a065f 100644
--- a/drivers/spi/dw_spi.c
+++ b/drivers/spi/dw_spi.c
@@ -910,12 +910,12 @@ int __devinit dw_spi_add_host(struct dw_spi *dws)
 	ret = init_queue(dws);
 	if (ret) {
 		dev_err(&master->dev, "problem initializing queue\n");
-		goto err_diable_hw;
+		goto err_disable_hw;
 	}
 	ret = start_queue(dws);
 	if (ret) {
 		dev_err(&master->dev, "problem starting queue\n");
-		goto err_diable_hw;
+		goto err_disable_hw;
 	}
 
 	spi_master_set_devdata(master, dws);
@@ -930,7 +930,7 @@ int __devinit dw_spi_add_host(struct dw_spi *dws)
 
 err_queue_alloc:
 	destroy_queue(dws);
-err_diable_hw:
+err_disable_hw:
 	spi_enable_chip(dws, 0);
 	free_irq(dws->irq, dws);
 err_free_master:
-- 
1.6.5.2.180.gc5b3e

--


[ message continues ]
[view original message]
From: Dan Carpenter
Subject: Re: [PATCH 15/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Thursday, December 30, 2010 - 11:34 pm

You missed one from this file:

/* Set the interrupt mask, for poll mode just diable all int */
                                              ^^^^^^
regards,
dan carpenter

--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: Re: [PATCH 15/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Thursday, December 30, 2010 - 11:38 pm

oh-man... my grepping wasn't so grepping after all.. thanks for that 
I'll resend this one

Justin P. Mattock
--


[ message continues ]
[view original message]
From: Mauro Carvalho Chehab
Subject: Re: [PATCH 14/15]include:media:davinci:vpss.h Typo change diable to disable.
Date: Friday, December 31, 2010 - 3:27 am

Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>

PS.: Next time, please c/c linux-media ONLY on patches related to media
drivers (/drivers/video and the corresponding include files). Having to
dig into a series of 15 patches to just actually look on 3 patches 

--


[ message continues ]
[view original message]
From: Jiri Kosina
Subject: Re: [PATCH 14/15]include:media:davinci:vpss.h Typo change diable to disable.
Date: Monday, January 3, 2011 - 8:01 am

Absolutely.

Justin, no kernel developer should be afraid of being CCed. But try to 
avoid really unnecessary spamming (which this was).

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--


[ message continues ]
[view original message]
From: Mauro Carvalho Chehab
Subject: Re: [PATCH 12/15]drivers:media:video:tvp7002.c Typo change diable to disable.
Date: Friday, December 31, 2010 - 3:24 am

--


[ message continues ]
[view original message]
From: Mauro Carvalho Chehab
Subject: Re: [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.
Date: Friday, December 31, 2010 - 3:23 am

--


[ message continues ]
[view original message]
From: Jiri Kosina
Subject: Re: [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.
Date: Monday, January 3, 2011 - 8:04 am

Folded all three 'media' fixes into one and applied with your Ack. Thanks.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: Re: [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.
Date: Friday, December 31, 2010 - 3:33 pm

depends on what the search engine gives you.. diablo did show up
but figured better throw that in to be safe since some definitions 

cheers,

Justin P. Mattock
--


[ message continues ]
[view original message]
From: Jiri Kosina
Subject: Re: [PATCH 08/15]drivers:scsi:lpfc:lpfc_init.c Typo change diable to disable.
Date: Monday, January 3, 2011 - 8:09 am

Folded patched 8, 9, 10 and 13 together and applied.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--


[ message continues ]
[view original message]
From: Larry Finger
Subject: Re: [PATCH 07/15]drivers:net:wireless:iwlwifi Typo change diable to disable.
Date: Friday, December 31, 2010 - 8:33 am

--


[ message continues ]
[view original message]
From: Jiri Kosina
Subject: Re: [PATCH 07/15]drivers:net:wireless:iwlwifi Typo change diable to disable.
Date: Monday, January 3, 2011 - 8:06 am

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--


[ message continues ]
[view original message]
From: John W. Linville
Subject: Re: [PATCH 07/15]drivers:net:wireless:iwlwifi Typo change diable to disable.
Date: Tuesday, January 4, 2011 - 10:56 am

Acked-by: John W. Linville <linville@tuxdriver.com>

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.
--


[ message continues ]
[view original message]
From: Grant Likely
Subject: Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Thursday, December 30, 2010 - 11:45 pm

applied, thanks.

--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Thursday, December 30, 2010 - 11:52 pm

ahh.. thanks.. just cleared up the left out diabled that I had thought I 

Justin P. Mattock
--


[ message continues ]
[view original message]
From: Dan Carpenter
Subject: Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Friday, December 31, 2010 - 2:11 am

This is really just defensiveness and random grumbling and grumpiness on
my part, but one reason I may have missed the first patch is because
your subject lines are crap.

Wrong:  [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.

Right:  [PATCH 02/15] spi/dw_spi: Typo change diable to disable

regards,
dan carpenter
--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Friday, December 31, 2010 - 7:17 am

alright.. so having the backlash is alright for the subject

Thanks for the pointer on this..

Justin P. Mattock
--


[ message continues ]
[view original message]
From: James Bottomley
Subject: Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Friday, December 31, 2010 - 8:06 am

There is actually no specific form.  Most of us edit this part of the
subject line anyway to conform to whatever (nonuniform) conventions we
use.  I just use <component>: with no scsi or drivers prefix because the
git tree is tagged [SCSI]; others are different.

James


--


[ message continues ]
[view original message]
From: Dan Carpenter
Subject: Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Friday, December 31, 2010 - 10:41 am

Well really my point is not so much about backslashes vs colons, it's
about getting the *one* correct prefix.  This stuff is probably
scriptable most of the time, but you may still be required to think a
little on the corner cases.

Here is a script to get you started.

git log --format="%s" drivers/spi/dw_spi.c | \
	head -n 20 |                         \
	perl -ne 's/(.*):.*/$1/; print' |    \
	sort | uniq -c | sort -rn |          \
	perl -ne 's/^\W+\d+ //; print' |     \
	head -n 1

regards,
dan carpenter
--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Friday, December 31, 2010 - 10:59 am

thats a nice little script there(just ran it) any way you want to add 
this into to getmaintainers.pl or something? (this way people get the 
maintainers address plus a subject line in the mix)

Justin P. Mattock
--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: Re: [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable.
Date: Saturday, January 1, 2011 - 12:43 am

no! I changed it to disabled to make it proper..

Justin P. Mattock
--


[ message continues ]
[view original message]
From: Dan Carpenter
Subject: Re: [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable.
Date: Saturday, January 1, 2011 - 2:09 am

Finn is obviously right, but maybe a compromise would be:

Only the value EEPROM_SW_AD_ENABLE means "enable", other values mean
"disable".

regards,
dan carpenter
--


[ message continues ]
[view original message]
From: Justin P. Mattock
Subject: Re: [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable.
Date: Saturday, January 1, 2011 - 7:53 am

ahh.. I see what you your saying now.. alright let me send this out that 
way..

Justin P. Mattock
--


[ message continues ]
Previous thread: [PATCH RFC v2] Consider E820 non-RAM and E820 gaps as 1-1 mappings. by Konrad Rzeszutek Wilk on Thursday, December 30, 2010 - 12:48 pm. (1 message)

Next thread: [PATVH] media, dvb, IX2505V: Remember to free allocated memory in failure path (ix2505v_attach()). by Jesper Juhl on Thursday, December 30, 2010 - 4:11 pm. (8 messages)