| From | Subject | Date |
|---|---|---|
| MR CHEN GUAN | Dear Friend,I have a business suggestion for you.
I have a business suggestion for you worth (US$17,300,000.00)contact me via my
private email for more details (chenguan000@yahoo.com.hk)
--
| Dec 30, 4:40 pm 2010 |
| Stephen Rothwell | linux-next: manual merge of the vfs-scale tree with the tree
Hi Nick,
Today's linux-next merge of the vfs-scale tree got a conflict in
Documentation/filesystems/Locking between commit
b83be6f20a0e468f715b14225c9f897538dfe5ad ("update
Documentation/filesystems/Locking") from Linus' tree and various commits
from the vfs-scale tree.
I fixed it up (as best I could - see below) and can carry the fix as
necessary.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --cc Documentation/filesystems/Locking
index ...
| Dec 30, 4:54 pm 2010 |
| Jesper Juhl | [tip:x86/urgent] x86/microcode: Fix double vfree() and r ...
Hi,
I was asked to submit this to stable since it's clearly a bug and easily
triggerable from userspace. It has now been included in mainline, so here
goes.
/Jesper Juhl
---------- Forwarded message ----------
Date: Mon, 27 Dec 2010 14:16:03 GMT
From: tip-bot for Jesper Juhl <jj@chaosbits.net>
Reply-To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
jj@chaosbits.net, tigran@aivazian.fsnet.co.uk, tglx@linutronix.de,
shaohua.li@intel.com, mingo@elte.hu
To: ...
| Dec 30, 4:30 pm 2010 |
| Jesper Juhl | [PATVH] media, dvb, IX2505V: Remember to free allocated ...
Hi,
We may leak the storage allocated to 'state' in
drivers/media/dvb/frontends/ix2505v.c::ix2505v_attach() on error.
This patch makes sure we free the allocated memory in the failure case.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
ix2505v.c | 1 +
1 file changed, 1 insertion(+)
Compile tested only.
diff --git a/drivers/media/dvb/frontends/ix2505v.c b/drivers/media/dvb/frontends/ix2505v.c
index 55f2eba..fcb173d 100644
--- a/drivers/media/dvb/frontends/ix2505v.c
+++ ...
| Dec 30, 4:11 pm 2010 |
| Justin P. Mattock | [PATCH 08/15]drivers:scsi:lpfc:lpfc_init.c Typo change d ...
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/scsi/lpfc/lpfc_init.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index b306579..a921f16 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -7661,7 +7661,7 @@ lpfc_pci_remove_one_s3(struct pci_dev ...
| Dec 30, 4:07 pm 2010 |
| Justin P. Mattock | [PATCH 05/15]drivers:staging:vt6655:rf.c Typo change dia ...
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/staging/vt6655/rf.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index b8ec783..cdd9165 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -496,11 +496,11 @@ bool s_bAL7230Init (unsigned long dwIoBase)
...
| Dec 30, 4:07 pm 2010 |
| Justin P. Mattock | [PATCH 15/15]drivers:spi:dw_spi.c Typo change diable to ...
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/spi/dw_spi.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
index 7c3cf21..a3a065f 100644
--- a/drivers/spi/dw_spi.c
+++ b/drivers/spi/dw_spi.c
@@ -910,12 +910,12 @@ int __devinit dw_spi_add_host(struct dw_spi *dws)
ret = init_queue(dws);
if ...
| Dec 30, 4:08 pm 2010 |
| Justin P. Mattock | [PATCH 04/15]drivers:staging:comedi:drivers:das800.c Typ ...
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/staging/comedi/drivers/das800.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das800.c b/drivers/staging/comedi/drivers/das800.c
index aecaedc..3ecae47 100644
--- a/drivers/staging/comedi/drivers/das800.c
+++ b/drivers/staging/comedi/drivers/das800.c
@@ -450,7 ...
| Dec 30, 4:07 pm 2010 |
| Justin P. Mattock | [PATCH 12/15]drivers:media:video:tvp7002.c Typo change d ...
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/media/video/tvp7002.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/tvp7002.c b/drivers/media/video/tvp7002.c
index e63b40f..c799e4e 100644
--- a/drivers/media/video/tvp7002.c
+++ b/drivers/media/video/tvp7002.c
@@ -789,7 +789,7 @@ static int tvp7002_query_dv_preset(struct ...
| Dec 30, 4:08 pm 2010 |
| Justin P. Mattock | [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo cha ...
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/media/video/cx18/cx23418.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/cx18/cx23418.h b/drivers/media/video/cx18/cx23418.h
index 2c00980..7e40035 100644
--- a/drivers/media/video/cx18/cx23418.h
+++ b/drivers/media/video/cx18/cx23418.h
@@ -177,7 +177,7 @@
IN[0] - Task ...
| Dec 30, 4:08 pm 2010 |
| Justin P. Mattock | [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to ...
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/spi/dw_spi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
index 0838c79..7c3cf21 100644
--- a/drivers/spi/dw_spi.c
+++ b/drivers/spi/dw_spi.c
@@ -592,7 +592,7 @@ static void pump_transfers(unsigned long data)
spi_set_clk(dws, clk_div ? clk_div : ...
| Dec 30, 4:07 pm 2010 |
| Justin P. Mattock | [PATCH 14/15]include:media:davinci:vpss.h Typo change di ...
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
include/media/davinci/vpss.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/media/davinci/vpss.h b/include/media/davinci/vpss.h
index c59cc02..b586495 100644
--- a/include/media/davinci/vpss.h
+++ b/include/media/davinci/vpss.h
@@ -44,7 +44,7 @@ struct vpss_pg_frame_size {
short pplen;
...
| Dec 30, 4:08 pm 2010 |
| Konrad Rzeszutek Wilk | [PATCH RFC v2] Consider E820 non-RAM and E820 gaps as 1- ...
Please see attached an RFC of second set of patches that augments
how Xen MMU deals with PFNs that point to physical devices. This
patchset is still a development type so sharp edges present.
Changelog: [since v1 https://lkml.org/lkml/2010/12/21/255]:
- Diagrams of P2M included.
- More conservative approach used (memory that is not populated or
identity is considered "missing", instead of as identity).
- Added IDENTITY_PAGE_FRAME bit to uniquely identify 1-1 mappings.
- Optional ...
| Dec 30, 12:48 pm 2010 |
| Konrad Rzeszutek Wilk | [PATCH 4/8] xen/mmu: Warn against races.
The initial bootup code uses set_phys_to_machine quite a lot, and after
bootup it would be used by the balloon driver. The balloon driver does have
mutex lock so this should not be necessary - but just in case, add
a warning if we do hit this scenario.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
arch/x86/xen/mmu.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index 667901f..36bdd2d 100644
--- ...
| Dec 30, 12:48 pm 2010 |
| Konrad Rzeszutek Wilk | [PATCH 7/8] xen/mmu: Introduce IDENTITY_FRAME_BIT
We tack on the IDENTITY_FRAME_BIT on all PFNs which have been
elected during the E820 parsing to be identity mapping.
This way, in case a freak occurs such that pfn_to_mfn(pfn)==pfn
for non-identity PFNs we can guard against that and not consider
it a 1-1 mapping.
Also this will allows us to leverage this and tack on _PAGE_IOMAP
on any page that has IDENTITY_FRAME_BIT set (see:
"xen/mmu: Set _PAGE_IOMAP if PFN is in identity P2M.").
Signed-off-by: Konrad Rzeszutek Wilk ...
| Dec 30, 12:48 pm 2010 |
| Konrad Rzeszutek Wilk | [PATCH 6/8] xen/debug: WARN_ON when 1-1 but no _PAGE_IOM ...
Only enabled if XEN_DEBUG_FS is enabled. We print a warning
when:
pfn_to_mfn(pfn) == pfn, but no VM_IO (_PAGE_IOMAP) flag
pfn_to_mfn(pfn) != pfn, and VM_IO flag is set.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
arch/x86/xen/mmu.c | 37 +++++++++++++++++++++++++++++++++++++
1 files changed, 37 insertions(+), 0 deletions(-)
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index e9dfdd6..d98bd43 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ ...
| Dec 30, 12:48 pm 2010 |
| Konrad Rzeszutek Wilk | [PATCH 8/8] xen/mmu: Set _PAGE_IOMAP if PFN is in identi ...
If we find that the PFN is within the P2M as an identity
make sure to tack on the _PAGE_IOMAP flag.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
arch/x86/xen/mmu.c | 19 +++++++++++++++----
1 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index d470435..158d07a 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -828,7 +828,7 @@ static pteval_t pte_pfn_to_mfn(pteval_t val)
if (val & _PAGE_PRESENT) {
...
| Dec 30, 12:48 pm 2010 |
| Konrad Rzeszutek Wilk | [PATCH 3/8] xen/setup: Set identity mapping for non-RAM ...
We walk the E820 region and start at 0 (for PV guests we start
at ISA_END_ADDRESS) and skip any E820 RAM regions. For all other
regions and as well the gaps we set them to be identity mappings.
The reasons we do not want to set the identity mapping from 0->
ISA_END_ADDRESS when running as PV is b/c that the kernel would
try to read DMI information and fail (no permissions to read that).
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
arch/x86/xen/setup.c | 39 ...
| Dec 30, 12:48 pm 2010 |
| Konrad Rzeszutek Wilk | [PATCH 1/8] xen: Mark all initial reserved pages for the ...
With this patch, we diligently set regions that will be used by the
balloon driver to be INVALID_P2M_ENTRY and under the ownership
of the balloon driver. We are OK using the __set_phys_to_machine
as we do not expect to be allocating any P2M middle or entries pages.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
arch/x86/include/asm/xen/page.h | 1 +
arch/x86/xen/mmu.c | 12 ++++++------
arch/x86/xen/setup.c | 7 ++++++-
drivers/xen/balloon.c ...
| Dec 30, 12:48 pm 2010 |
| Konrad Rzeszutek Wilk | [PATCH 5/8] xen/debug: Print out all pages in the P2M.
We walk over the whole P2M and constructing a simplified view of which
regions belong to what level and what type they are.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
arch/x86/xen/mmu.c | 84 ++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 84 insertions(+), 0 deletions(-)
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index 36bdd2d..e9dfdd6 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -46,6 +46,7 @@
#include ...
| Dec 30, 12:48 pm 2010 |
| Konrad Rzeszutek Wilk | [PATCH 2/8] xen/mmu: Add the notion of identity (1-1) mapping.
Our P2M tree structure is a three-level. On the leaf nodes
we set the Machine Frame Number (MFN) of the PFN. What this means
is that when one does: pfn_to_mfn(pfn), which is used when creating
PTE entries, you get the real MFN of the hardware. When Xen sets
up a guest it initially populates a array which has descending MFN
values, as so:
idx: 0, 1, 2
[0x290F, 0x290E, 0x290D, ..]
so pfn_to_mfn(2)==0x290D. If you start, restart many guests that list
starts looking quite random.
We ...
| Dec 30, 12:48 pm 2010 |
| Geert Uytterhoeven | Build regressions/improvements in v2.6.37-rc8
Below is the list of build error/warning regressions/improvements in
v2.6.37-rc8[1] compared to v2.6.36[2].
Summarized:
- build errors: +91/-11
- build warnings: +245/-133
JFYI, when comparing v2.6.37-rc8 to v2.6.37-rc7[3] (both have full coverage
of the 108 configs), the summaries are:
- build errors: +48/-7
- build warnings: +121/-45
Note that there may be false regressions, as some logs are incomplete.
Still, they're build errors/warnings.
In addition, I put the verbose ...
| Dec 30, 12:42 pm 2010 |
| Mrs. Joy Wilford | I URGE YOU TO THIS FOR THE WORK OF GOD AND HELP THE POOR?
Read Attachment File For More Details About the donation Fund, Thank You.
| Dec 30, 6:13 am 2010 |
| Chris Wilson | Re: [git pull] i915 fixes
[Empty message]
| Dec 30, 3:53 pm 2010 |
| Chris Wilson | Re: [git pull] i915 fixes
My first step was to simply restore the behaviour to 2.3.36 and then look
for an alternate patch. I'd like to give any such patch at least the
chance for smoketesting by QA (and the machines here) before asking
Linus to pull ;-)
There is one interesting difference between the BIOS and KMS clock setting
for the Lenovo U160; the BIOS is able to set n=1, whereas we can't find a
suitable clock with just a single wire. Maybe we can fix the U160 and save
0.1W as well!
As far as I am aware, only ...
| Dec 30, 3:18 pm 2010 |
| Chris Wilson | [git pull] i915 fixes
Hi Linus,
Dave asked to me send this pull request directly to you as he is on
holiday over the New Year. In this batch, there are a few regression
fixes. The most notable being the revert of the SSC frequency switch,
along with a use-before-initialisation introduced much earlier in the
sdvo/hdmi audio enabling and a fix for the loss of correct modesetting on
one particular DVO chipset. Eric also found another instance where we were
not adhering to the specs when setting up Ironlake. The impact ...
| Dec 30, 12:01 pm 2010 |
| Jesse Barnes | Re: [git pull] i915 fixes
On Thu, 30 Dec 2010 19:01:34 +0000
Did you want to disable SSC entirely on gen5+ just so we can get all
the known machines working? It's possible it could add some wifi or
sound interference, but that's better than not having a display (most
of the time).
--
Jesse Barnes, Intel Open Source Technology Center
--
| Dec 30, 3:01 pm 2010 |
| Linus Torvalds | Re: [git pull] i915 fixes
It would be sad to possibly add more electrical noise to machines that
already work with it, but at the same time I do think that "working
screen" tends to be a lot more important than "try to avoid RF noise".
Also, are you sure it's really the fact that we enable spread-spectrum
that causes this? The code is really confused, and seems to mix up
"lvds_use_ssc" not just with the enabling of SSC, but it also with how
impacts the reference clock itself.
And it impacts the reference clock in ...
| Dec 30, 3:29 pm 2010 |
| Martin Mokrejs | linux-2.6.37-rc8: EEPROM_93CX6 which has unmet direct de ...
Hi,
I just went to check the current kernel for fun on my old P4-M based laptop.
I got the following message.
# DISTCC_HOSTS='' make oldconfig
scripts/kconfig/conf --oldconfig Kconfig
warning: (AX88796_93CX6 && NETDEVICES && NET_ETHERNET && AX88796 || RTL8180 && NETDEVICES && WLAN && MAC80211 && PCI && EXPERIMENTAL || RTL8187 && NETDEVICES && WLAN && MAC80211 && USB || ADM8211 && NETDEVICES && WLAN && MAC80211 && PCI && EXPERIMENTAL || RT2400PCI && NETDEVICES && WLAN && RT2X00 && PCI || ...
| Dec 30, 12:31 pm 2010 |
| Tejun Heo | [PATCHSET] x86: unify x86_32 and 64 NUMA init paths, take#4
Hello,
This is the fourth take of unify-x86_32-and-64-NUMA-init-paths
patchset.
The only change from the last take[L] is that it's now based on
tip/x86/numa. Unfortunately, some of the collisions weren't trivial
and led to some ugliness.
Commit c1c3443c ("x86, numa: Fake node-to-cpumask for NUMA emulation")
introduced hard dependency on x86_64 into numa_add/remove_cpu() when
CONFIG_NUMA_EMU is enabled. 0015 has been updated so that the 32/64
bit common versions used when ...
| Dec 30, 10:49 am 2010 |
| H. Peter Anvin | Re: [PATCHSET] x86: unify x86_32 and 64 NUMA init paths, ...
Agreed 100%.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
--
| Dec 30, 1:14 pm 2010 |
| Tejun Heo | [PATCH 08/16] x86: Implement the default x86_32_early_lo ...
Implement x86_32_early_logical_apicid() for the default apic flat
routing.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
arch/x86/kernel/apic/probe_32.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/apic/probe_32.c b/arch/x86/kernel/apic/probe_32.c
index 40be7c3..0f9a9ab 100644
--- a/arch/x86/kernel/apic/probe_32.c
+++ b/arch/x86/kernel/apic/probe_32.c
@@ -77,6 +77,11 @@ void __init default_setup_apic_routing(void)
...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 09/16] x86: Implement x86_32_early_logical_apicid ...
Signed-off-by: Tejun Heo <tj@kernel.org>
---
arch/x86/kernel/apic/bigsmp_32.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/apic/bigsmp_32.c b/arch/x86/kernel/apic/bigsmp_32.c
index dd32a9b..bc7ed04 100644
--- a/arch/x86/kernel/apic/bigsmp_32.c
+++ b/arch/x86/kernel/apic/bigsmp_32.c
@@ -45,6 +45,12 @@ static unsigned long bigsmp_check_apicid_present(int bit)
return 1;
}
+static int bigsmp_early_logical_apicid(int cpu)
+{
+ /* on ...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 11/16] x86: Implement x86_32_early_logical_apicid ...
Signed-off-by: Tejun Heo <tj@kernel.org>
---
arch/x86/kernel/apic/es7000_32.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/apic/es7000_32.c b/arch/x86/kernel/apic/es7000_32.c
index 0ffc1ec..5c53d05 100644
--- a/arch/x86/kernel/apic/es7000_32.c
+++ b/arch/x86/kernel/apic/es7000_32.c
@@ -460,6 +460,12 @@ static unsigned long es7000_check_apicid_present(int bit)
return physid_isset(bit, phys_cpu_present_map);
}
+static int ...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 01/16] x86: Kill unused static boot_cpu_logical_a ...
Signed-off-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
---
arch/x86/kernel/smpboot.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 083e99d..4de6a00 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -165,8 +165,6 @@ static void unmap_cpu_to_node(int cpu)
#endif
#ifdef CONFIG_X86_32
-static int boot_cpu_logical_apicid;
-
u8 ...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 12/16] x86: Replace apic->apicid_to_node() with - ...
apic->apicid_to_node() is 32bit specific apic operation which
determines NUMA node for a CPU. Depending on the APIC implementation,
it can be easier to determine NUMA node from either physical or
logical apicid. Currently, ->apicid_to_node() takes @logical_apicid
and calls hard_smp_processor_id() if the physical apicid is needed.
This prevents NUMA mapping from being queried from a different CPU,
which in turn makes it impossible to initialize NUMA mapping before
SMP bringup.
This patch ...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 13/16] x86: Unify cpu/apicid <-> NUMA node mappin ...
The mapping between cpu/apicid and node is done via apicid_to_node[]
on 64bit and apicid_2_node[] + apic->x86_32_numa_cpu_node() on 32bit.
This difference makes it difficult to further unify 32 and 64bit NUMA
handling.
This patch unifies it by replacing both apicid_to_node[] and
apicid_2_node[] with __apicid_to_node[] array, which is accessed by
two accessors - set_apicid_to_node() and numa_cpu_node(). On 64bit,
numa_cpu_node() always consults __apicid_to_node[] directly while
32bit goes ...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 15/16] x86: Unify node_to_cpumask_map handling be ...
x86_32 has been managing node_to_cpumask_map explicitly from
map_cpu_to_node() and friends in a rather ugly way. With previous
changes, it's now possible to share the code with 64bit.
* When CONFIG_NUMA_EMU is disabled, numa_add/remove_cpu() are
implemented in numa.c and shared by 32 and 64bit. The !NUMA_EMU
implementation is taken from numa_64.c right before c1c3443c ("x86,
numa: Fake node-to-cpumask for NUMA emulation"). CONFIG_NUMA_EMU
versions still live in numa_64.c.
...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 16/16] x86: Unify NUMA initialization between 32 ...
Now that everything else is unified, NUMA initialization can be
unified too.
* numa_init_array() and init_cpu_to_node() are moved from numa_64 to
numa.
* numa_32::initmem_init() is updated to call numa_init_array() and
setup_arch() to call init_cpu_to_node() on 32bit too.
* x86_cpu_to_node_map is now initialized to NUMA_NO_NODE on 32bit too.
This is safe now as numa_init_array() will initialize it early
during boot.
This makes NUMA mapping fully initialized before ...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 14/16] x86: Unify CPU -> NUMA node mapping betwee ...
Unlike 64bit, 32bit has been using its own cpu_to_node_map[] for CPU
-> NUMA node mapping. Replace it with early_percpu variable
x86_cpu_to_node_map and share the mapping code with 64bit.
* USE_PERCPU_NUMA_NODE_ID is now enabled for 32bit too.
* x86_cpu_to_node_map and numa_set/clear_node() are moved from numa_64
to numa. For now, on 32bit, x86_cpu_to_node_map is initialized with
0 instead of NUMA_NO_NODE. This is to avoid introducing unexpected
behavior change and will be updated ...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 07/16] x86: Add apic->x86_32_early_logical_apicid()
On x86_32, the mapping between cpu and logical apic ID differs
depending on the specific apic implementation in use. The mapping is
initialized while bringing up CPUs; however, this makes early inits
ignore memory topology.
Add a x86_32 specific apic->x86_32_early_logical_apicid() which is
called early during boot to query the mapping. The mapping is later
verified against the result of init_apic_ldr(). The method is allowed
to return BAD_APICID if it can't be determined early.
noop ...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 06/16] x86: Kill apic->cpu_to_logical_apicid()
After the previous patch, apic->cpu_to_logical_apicid() is no longer
used. Kill it.
For apic types with custom cpu_to_logical_apicid() which is also used
for other purposes, remove the function and modify its users to do the
mapping directly.
#ifdef's on CONFIG_SMP in es7000_32 and summit_32 are ignored during
conversion as they are not used for UP kernels.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
arch/x86/include/asm/apic.h | 7 -------
...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 04/16] x86: Replace cpu_2_logical_apicid[] with e ...
Unlike x86_64, on x86_32, the mapping from cpu to logical apicid may
vary depending on apic in use. cpu_2_logical_apicid[] array is used
for this mapping. Replace it with early percpu variable
x86_cpu_to_logical_apicid to make it better aligned with other
mappings.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
arch/x86/include/asm/apic.h | 4 ----
arch/x86/include/asm/smp.h | 3 +++
arch/x86/kernel/apic/apic.c | 11 +++++++++++
arch/x86/kernel/apic/es7000_32.c | ...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 02/16] x86: Rename x86_32 MAX_APICID to MAX_LOCAL_APIC
Replace x86_32 MAX_APICID in include/asm/mpspec.h with MAX_LOCAL_APIC
in include/asm/apicdef.h to make it consistent with x86_64.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
---
arch/x86/include/asm/apicdef.h | 1 +
arch/x86/include/asm/mpspec.h | 2 --
arch/x86/kernel/smpboot.c | 2 +-
arch/x86/mm/srat_32.c | 4 ++--
4 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/arch/x86/include/asm/apicdef.h ...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 05/16] x86: Always use x86_cpu_to_logical_apicid ...
Currently, cpu -> logical apic id translation is done by
apic->cpu_to_logical_apicid() callback which may or may not use
x86_cpu_to_logical_apicid. This is unnecessary as it should always
equal logical_smp_processor_id() which is known early during CPU bring
up.
Initialize x86_cpu_to_logical_apicid after apic->init_apic_ldr() in
setup_local_APIC() and always use x86_cpu_to_logical_apicid for cpu ->
logical apic id mapping.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 10/16] x86: Implement x86_32_early_logical_apicid ...
Factor out logical apic id calculation from summit_init_apic_ldr() and
use it for the x86_32_early_logical_apicid() callback.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
arch/x86/kernel/apic/summit_32.c | 17 ++++++++++++-----
1 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/apic/summit_32.c b/arch/x86/kernel/apic/summit_32.c
index 172c498..8c91473 100644
--- a/arch/x86/kernel/apic/summit_32.c
+++ b/arch/x86/kernel/apic/summit_32.c
@@ -194,11 +194,10 @@ ...
| Dec 30, 10:49 am 2010 |
| Tejun Heo | [PATCH 03/16] x86: Make default_send_IPI_mask_sequence/a ...
Both functions are used only in 32bit. Put them inside CONFIG_X86_32.
This is to prepare for logical apicid handling update.
- Cyrill Gorcunov spotted that I forgot to move declarations in ipi.h
under CONFIG_X86_32. Fixed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
arch/x86/include/asm/ipi.h | 8 ++++----
arch/x86/kernel/apic/ipi.c | 4 ++--
2 files changed, 6 insertions(+), 6 ...
| Dec 30, 10:49 am 2010 |
| Linus Torvalds | Re: still nfs problems [Was: Linux 2.6.37-rc8]
On Thu, Dec 30, 2010 at 11:25 AM, Trond Myklebust
But if we don't have any lseek's, the readdir cache should trivially
take care of this by just incrementing the page_index, and we should
return to user space the (eventually ending) sequence, even if there
are duplicate numbers.
(Also, I suspect that "page_index" should not be a page index, but a
position, and then you the "search_for_pos()" should use that instead
of the file_pos/current_index thing, but that's a detail that would
show up ...
| Dec 30, 1:02 pm 2010 |
| Trond Myklebust | Re: still nfs problems [Was: Linux 2.6.37-rc8]
Ccing linux-nfs@vger.kernel.org
What filesystem are you exporting on the server? What is the NFS
version? Is this nfsroot, autofs or an ordinary nfs mount?
In short, how can we reproduce this?
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
--
| Dec 30, 10:59 am 2010 |
| Uwe Kleine-König | still nfs problems [Was: Linux 2.6.37-rc8]
Hello,
I wonder if the nfs-stuff is considered to be solved, because I still
see strange things.
During boot my machine sometimes (approx one out of two times) hangs with
the output pasted below on Sysctl-l. The irq
I'm not 100% sure it's related, but at least it seems to hang in
nfs_readdir. (When the serial irq happend that triggered the sysrq the
program counter was at 0xc014601c, which is fs/nfs/dir.c:647 for me.)
This is on 2.6.37-rc8 plus some patches for machine support on an ...
| Dec 30, 10:14 am 2010 |
| Linus Torvalds | Re: still nfs problems [Was: Linux 2.6.37-rc8]
Please cc the poor hapless NFS people too, who probably otherwise
wouldn't see it. And Arnd just in case it might be locking-related.
Trond, any ideas? The sysrq thing does imply that it's stuck in some
busy-loop in fs/nfs/dir.c, and line 647 is get_cache_page(), which in
turn implies that the endless loop is either the loop in
readdir_search_pagecache() _or_ in a caller. In particular, the
EBADCOOKIE case in the caller (nfs_readdir) looks suspicious. What
protects us from endless streams of ...
| Dec 30, 10:57 am 2010 |
| Trond Myklebust | Re: still nfs problems [Was: Linux 2.6.37-rc8]
There is nothing we can do to protect ourselves against an infinite loop
if the server (or underlying filesystem) is breaking the rules w.r.t.
cookie generation. It should be possible to recover from all other
situations.
IOW: if the server generates non-unique cookies, then we're screwed.
Fixing that particular problem is impossible since it is basically a
variant of the halting problem.
That was why I asked which filesystem is being exported in my previous
reply.
The point of ...
| Dec 30, 11:24 am 2010 |
| Linus Torvalds | Re: still nfs problems [Was: Linux 2.6.37-rc8]
On Thu, Dec 30, 2010 at 10:24 AM, Trond Myklebust
Umm. Sure there is. Just make sure that you return the uncached entry
to user space, rather than loop forever.
Looping forever in kernel space is a bad idea. How about just changing
the "continue" into a "break" for the "uncached readdir returned
success".
No halting problems, no excuses. There is absolutely _no_ excuse for
an endless loop in kernel mode. Certainly not "the other end is
incompetent".
EVERYBODY is incompetent sometimes. ...
| Dec 30, 11:50 am 2010 |
| Trond Myklebust | Re: still nfs problems [Was: Linux 2.6.37-rc8]
uncached_readdir is not really a problem. The real problem is
filesystems that generate "infinite directories" by producing looping
combinations of cookies.
IOW: I've seen servers that generate cookies in a sequence of a form
vaguely resembling
1 2 3 4 5 6 7 8 9 10 11 12 3...
(with possibly a thousand or so entries between the first and second
copy of '3')
The kernel won't loop forever with something like that (because
eventually filldir() will declare it is out of buffer space), ...
| Dec 30, 12:25 pm 2010 |
| Uwe Kleine-König | Re: still nfs problems [Was: Linux 2.6.37-rc8]
Hi Trond,
Yeah, good idea. I had that ~2min after sending my report during
This is an nfsroot of /home/ukl/nfsroot/tx28 which is a symlink to a
directory on a different partition. I don't know the filesystem of my
homedir as it resides on a server I have no access to, but I asked the
admin, so I can follow up with this info later (I'd suspect ext3, too).
The real root directory is on ext3 (rw,noatime).
The serving nfs-server is Debian's nfs-kernel-server 1:1.2.2-1.
nfs-related kernel ...
| Dec 30, 12:18 pm 2010 |
| Udo van den Heuvel | GPIO on VIA Epia
Hello,
Did anyone do some work on a driver to use the GPIO pins on the VIA Epia
boards based around the vt8237 or CX700?
E.g. my Epia LT offers 8 programamble GPIO pins according to the
documentation (see below for layout) but I'd like to know if there is a
driver so I can actually use them and e.g. receive an interrupt when a
GPIO goes high or low.
Please let us know what is available.
Thanks,
Udo
Epia LT documentation:
Digital I/O Connector: DIO
General purpose input and output ...
| Dec 30, 9:20 am 2010 |
| Samson Yeung | Kernel oops - help interpreting partial trace info
Hello,
(Sent to the output of ./scripts/get_maintainer.pl -f
kernel/sched_fair.c - please CC me as I am not on-list.)
Some of our customer's systems running a 2.6.32.11 kernel.org kernel
crash, leaving the attached partial oops on screen. I doubt it is a
hardware problem since we've already replaced one system and the
problem came back.
I run the values after "Code:" from the bottom of the oops through
linux-2.6/scripts/decode/code as described in
Documentation/oops-tracing.txt, and ...
| Dec 30, 9:35 am 2010 |
| Pawel Sikora | [2.6.37-rc8] BUG kmalloc-256: Poison overwritten.
hi,
i'm currently testing mainline kernel to isolate some ugly fault
which corrupts memory (see https://bugzilla.kernel.org/show_bug.cgi?id=25782).
during soft raid reogranization (stopping e92.0,e93.0 AoE exports -> dropping md2, md3
-> recreating one bigger md2 -> reexporting md2 as e92.0) i've observed some debug
messages (slub_debug=FZPU) in dmesg.
(...)
[ 77.175405] md3: detected capacity change from 0 to 434951421952
[ 77.188128] md3: unknown partition table
[ 77.235477] md2: ...
| Dec 30, 8:08 am 2010 |
| Pekka Enberg | Re: [2.6.37-rc8] BUG kmalloc-256: Poison overwritten.
This looks like a use-after-free bug somewhere in drivers/md/raid10.c.
Pekka
--
| Dec 30, 8:31 am 2010 |
| =?utf-8?q?Pawe=C5=82 ... | Re: [2.6.37-rc8] BUG kmalloc-256: Poison overwritten.
i think it's quite easy to reproduce this problem. here's a mini howto:
- setup two raid10 matrices.
[root@odra ~]# cat /proc/mdstat
Personalities : [raid1] [raid0] [raid10]
md3 : active raid10 sdd4[1] sdc4[0]
424757248 blocks super 1.2 512K chunks 2 far-copies [2/2] [UU]
[>....................] resync = 0.4% (1966592/424757248) finish=82.4min speed=85504K/sec
md2 : active raid10 sdb4[1] sda4[0]
424757248 blocks super 1.2 512K chunks 2 far-copies [2/2] [UU]
...
| Dec 30, 12:39 pm 2010 |
| Pekka Enberg | Re: [2.6.37-rc8] BUG kmalloc-256: Poison overwritten.
Does reverting commit 4e78064f42ad474ce9c31760861f7fb0cfc22532 ("md:
Fix possible deadlock with multiple mempool allocations.") fix the
problem?
--
| Dec 30, 8:59 am 2010 |
| Neil Brown | Re: [2.6.37-rc8] BUG kmalloc-256: Poison overwritten.
Please report exactly which kernel you are running (git hash of head) and in
particular whether
commit 589a594be1fb8815b3f18e517be696c48664f728
is present?
It looks like something tried to lock conf->device_lock after conf had been
freed. It is possible that that could happen due to the bug fixed by the
above commit.
Thanks,
NeilBrown
--
| Dec 30, 4:00 pm 2010 |
| folkert | block device without page cache buffering
Hi,
What should a block device driver need to do to get all read/write
requests without any buffering from the page cache?
I think the iscsi initiation does this.
This is needed to get an existing pseudo block device to function as a
shared storage so that a cluster filesystem (gpfs/ocfs) can be put on it (nbd).
Folkert van Heusden
--
Nagios user? Check out CoffeeSaint - the versatile Nagios status
viewer! ...
| Dec 30, 7:37 am 2010 |
| tapio.vihuri | [PATCH v2 0/3] input: Add support for ECI (multimedia) a ...
From: Tapio Vihuri <tapio.vihuri@nokia.com>
Thank you for comments.
In series two there Kconfig dependency problem fixed, preventing compilation
if X86_MRST (Intel Moorestown) or INPUT_MISC is not selected.
Also created against linux-2.6.37-rc8
--- v1 message ---
Hi all
This patch set introduce Multimedia Headset Accessory support for
Nokia phones. Technically those are known as ECI (Enhancement Control Interface)
If headset has many buttons, like play, vol+, vol- etc. then it is ...
| Dec 30, 6:36 am 2010 |
| tapio.vihuri | [PATCH v2 1/3] ECI: input: introduce ECI accessory input ...
From: Tapio Vihuri <tapio.vihuri@nokia.com>
ECI stands for (Enhancement Control Interface).
ECI is better known as Multimedia Headset for Nokia phones.
If headset has many buttons, like play, vol+, vol- etc. then it is propably
ECI accessory.
Among several buttons ECI accessory contains memory for storing several
parameters.
ECI input driver provides the following features:
- reading ECI configuration memory
- ECI buttons as input events
Signed-off-by: Tapio Vihuri ...
| Dec 30, 6:36 am 2010 |
| tapio.vihuri | [PATCH v2 2/3] ECI: introducing ECI bus driver
From: Tapio Vihuri <tapio.vihuri@nokia.com>
ECI bus controller is kind of bridge between host CPU I2C and ECI accessory
ECI communication.
Signed-off-by: Tapio Vihuri <tapio.vihuri@nokia.com>
---
drivers/Kconfig | 2 +
drivers/Makefile | 1 +
drivers/ecibus/Kconfig | 35 +++
drivers/ecibus/Makefile | 10 +
drivers/ecibus/ecibus.c | 583 +++++++++++++++++++++++++++++++++++++++++++++
include/linux/input/eci.h | 8 +
6 files changed, 639 ...
| Dec 30, 6:36 am 2010 |
| tapio.vihuri | [PATCH v2 3/3] ECI: adding platform data for ECI driver
From: Tapio Vihuri <tapio.vihuri@nokia.com>
Gives platform data for ECI accessory input driver and
ECI bus controller driver.
Signed-off-by: Tapio Vihuri <tapio.vihuri@nokia.com>
---
arch/x86/platform/mrst/mrst.c | 59 +++++++++++++++++++++++++++++++++++++++++
1 files changed, 59 insertions(+), 0 deletions(-)
diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
index 79ae681..60dca78 100644
--- a/arch/x86/platform/mrst/mrst.c
+++ ...
| Dec 30, 6:36 am 2010 |
| Joe Jin | [patch] xenfb: fix xenfb suspend/resume race
Hi,
when do migration test, we hit the panic as below:
<1>BUG: unable to handle kernel paging request at 0000000b819fdb98
<1>IP: [<ffffffff812a588f>] notify_remote_via_irq+0x13/0x34
<4>PGD 94b10067 PUD 0
<0>Oops: 0000 [#1] SMP
<0>last sysfs file: /sys/class/misc/autofs/dev
<4>CPU 3
<4>Modules linked in: autofs4(U) hidp(U) nfs(U) fscache(U) nfs_acl(U)
auth_rpcgss(U) rfcomm(U) l2cap(U) bluetooth(U) rfkill(U) lockd(U) sunrpc(U)
nf_conntrack_netbios_ns(U) ipt_REJECT(U) ...
| Dec 30, 5:56 am 2010 |
| Konrad Rzeszutek Wilk | Re: [patch] xenfb: fix xenfb suspend/resume race
Joe,
Patch looks good, however..
I am unclear from your description whether the patch fixes
the problem (I would presume so). Or does it take a long time
--
| Dec 30, 9:40 am 2010 |
| Mark Brown | [PATCH] i2c: Factor out runtime suspend checks from PM o ...
When devices use dev_pm_ops the I2C API is implementing standard functionality
for integration with runtime PM and for checking for the presence of a per
device op. The PM core provides pm_generic_ functions implementing this
behaviour - use them to reduce coupling with future PM updates.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/i2c/i2c-core.c | 68 ++++++++++++++---------------------------------
1 files changed, 20 insertions(+), 48 deletions(-)
diff ...
| Dec 30, 5:40 am 2010 |
| manjunatha_halli | [RFC V8 0/7] FM V4L2 drivers for WL128x
From: Manjunatha Halli <manjunatha_halli@ti.com>
Mauro and the list,
This is the v8 version of the TI WL128x FM V4L2 drivers patchset.
This introduces wl128x folder under the drivers/media/radio which cater
to FM core on Texas Instrument's WL128x (also compatible with WL127x)
WiLink chipsets.
WL128x's FM can work in either Rx or Tx mode, and V4L2 interfaces are
provided for both.
** patch description **
Texas Instrument's WL128x chipset packs BT, FM, GPS and WLAN in a single
die with ...
| Dec 30, 4:11 am 2010 |
| manjunatha_halli | [RFC V8 1/7] drivers:media:radio: wl128x: fmdrv common h ...
From: Manjunatha Halli <manjunatha_halli@ti.com>
These are common headers used in FM submodules (FM V4L2,
FM common, FM Rx,and FM TX).
Signed-off-by: Manjunatha Halli <manjunatha_halli@ti.com>
---
drivers/media/radio/wl128x/fmdrv.h | 248 ++++++++++++++++++++++++++++++++++++
1 files changed, 248 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/radio/wl128x/fmdrv.h
diff --git a/drivers/media/radio/wl128x/fmdrv.h b/drivers/media/radio/wl128x/fmdrv.h
new file mode ...
| Dec 30, 4:11 am 2010 |
| Hans Verkuil | Re: [RFC V8 1/7] drivers:media:radio: wl128x: fmdrv comm ...
This define seems to be a leftover from previous versions and should be removed.
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by Cisco
--
| Dec 30, 4:01 am 2010 |
| Hans Verkuil | Re: [RFC V8 1/7] drivers:media:radio: wl128x: fmdrv comm ...
Hi,
Below I have some suggestions on how to improve some of the names in this header.
In general I prefer to use the kernel types u8, u16 and u32. The names of
these types are 1) much shorter and 2) mean the same on any CPU.
Personally I would also remove the "_byte" part of the name. It's rather
obvious that it is a byte after all. And perhaps (this may or may not make
'handlers'
We already know that these fields are related to interrupts since they are
in the fm_irq ...
| Dec 30, 8:23 am 2010 |
| manjunatha_halli | [RFC V8 6/7] drivers:media:radio: wl128x: Kconfig & Make ...
From: Manjunatha Halli <manjunatha_halli@ti.com>
Signed-off-by: Manjunatha Halli <manjunatha_halli@ti.com>
---
drivers/media/radio/wl128x/Kconfig | 17 +++++++++++++++++
drivers/media/radio/wl128x/Makefile | 6 ++++++
2 files changed, 23 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/radio/wl128x/Kconfig
create mode 100644 drivers/media/radio/wl128x/Makefile
diff --git a/drivers/media/radio/wl128x/Kconfig b/drivers/media/radio/wl128x/Kconfig
new file mode ...
| Dec 30, 4:11 am 2010 |
| manjunatha_halli | [RFC V8 2/7] drivers:media:radio: wl128x: fmdrv_v4l2 sources
From: Manjunatha Halli <manjunatha_halli@ti.com>
This module interfaces V4L2 subsystem and FM common module.
It registers itself with V4L2 as Radio module.
Signed-off-by: Manjunatha Halli <manjunatha_halli@ti.com>
---
drivers/media/radio/wl128x/fmdrv_v4l2.c | 593 +++++++++++++++++++++++++++++++
drivers/media/radio/wl128x/fmdrv_v4l2.h | 33 ++
2 files changed, 626 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/radio/wl128x/fmdrv_v4l2.c
create mode 100644 ...
| Dec 30, 4:11 am 2010 |
| manjunatha_halli | [RFC V8 3/7] drivers:media:radio: wl128x: fmdrv_common sources
From: Manjunatha Halli <manjunatha_halli@ti.com>
These are the sources for the common interfaces required by the
FM V4L2 driver for TI WL127x and WL128x chips.
These implement the FM channel-8 protocol communication with the
chip. This makes use of the Shared Transport as its transport.
Signed-off-by: Manjunatha Halli <manjunatha_halli@ti.com>
---
drivers/media/radio/wl128x/fmdrv_common.c | 1970 +++++++++++++++++++++++++++++
drivers/media/radio/wl128x/fmdrv_common.h | 402 ++++++
2 ...
| Dec 30, 4:11 am 2010 |
| manjunatha_halli | [RFC V8 4/7] drivers:media:radio: wl128x: FM driver RX sources
From: Manjunatha Halli <manjunatha_halli@ti.com>
This has implementation for FM RX functionality.
It communicates with FM V4l2 module and FM common module
Signed-off-by: Manjunatha Halli <manjunatha_halli@ti.com>
---
drivers/media/radio/wl128x/fmdrv_rx.c | 904 +++++++++++++++++++++++++++++++++
drivers/media/radio/wl128x/fmdrv_rx.h | 59 +++
2 files changed, 963 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/radio/wl128x/fmdrv_rx.c
create mode 100644 ...
| Dec 30, 4:11 am 2010 |
| manjunatha_halli | [RFC V8 5/7] drivers:media:radio: wl128x: FM driver TX sources
From: Manjunatha Halli <manjunatha_halli@ti.com>
This has implementation for FM TX functionality.
It communicates with FM V4l2 module and FM common module.
Signed-off-by: Manjunatha Halli <manjunatha_halli@ti.com>
---
drivers/media/radio/wl128x/fmdrv_tx.c | 438 +++++++++++++++++++++++++++++++++
drivers/media/radio/wl128x/fmdrv_tx.h | 37 +++
2 files changed, 475 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/radio/wl128x/fmdrv_tx.c
create mode 100644 ...
| Dec 30, 4:11 am 2010 |
| Hans Verkuil | Re: [RFC V8 3/7] drivers:media:radio: wl128x: fmdrv_comm ...
Hi Manjunatha,
Below is a review of this code. There is a lot that can be improved here and
I'll give some code examples on how to do it.
Don't use forward declarations, instead just move these functions forward in the
Why the void *? You know it is always a struct fmdrv_ops *! That way you don't
I suggest that you add two little helper functions here:
static inline void fm_irq_call(struct fmdrv_ops *fmdev)
{
...
| Dec 30, 6:06 am 2010 |
| manjunatha_halli | [RFC V8 7/7] drivers:media:radio: Update Kconfig and Mak ...
From: Manjunatha Halli <manjunatha_halli@ti.com>
Signed-off-by: Manjunatha Halli <manjunatha_halli@ti.com>
---
drivers/media/radio/Kconfig | 3 +++
drivers/media/radio/Makefile | 1 +
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
index 83567b8..4529bc7 100644
--- a/drivers/media/radio/Kconfig
+++ b/drivers/media/radio/Kconfig
@@ -452,4 +452,7 @@ config RADIO_TIMBERDALE
found behind the Timberdale FPGA on ...
| Dec 30, 4:11 am 2010 |
| Fabien Marteau | [PATCH] input: joystick: Adding Austria Microsystem AS ...
Driver for EasyPoint AS5011 2 axis joystick chip. This chip is plugged
on an I2C bus. It has been tested on ARM processor (i.MX27).
Interruptions are now managed by threaded irq.
Signed-off-by: Fabien Marteau <fabien.marteau@armadeus.com>
---
drivers/input/joystick/Kconfig | 9 +
drivers/input/joystick/Makefile | 1 +
drivers/input/joystick/as5011.c | 417 +++++++++++++++++++++++++++++++++++++++
include/linux/as5011.h | 76 +++++++
4 files changed, 503 insertions(+), 0 ...
| Dec 30, 3:37 am 2010 |
| Nitin Gupta | Re: [PATCH][zram] Do not check for init flag before star ...
This commit shows oops in zram_inc_stat() which does not exist in
staging tree version of zram. Its actually a problem with zram version
as present in project's own repository where we allocate struct
zram_stats_cpu upon device initialization. OTOH, In mainline/staging
version of zram, we allocate struct stats upfront, so this oops cannot
happen in mainline version.
So, this commit is not even applicable for mainline/staging tree. My
I will now end development on local project ...
| Dec 30, 12:02 pm 2010 |
| Linus Torvalds | Re: [PATCH][zram] Do not check for init flag before star ...
Ok. So it really is a revert, and the commit message for the revert
should have explained that.
I changed the commit message appropriately, and committed it as the
attached commit.
Linus
| Dec 30, 1:09 pm 2010 |
| Linus Torvalds | Re: [PATCH][zram] Do not check for init flag before star ...
.. and apparently it oopses without it.
See commit 7e24cce38a99f3 which added the code that you now remove.
You were cc'd on it, I don't think we got any reply to it.
So no. I'm not taking this without way more explanations of why the
original problem isn't a problem any more.
Linus
--
| Dec 30, 10:17 am 2010 |
| Nitin Gupta | [PATCH][zram] Do not check for init flag before starting I/O
zram module is unusable without this fix.
Checking for init_done flag in zram_make_request() results in a
*no-op* for any I/O operation since we simply always return
success. This flag is actually set when the first write occurs
on a zram disk which triggers its initialization.
Bug report: https://bugzilla.kernel.org/show_bug.cgi?id=25722
Reported-by: Dennis Jansen <dennis.jansen@web.de>
Signed-off-by: Nitin Gupta <ngupta@vflare.org>
---
drivers/staging/zram/zram_drv.c | 6 ------
1 ...
| Dec 30, 2:07 am 2010 |
| Johannes Berg | Re: [PATCH] mac80211: fix mesh forwarding when ratelimited too
Oops, good catch! Thanks.
johannes
--
| Dec 30, 1:53 am 2010 |
| Mike Hommey | Containers and /proc/sys/vm/drop_caches
Hi,
I noticed that from within a lxc container, writing "3" to
/proc/sys/vm/drop_caches would flush the host page cache. That sounds a
little dangerous for VPS offerings that would be based on lxc, as in one
VPS instance root user could impact the overall performance of the host.
I don't know about other containers but I've been told openvz isn't
subject to this problem.
I only tested the current Debian Squeeze kernel, which is based on
2.6.32.27.
Cheers,
Mike
--
| Dec 30, 12:59 am 2010 |
| Rob Landley | Re: Containers and /proc/sys/vm/drop_caches
There's a containers@vger mailing list for this stuff, you might have better
I've been coming up to speed on this area recently: openvz has a lot of stuff
that isn't in the main kernel, but it's based on an approach that didn't get
merged into the kernel (using new syscalls to control container stuff).
Instead Google's rewrite of sgi's cgroup stuff went in for process grouping
(based on the cgroup filesystem), and a half-dozen different types of
namespaces are based on flags to clone(), and ...
| Dec 30, 1:57 am 2010 |
| Adam Nielsen | Why do programs freeze with big network transfers?
Hi all,
I'm a bit stuck on this problem so I hope someone can help. My desktop PC is
running kernel 2.6.33.1 and when I copy some largish files (2-3GB each) onto
an NFS share my PC becomes unusable, pretty much locking up for 60 seconds at
a time.
Everything works fine for a little while once the copy has begun - the files
are read off the software-RAID-0 disks at about 200MB/sec, then after 10
seconds or so data starts going across the gigabit network at about 40MB/sec
(speed limited ...
| Dec 30, 12:25 am 2010 |
| Eric Dumazet | Re: Why do programs freeze with big network transfers?
CC netdev
This rings a bell here, could you try to apply commit
482964e56e1320cb7952faa1932d8ecf59c4bf75
(net: Fix the condition passed to sk_wait_event())
This commit was included in 2.6.36, so you could also try 2.6.36.2
kernel.
http://git2.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=48296...
Thanks
--
| Dec 30, 12:58 am 2010 |
| Rabin Vincent | Re: [PATCH] GIC: Assign correct flow handler type in set ...
On Thu, Dec 30, 2010 at 10:59 AM, Abhijeet Dharmapurikar
Why does the flow handler hit when the interrupt is disabled? Have you set
--
| Dec 29, 11:27 pm 2010 |
| Abhijeet Dharmapurikar | [PATCH] GIC: Assign correct flow handler type in set_typ ...
There are some interrupts that are true edge triggered in nature. If not
marked IRQ_PENDING, when disabled, they will be lost.
Use the set_type callback to assign the correct flow type handler for
shared peripheral interrupts.
Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
---
This came to light when a edge triggered interrupt was supposed to wakeup the
sytem. The flow handler was set to the default handle_level_irq. On the resume
path the flow handler was invoked right ...
| Dec 29, 10:29 pm 2010 |
| Rabin Vincent | Re: i2c runtime suspend and system wide suspend
On Thu, Dec 30, 2010 at 10:09 AM, Abhijeet Dharmapurikar
This was discussed on linux-pm recently. Rafael had a fix, I'm don't know
whether it's applied yet:
https://lists.linux-foundation.org/pipermail/linux-pm/2010-December/029567.html
https://lists.linux-foundation.org/pipermail/linux-pm/2010-December/029596.html
Also ...
| Dec 29, 11:32 pm 2010 |
| Rafael J. Wysocki | Re: i2c runtime suspend and system wide suspend
Yes, the fix is already in the Linus' tree:
I'm not sure what happened to the last patch. Is there a new version?
If so, is it going to be pushed through the i2c tree, or should I take it?
Rafael
--
| Dec 30, 3:49 am 2010 |
| Abhijeet Dharmapurikar | i2c runtime suspend and system wide suspend
The i2c-core driver mixes runtime suspend and system wide suspend, in
that, during a system wide suspend, it skips calling ->suspend if the
device is runtime suspended.
I have an interrupt controller running over the i2c bus and that driver
is oblivious of the runtime pm framework, IOW, it doesn't do any runtime
pm calls. CONFIG_RUNTIME_PM is enabled however (for some other bus
drivers). The issue I am facing is that all such i2c devices are assumed
runtime suspended and the ->suspend for ...
| Dec 29, 9:39 pm 2010 |
| Mark Brown | Re: i2c runtime suspend and system wide suspend
Jean appears to be on holiday for the Christmas vacation. I do have a
new version which I'll post later today. Since it depends on the patch
protoyping the generic API calls which the SPI patch also depends on
it'd probably be best to merge via your tree.
--
| Dec 30, 4:35 am 2010 |
| David Rientjes | Re: [patch 1/8] init: rename CONFIG_EMBEDDED to CONFIG_EXPERT
Ok, so there are a few pending EMBEDDED dependency additions in linux-next
as of next-20101230, which should be a pretty good indicator of what type
of conflict we might risk during the merge window.
- three new defconfig files:
89ba4d12: arch/arm/configs/ag5evm_defconfig
6cfce27c: arch/arm/configs/omap1_defconfig
d58f0967: arch/blackfin/configs/BF561-EZKIT-SMP_defconfig
- 3ce05168 (drm/kms: load fbcon from drm_kms_helper)
- b595076a (tree-wide: fix comment/printk ...
| Dec 30, 12:17 pm 2010 |
| Arnd Bergmann | Re: [patch 1/8] init: rename CONFIG_EMBEDDED to CONFIG_EXPERT
How about leaving it that way during the merge window even? That would
help people sending git pull requests that add new dependencies on
CONFIG_EMBEDDED. David can submit another patch that removes the
temporary CONFIG_EMBEDDED option along with any new users in -rc2
or for 2.6.39 then.
Arnd
--
| Dec 30, 5:50 am 2010 |
| Robin Holt | Re: [patch 1/8] init: rename CONFIG_EMBEDDED to CONFIG_EXPERT
That would be fine with me, but I don't think my vote counts for much.
I was just trying to help prevent the bisectability of your patchset.
Robin
--
| Dec 30, 6:10 am 2010 |
| Ingo Molnar | Re: [patch 1/8] init: rename CONFIG_EMBEDDED to CONFIG_EXPERT
Nice! For all patches:
Reviewed-by: Ingo Molnar <mingo@elte.hu>
Ingo
--
| Dec 30, 2:04 am 2010 |
| David Rientjes | [patch 7/8] lib: rename CONFIG_EMBEDDED to CONFIG_EXPERT
CONFIG_EMBEDDED has been renamed to CONFIG_EXPERT, so fix it in the lib/
directory.
Signed-off-by: David Rientjes <rientjes@google.com>
---
lib/Kconfig.debug | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -656,7 +656,7 @@ config DEBUG_HIGHMEM
Disable for production systems.
config DEBUG_BUGVERBOSE
- bool "Verbose BUG() reporting (adds 70K)" if DEBUG_KERNEL && ...
| Dec 29, 9:02 pm 2010 |
| David Rientjes | [patch 1/8] init: rename CONFIG_EMBEDDED to CONFIG_EXPERT
The meaning of CONFIG_EMBEDDED has long since been obsoleted; the option
is used to configure any non-standard kernel with a much larger scope
than only small devices.
This patch renames the option to CONFIG_EXPERT in init/Kconfig and fixes
references to the option in the same file. Followup patches will fix the
remainder of the occurrences in the tree.
Calling the option "EXPERT" more accurately represents its intention:
only expert users who understand the impact of the configuration ...
| Dec 29, 9:02 pm 2010 |
| David Rientjes | [patch 2/8] arch: rename CONFIG_EMBEDDED to CONFIG_EXPERT
CONFIG_EMBEDDED has been renamed to CONFIG_EXPERT, so fix it in the
arch/ directory.
Signed-off-by: David Rientjes <rientjes@google.com>
---
arch/arm/configs/am200epdkit_defconfig | 2 +-
arch/arm/configs/ams_delta_defconfig | 2 +-
arch/arm/configs/at572d940hfek_defconfig | 2 +-
arch/arm/configs/badge4_defconfig | 2 +-
arch/arm/configs/bcmring_defconfig | 2 +-
arch/arm/configs/cm_x2xx_defconfig ...
| Dec 29, 9:02 pm 2010 |
| David Rientjes | [patch 3/8] drivers: rename CONFIG_EMBEDDED to CONFIG_EXPERT
CONFIG_EMBEDDED has been renamed to CONFIG_EXPERT, so fix it in the
drivers/ directory.
Signed-off-by: David Rientjes <rientjes@google.com>
---
drivers/acpi/Kconfig | 2 +-
drivers/ata/Kconfig | 2 +-
drivers/base/Kconfig | 2 +-
drivers/char/Kconfig | 10 +++---
drivers/cpufreq/Kconfig | 2 +-
drivers/firmware/Kconfig | 2 +-
drivers/gpu/drm/Kconfig | 2 +-
...
| Dec 29, 9:02 pm 2010 |
| David Rientjes | [patch 6/8] init: rename CONFIG_EMBEDDED to CONFIG_EXPERT
CONFIG_EMBEDDED has been renamed to CONFIG_EXPERT, so fix it in the net/
directory.
Signed-off-by: David Rientjes <rientjes@google.com>
---
net/mac80211/Kconfig | 6 +++---
net/rfkill/Kconfig | 4 ++--
net/wireless/Kconfig | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -19,7 +19,7 @@ config MAC80211_HAS_RC
def_bool n
config MAC80211_RC_PID
- bool ...
| Dec 29, 9:02 pm 2010 |
| David Rientjes | [patch 5/8] block: rename CONFIG_EMBEDDED to CONFIG_EXPERT
CONFIG_EMBEDDED has been renamed to CONFIG_EXPERT, so fix it in the
block/ directory.
Signed-off-by: David Rientjes <rientjes@google.com>
---
block/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/Kconfig b/block/Kconfig
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -2,7 +2,7 @@
# Block layer core configuration
#
menuconfig BLOCK
- bool "Enable the block layer" if EMBEDDED
+ bool "Enable the block layer" if EXPERT
default y
...
| Dec 29, 9:02 pm 2010 |
| David Rientjes | [patch 8/8] usr: rename CONFIG_EMBEDDED to CONFIG_EXPERT
CONFIG_EMBEDDED has been renamed to CONFIG_EXPERT, so fix it in the usr/
directory.
Signed-off-by: David Rientjes <rientjes@google.com>
---
usr/Kconfig | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/usr/Kconfig b/usr/Kconfig
--- a/usr/Kconfig
+++ b/usr/Kconfig
@@ -46,7 +46,7 @@ config INITRAMFS_ROOT_GID
If you are not sure, leave it set to "0".
config RD_GZIP
- bool "Support initial ramdisks compressed using gzip" if EMBEDDED
+ bool ...
| Dec 29, 9:02 pm 2010 |
| David Rientjes | [patch 4/8] fs: rename CONFIG_EMBEDDED to CONFIG_EXPERT
CONFIG_EMBEDDED has been renamed to CONFIG_EXPERT, so fix it in the fs/
directory.
Signed-off-by: David Rientjes <rientjes@google.com>
---
fs/Kconfig | 2 +-
fs/proc/Kconfig | 6 +++---
fs/sysfs/Kconfig | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/Kconfig b/fs/Kconfig
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -51,7 +51,7 @@ config EXPORTFS
tristate
config FILE_LOCKING
- bool "Enable POSIX file locking API" if EMBEDDED
+ bool "Enable POSIX ...
| Dec 29, 9:02 pm 2010 |
| Robin Holt | Re: [patch 1/8] init: rename CONFIG_EMBEDDED to CONFIG_EXPERT
Doesn't this patch series break the 'bisectable' rule for patches?
I think you can get by with adding a CONFIG_EXPERT selects CONFIG_EMBEDDED
in the first patch and the last patch removing that same selects.
Robin
--
| Dec 30, 5:45 am 2010 |
| Valdis.Kletnieks | Re: [patch 1/8] init: rename CONFIG_EMBEDDED to CONFIG_EXPERT
What's the plan for those people who are currently on (say) 2.6.35, next
upgrade to 2.6.39 or .40, and thus miss the 9th temporary patch? They'll run
'make oldconfig' - if they get prompted, do we want to add a line to the help
text that says "This used to be called EMBEDDED"?
| Dec 30, 2:56 pm 2010 |
| Jeff Chua | Re: Linux 2.6.37-rc8 (no fb)
On Thu, Dec 30, 2010 at 4:16 AM, Jesse Barnes <jbarnes@virtuousgeek.org>
Jesse,
Yes, that worked for me. I improved on the patch a bit below.
Thanks,
Jeff
--- a/drivers/gpu/drm/i915/intel_bios.c 2010-12-29 13:35:57.000000000 +0800
+++ a/drivers/gpu/drm/i915/intel_bios.c 2010-12-30 10:18:39.000000000 +0800
@@ -262,7 +262,10 @@
if (general) {
dev_priv->int_tv_support = general->int_tv_support;
dev_priv->int_crt_support = ...
| Dec 29, 7:49 pm 2010 |
| Jesse Barnes | Re: Linux 2.6.37-rc8 (no fb)
On Thu, 30 Dec 2010 10:49:33 +0800 (SGT)
For some expressions, the ternary operator is more compact & readable.
For others (like this one imo) it doesn't really add anything, so I
prefer the if statement. In this case I think the if statement is more
readable since it communicates that we're overriding the default value
on certain generations (i.e. it's a standalone clause).
--
Jesse Barnes, Intel Open Source Technology Center
--
| Dec 30, 11:16 am 2010 |
| Chris Wilson | Re: Linux 2.6.37-rc8 (no fb)
This reveals another bug whereby we don't clear conflicting bits in
PCH_DREF_CONTROL set by the BIOS...
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
--
| Dec 30, 4:31 pm 2010 |
| Randy Dunlap | [PATCH -next] staging: se401 depends on USB
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix build errors by adding "depends on USB":
ERROR: "usb_register_driver" [drivers/staging/se401/se401.ko] undefined!
ERROR: "usb_alloc_urb" [drivers/staging/se401/se401.ko] undefined!
ERROR: "usb_submit_urb" [drivers/staging/se401/se401.ko] undefined!
ERROR: "usb_control_msg" [drivers/staging/se401/se401.ko] undefined!
ERROR: "usb_free_urb" [drivers/staging/se401/se401.ko] undefined!
ERROR: "usb_kill_urb" [drivers/staging/se401/se401.ko] ...
| Dec 30, 11:23 am 2010 |
| Stephen Rothwell | linux-next: Tree for December 30
Hi all,
Changes since 20101229:
The input tree still has its build failure for which I reverted a commit.
The tty tree still has its build failure for which I reverted a commit.
----------------------------------------------------------------------------
I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
(patches at http://www.kernel.org/pub/linux/kernel/v2.6/next/ ). If you
are tracking the linux-next tree using git, you should ...
| Dec 29, 6:58 pm 2010 |
| Randy Dunlap | [PATCH -next] staging: usbvideo/vicam depends on USB
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix build errors by adding "depends on USB":
ERROR: "usb_register_driver" [drivers/staging/usbvideo/vicam.ko] undefined!
ERROR: "usb_bulk_msg" [drivers/staging/usbvideo/vicam.ko] undefined!
ERROR: "usb_control_msg" [drivers/staging/usbvideo/vicam.ko] undefined!
ERROR: "usb_deregister" [drivers/staging/usbvideo/vicam.ko] undefined!
ERROR: "usb_get_dev" [drivers/staging/usbvideo/usbvideo.ko] undefined!
ERROR: "usb_put_dev" ...
| Dec 30, 11:23 am 2010 |
| Grant Likely | [git pull] one more spi bugfix for 2.6.37
Hi Linus,
Here is one more spi bug fix for .37
The following changes since commit 387c31c7e5c9805b0aef8833d1731a5fe7bdea14:
Linux 2.6.37-rc8 (2010-12-28 17:05:48 -0800)
are available in the git repository at:
git://git.secretlab.ca/git/linux-2.6 merge-spi
Gregory CLEMENT (1):
spi/omap2_mcspi.c: Force CS to be in inactive state after
off-mode transition
drivers/spi/omap2_mcspi.c | 39 +++++++++++++++++++++++++++++++++++++++
1 files changed, 39 insertions(+), 0 ...
| Dec 29, 6:45 pm 2010 |
| Grant Likely | Re: [git pull] one more spi bugfix for 2.6.37
Oops, missed one. Here's an updated pull req.
The following changes since commit 387c31c7e5c9805b0aef8833d1731a5fe7bdea14:
Linux 2.6.37-rc8 (2010-12-28 17:05:48 -0800)
are available in the git repository at:
git://git.secretlab.ca/git/linux-2.6 merge-spi
Gregory CLEMENT (1):
spi/omap2_mcspi.c: Force CS to be in inactive state after
off-mode transition
Jate Sujjavanich (1):
spi/m68knommu: Coldfire QSPI platform support
drivers/spi/coldfire_qspi.c | 2 +-
...
| Dec 30, 12:59 am 2010 |
| Stephen Rothwell | linux-next: manual merge of the alacrity tree with the tree
Hi Gregory,
Today's linux-next merge of the alacrity tree got a conflict in
include/linux/Kbuild between various commits from various trees and
various commits from the alacrity tree.
I fixed it up (again - see below). I must ask, though, since the commits
in the alacrity tree have been there since May, is there is any progress
towards getting them integrated into Llinus' tree?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --cc include/linux/Kbuild
index ...
| Dec 29, 5:43 pm 2010 |
| Gregory Haskins | Re: linux-next: manual merge of the alacrity tree with t ...
Hi Stephen,
Sorry about all that. I haven't had a chance to play with that code base for a while and the requisite demand Linus was looking for hasn't been very vocal. I'd say just drop my tree for now if its a nuisance, and I will re-post it to you once I have a chance to give it some love.
Thanks,
| Dec 29, 6:22 pm 2010 |
| Andrew Morton | Re: [PATCH] taskstats: Use better ifdef for alignment
That seems a very good reason to not apply the patch.
--
| Dec 29, 5:14 pm 2010 |
| Jeff Mahoney | [PATCH] taskstats: Use better ifdef for alignment
Commit 4be2c95d added a null field to align the taskstats structure but
the discussion centered around ia64. The issue exists on other platforms
with inefficient unaligned access and adding them piecemeal would be
an unmaintainable mess.
This patch uses Dave Miller's suggestion of using a combination of
CONFIG_64BIT && !CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS to determine
whether alignment is needed.
Note that this will cause breakage on those platforms with applications
like iotop ...
| Dec 29, 5:12 pm 2010 |
| Jeff Mahoney | Re: [PATCH] taskstats: Use better ifdef for alignment
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I don't want to rehash the same discussion, but any argument that
applied to ia64 applies any other 64-bit arch other than powerpc and x86_64.
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/
iEYEARECAAYFAk0cGAoACgkQLPWxlyuTD7IdTwCfXZ0KfZ3N/zafSzGCSa4cHEbN
EU8AoI/JK/1nkv5xHw4XP79wZAGo4hqk
=jAGp
-----END PGP SIGNATURE-----
--
| Dec 29, 10:26 pm 2010 |
| Andrew Morton | Re: [PATCH] taskstats: Use better ifdef for alignment
Please do so. That discussion went on for a long time over many emails
and multiple iterations of the patch. I personally have forgotten the
reasoning and if I could remember it, I wouldn't remember which version
of the patch it applied to.
Applying a patch which is *known* to break *known* userspace
applications is a quite extraordinary thing to do. We owe it to people
to fully explain the reasoning.
--
| Dec 29, 10:32 pm 2010 |
| Jeff Mahoney | Re: [PATCH] taskstats: Use better ifdef for alignment
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Ok, so the gist is that iotop makes what I'd call unreasonable
assumptions about the contents of a netlink genetlink packet containing
generic attributes. They're typed and have headers that specify value
lengths, so the client can (should) identify and skip the ones the
client doesn't understand.
The kernel, as of version 2.6.36, presented a packet like so:
+--------------------------------+
| genlmsghdr - 4 bytes ...
| Dec 30, 8:52 am 2010 |
| Fabio Comolli | Re: [Bug #24772] Crash with btrfs rootfs on dm-crypt [ k ...
Hi Rafael.
I don't have linux on that laptop anymore.
Regards,
Fabio
--
| Dec 30, 12:58 am 2010 |
| Rafael J. Wysocki | Re: [Bug #24772] Crash with btrfs rootfs on dm-crypt [ k ...
OK, so I'm closing the bug as unreproducible.
Thanks,
--
| Dec 30, 3:51 am 2010 |
| Krzysztof Halasa | Re: [Bug #25442] ixp4xx defines FREQ macro; conflicts wi ...
This FREQ has been there for years. Not that it makes it smart, and
I'll obviously send Ben's patch upstream for 2.6.38. Still processing
incoming mail queue :-(
--
Krzysztof Halasa
--
| Dec 30, 6:13 am 2010 |
| Rafael J. Wysocki | Re: [Bug #25442] ixp4xx defines FREQ macro; conflicts wi ...
Well, the patch is in the mainline, which is why it's still listed.
Thanks,
Rafael
--
| Dec 30, 7:45 am 2010 |
| carlos palma | Re: [Bug #25402] kernel (2.6.37-8-generic_amd64) panic o ...
I can confirm that this "regression" still exists with the kernel
2.6.37-rc8.
The Call Trace is basically the same:
...
Kernel panic - not syncing: map_single ...
Pid 935, comm: NetworkManager Tainted
call trace
panic+oxbf/0x200
? default_spin_lock_flags+0x9/0x10
?swiotlb_tlb_map_single+0x1ce/0x250
?map_single+0x46/0x60
swiotlb_map_page+0xa6/0xf
... and then the FREEZE ... only a hard reset brings to live (with
2.6.36-2) Linux.
carlos.
--
| Dec 30, 2:33 pm 2010 |
| Rafael J. Wysocki | Re: [Bug #25402] kernel (2.6.37-8-generic_amd64) panic o ...
Thanks for the info.
Why did you put "regression" into double quotes?
Rafael
--
| Dec 30, 3:51 pm 2010 |
| Mikael Pettersson | Re: [Bug #23902] [BUG] 2.6.37-rc3 massive interactivity ...
Fixed in 2.6.37-rc7.
--
| Dec 30, 4:46 am 2010 |
| Rafael J. Wysocki | Re: [Bug #23902] [BUG] 2.6.37-rc3 massive interactivity ...
Do you know which commit fixed it?
Rafael
--
| Dec 30, 7:47 am 2010 |
| Rafael J. Wysocki | Re: [Bug #22672] Regression in 2.6.37-rc1 for Intel 945 ...
Thanks for the update.
Rafael
--
| Dec 30, 3:57 am 2010 |
| Larry Finger | Re: [Bug #22672] Regression in 2.6.37-rc1 for Intel 945 ...
Neither 2.6.37-rc8 nor the patches listed above fix my system.
Larry
--
| Dec 29, 5:32 pm 2010 |
| Rafael J. Wysocki | Re: [Bug #22672] Regression in 2.6.37-rc1 for Intel 945 ...
Does reverting commit 448f53a "drm/i915/bios: Reverse order of 100/120 Mhz SSC
clocks" help?
Rafael
--
| Dec 30, 4:00 am 2010 |
| Benjamin Herrenschmidt | Re: PowerPC BUG: using smp_processor_id() in preemptible code
Yes, we assume that the PTE lock is always held when modifying page
Well, it looks like our kernel mappings tend to take some nasty
shortcuts with the PTE locking, which I suppose are legit but do break
some of my assumptions there. I need to have a closer look. Thanks for
the report !
Cheers,
--
| Dec 30, 3:45 am 2010 |
| Jeremy Fitzhardinge | Re: PowerPC BUG: using smp_processor_id() in preemptible code
Yes. I was bit worried by the interaction between vb->lock and the pte
locks, and thought it safer to keep it outside. Though I suppose kernel
Since kernel mappings don't have a formal pte lock to rely on for
synchronization, each subsystem defines its own ad-hoc one. In this
case that's probably vb->lock anyway, so the fix is to move
That looks OK, but it interferes with my plans to use
apply_to_page_range(_batch) to replace all this code.
J
--
| Dec 29, 6:26 pm 2010 |
| Yong Zhang | Re: Question about in_interrupt() semantics with regard ...
For the function you want, you can take a look at commit:
75e1056f5c57050415b64cb761a3acc35d91f013
Thanks,
Yong
--
Only stand for myself
--
| Dec 29, 7:15 pm 2010 |
| Shubhrajyoti Datta | Dec 29, 11:04 pm 2010 | |
| Daniel Kiper | Re: [PATCH R2 5/7] xen/balloon: Protect before CPU exhau ...
Hi,
I forgot to move it to separate patch. When I was working
on protection before CPU exhaust I discovered that
HYPERVISOR_memory_op() returns int and rc could be
declared as int not as long.
Daniel
--
| Dec 30, 3:02 pm 2010 |
| Konrad Rzeszutek Wilk | Re: [PATCH R2 5/7] xen/balloon: Protect before CPU exhau ...
How come? Is it just a cleanup?
--
| Dec 30, 9:26 am 2010 |
| Daniel Kiper | Re: [PATCH R2 1/7] mm: Add add_registered_memory() to me ...
Hi,
Thx, next patch will be based on latest rc.
Daniel
--
| Dec 30, 3:04 pm 2010 |
| David Rientjes | Re: [PATCH R2 1/7] mm: Add add_registered_memory() to me ...
I'd suggest posting patches against the latest -git.
--
| Dec 30, 11:49 am 2010 |
| David Rientjes | Re: [PATCH R2 1/7] mm: Add add_registered_memory() to me ...
Looks like this patch was based on a kernel before 2.6.37-rc4 since it
Lots of unnecessary empty lines here, and scripts/checkpatch.pl says there
are trailing whitespaces as well.
--
| Dec 29, 5:50 pm 2010 |
| Daniel Kiper | Re: [PATCH R2 1/7] mm: Add add_registered_memory() to me ...
Hi,
As I wrote in "[PATCH R2 0/7] Xen memory balloon driver with memoryhotplug
Strange. I tested it with this script and I received:
0001-mm-Add-add_registered_memory-to-memory-hotplug-API.txt has no
obvious style problems and is ready for submission.
I do not know why my e-mail was mangled. For your convenience
I am sending this patch as attachment.
Empty lines are added for better readability (it is my
opinion) however, I do not insist to leave this patch
with that ...
| Dec 30, 5:30 am 2010 |
| Arnd Bergmann | Re: (arm-)global platform device registration functions
Adding platform devices dynamically is definitely the right way forward
for new platforms, as Greg explained recently. The imx_add_platform_device()
function you have defined looks useful for this, and I guess it could
be added globally, next to the existing platform_device_register_resndata,
platform_device_register_data and platform_device_register_simple functions
that we already have doing similar things.
I'm not convinced that the various wrappers you have on imx are the
best solution, ...
| Dec 30, 3:03 am 2010 |
| Uwe Kleine-König | Re: (arm-)global platform device registration functions
Hello Arnd,
imx_add_platform_device could be implemented as
platform_device_register_resndata(NULL, name, id, res, num_resources, data, size_data)
I came up with those because many machines (sharing the same SoC) share
Well this is a matter of taste, I'm quite happy with the current
approach.
[1]
http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=blob;f=arch/arm/plat-mx...
--
Pengutronix e.K. | ...
| Dec 30, 3:15 am 2010 |
| Ingo Molnar | Re: [GIT PULL] oprofile fixes for v2.6.37
Ok, but in that case the prempt_disable()/enable() should be put into init_ibs(),
not be open-coded at the caller like that.
The comment about its cpu-localness could move to init_ibs() as well.
Thanks,
Ingo
--
| Dec 30, 10:38 am 2010 |
| Robert Richter | Re: [GIT PULL] oprofile fixes for v2.6.37
It is correct to run init_ibs() only on one cpu. It only checks the
ibs capabilities and sets up pci devices (if necessary). It runs only
on one cpu but operates with the local APIC and some MSRs, thus it is
better to disable preemption.
The cpu setup itself runs in op_amd_setup_ctrs() which is per cpu.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
--
| Dec 30, 6:08 am 2010 |
| Rob Landley | Re: [PATCH v2 00/12] make rpc_pipefs be mountable multip ...
It's the "we are in init's mount namespace" that I was wondering about.
So if I naievely chroot, nfs mount stops working the way it did before I
chrooted unless I do an extra setup step?
I'm actually poking at getting nfs mount working in LXC containers with
different network routing (mostly study so far, it took me a couple
weeks just to get lxc to work for me and now I'm trying to wrap my head
around Linux's NFS implementation), so I'm very interested in this...
Rob
--
| Dec 30, 2:10 am 2010 |
| Kirill A. Shutemov | Re: [PATCH v2 00/12] make rpc_pipefs be mountable multip ...
No. It will work as before since you are still in init's mount namespace.
--
Kirill A. Shutemov
--
| Dec 30, 2:44 am 2010 |
| Rob Landley | Re: [PATCH v2 00/12] make rpc_pipefs be mountable multip ...
What would a test case for this look like? (Is there some way to tell
an nfs mount to use a specific instance of rpc_pipefs or something?)
Rob
--
| Dec 29, 7:13 pm 2010 |
| Kirill A. Shutemov | Re: [PATCH v2 00/12] make rpc_pipefs be mountable multip ...
You can create a new instance of rpc_pipefs using 'newinstance'
mountoption.
Then you can specify which rpc_pipefs to use with 'rpcmount' mountoption
of nfs mount. If none specifed, '/var/lib/nfs/rpc_pipefs' uses by default.
If no rpcmount mountoption, no rpc_pipefs was found at
'/var/lib/nfs/rpc_pipefs' and we are in init's mount namespace, we use
init_rpc_pipefs.
--
Kirill A. Shutemov
--
| Dec 30, 1:51 am 2010 |
| Kirill A. Shutemov | Re: [PATCH v2 00/12] make rpc_pipefs be mountable multip ...
It's no so obvious for me why we should restrict it. ;)
Currently, there is no association between rpc_pipefs and mount namespace,
so I don't see simple way to restrict number of rpc_pipefs per mount
namespace. Associating mount namespace with rpc_pipefs is not a good idea,
I think.
--
Kirill A. Shutemov
--
| Dec 30, 4:45 am 2010 |
| Rob Landley | Re: [PATCH v2 00/12] make rpc_pipefs be mountable multip ...
I was pointing out it's been done before.
I'd prefer autodetecting it so new namespaces and the base namespace
don't have magic policy _or_ require different mount invocations. An
ability to change the default for a value is less appealing than not
needing the value in the first place.
And changing the default would probably have to be per-container anyway
to be useful. (Which isn't _quite_ the same as per-namespace since you
can chroot without CLONE_NEWNS.)
(I keep thinking back ...
| Dec 30, 5:52 am 2010 |
| Kirill A. Shutemov | Re: [PATCH v2 00/12] make rpc_pipefs be mountable multip ...
Yep. It's bad, but there is way to overwrite the default.
Other way is to leave 'rpcmount' mountoption without default.
get_rpc_pipefs(NULL) in init's mount namespace will always return
init_rpc_pipefs, without filesystem lookup.
get_rpc_pipefs(NULL) in non-init's mount namespace will always return
error.
So you will have to specify 'rpcmount' mountoption for every nfs mount in
container. Hmm, I guess, it may confuse user.
What should we do if we have several rpc_pipefs mounts in the ...
| Dec 30, 3:44 am 2010 |
| Rob Landley | Re: [PATCH v2 00/12] make rpc_pipefs be mountable multip ...
/proc/sys/kernel/hotplug exists to tell the kernel where to find the hotplug
binary. Once upon a time /sys/hotplug was the default value, and that was
there to overwrite it. (They changed the default to blank (disabled) not due
to policy reasons, but due to adding the netlink hotplug notification
mechanism and making that the default.)
I bring that up to point out that the general consensus about policy in the
kernel seems to be "when you really really can't avoid having any, make a
sane ...
| Dec 30, 4:05 am 2010 |
| Gurudas Pai | Re: [BUG] kernel BUG at mm/truncate.c:479! on 2.6.37-rc8
Issue fixed with the patch, Thanks :)
So I did some additional testing with different fio jobfiles to run
tests on nfs, and we got panic, this is not introduced by your patch,
since this happens even without it. Should I start a different mail
thread for this ?
------------[ cut here ]------------
kernel BUG at fs/aio.c:554!
invalid opcode: 0000 [#2] SMP
last sysfs file: /sys/devices/system/cpu/cpu3/cache/index2/shared_cpu_map
CPU 1
Modules linked in: nls_utf8 netconsole configfs ...
| Dec 30, 12:02 am 2010 |
| Baruch Siach | Re: [uClinux-dev] Re: dm9000 patch
Hi Angelo,
Just send the patch to the netdev mailing list. For additional instructions
see Documentation/SubmitChecklist and Documentation/SubmittingPatches. Once
you submitted you patch you can track the status of your patch at
http://patchwork.ozlabs.org/project/netdev/list/.
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: ...
| Dec 30, 8:12 am 2010 |
| Greg Ungerer | Re: [uClinux-dev] Re: dm9000 patch
Hi Angelo,
How is the DM9000 hardware connected to the 5307?
I am wondering how you connected the interrupt (and to
which interrupt) and the addressing (direct of a chip select)?
(For example NETtel based 5307 platform support of the SMC91x code is
in mainline as arch/m68knommu/platform/5307/nettel.c). Can you show
the code you used to setup your dm9000 hardware?
(Specifically I guess I want to know if you use the "auto-vectored"
interrupt mode?)
Thanks
-- ...
| Dec 29, 5:37 pm 2010 |
| Angelo Dureghello | Re: [uClinux-dev] Re: dm9000 patch
Hi all,
Joe,
about the debug line inside dm9000_interrupt,
//dm9000_dbg(db, 3, "entering %s\n", __func__);
nothing change, first browsing attempt crashed the board with the same
call stack trace:
[ 4.660000] eth0: link up, 100Mbps, full-duplex, lpa 0x45E1
[ 54.340000] BUG: spinlock recursion on CPU#0, swapper/0
[ 54.340000] lock: 00191244, .magic: dead4ead, .owner: swapper/0,
.owner_cpu: 0
[ 54.340000] Stack from 001a1b44:
[ 54.340000] 001a1b70 000ad968 ...
| Dec 30, 2:59 am 2010 |
| Greg Ungerer | Re: [uClinux-dev] Re: dm9000 patch
Hi Anelo,
On 30/12/10 19:59, Angelo Dureghello wrote:
Yes, IRQ7 is "special" on the 5307. It is non-maskable. So normal
Yes, I suggest you try using another IRQ line. Stay away from IRQ7
for any normal devices.
Regards
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close, ...
| Dec 30, 4:17 am 2010 |
| Angelo Dureghello | Re: [uClinux-dev] Re: dm9000 patch
Hi Greg and All,
infinite thanks, i solved finally my issue and the board is fully working.
I used IRQ7 line, casually, and unfortunately it was wrong.
IRQ7 is a special autovectored interrupt, in particular, it is an EDGE
interrupt, and not a LEVEL interrupt like IRQ1 to 6.
I used IRQ1 now, a normal level interrupt, and everything works perfect.
So i have dm9000 and MCF5307 (big-endian cpu) fully working with 32 bit
bus straight wired D0:31 to the dm9000, and would like to share my patch ...
| Dec 30, 8:05 am 2010 |
| Shan Wei | Re: linux-next: Tree for December 29 (netfilter build errors)
CONFIG_NF_DEFRAG_IPV6 depends on CONFIG_NF_CONNTRACK_IPV6 which depends on CONFIG_NF_CONNTRACK.
In you config file, CONFIG_NF_CONNTRACK_IPV6 and CONFIG_NF_CONNTRACK are not set,
but CONFIG_NF_DEFRAG_IPV6 is set with 'y'. This is same with IPv4.
Selecting CONFIG_NF_CONNTRACK and CONFIG_NF_CONNTRACK_IPV6 may help to you.
--
Best Regards
-----
Shan Wei
--
| Dec 29, 7:10 pm 2010 |
| Changli Gao | Re: linux-next: Tree for December 29 (netfilter build errors)
This bug has been already fixed in nf-next-2.6:
http://git.kernel.org/?p=linux/kernel/git/kaber/nf-next-2.6.git;a=commitdiff;h=ae90bde...
Thanks.
--
Regards,
Changli Gao(xiaosuo@gmail.com)
--
| Dec 29, 7:18 pm 2010 |
| Sedat Dilek | Re: linux-next: Tree for December 29 (netfilter build errors)
Does not look like the nf-next-2.6 is triggered by linux-next... Does
this tree passes net-next-2.6 and then enters linux-next?
- Sedat -
P.S.:
sd@tbox:/mnt/sdb5/linux-kernel/linux-next$ git pull
git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-next-2.6.git
master:nf-next-2.6
remote: Counting objects: 705, done.
remote: Compressing objects: 100% (415/415), done.
remote: Total 545 (delta 475), reused 149 (delta 130)
Receiving objects: 100% (545/545), 88.80 KiB | 47 KiB/s, ...
| Dec 30, 9:47 am 2010 |
| Eric Dumazet | Re: linux-next: Tree for December 29 (netfilter build errors)
Yes it does. Patrick is probably too busy right now to push fixes to
David.
--
| Dec 30, 10:07 am 2010 |
| Geert Uytterhoeven | Re: linux-next: build failure after merge of the final t ...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
| Dec 30, 12:58 pm 2010 |
| Ping Cheng | Re: linux-next: build failure after merge of the final t ...
On Thu, Dec 30, 2010 at 11:58 AM, Geert Uytterhoeven
You are right. Take it as a typo or copy/paste error ;).
Ping
--
| Dec 30, 1:10 pm 2010 |
| Ping Cheng | Re: linux-next: build failure after merge of the final t ...
I do not see the error on my testing systems somehow. Does adding the
following line resolve the issue?
#include < include/linux/delay.h>
--
| Dec 30, 11:06 am 2010 |
| Alex Riesen | Re: Linux 2.6.37-rc8 (no fb)
Never mind. I'm lazy (that's not to say someone is too).
I redid the test:
Before running "xset dpms force standby":
http://vin-soft.org/~raa/public/test/intel_reg_dumper-before
After running "sleep 3"
http://vin-soft.org/~raa/public/test/intel_reg_dumper-suspend
After running "xset dpms force on; sleep 3"
http://vin-soft.org/~raa/public/test/intel_reg_dumper-xset-on
After closing and opening the lid (displays backlight is back)
...
| Dec 29, 5:10 pm 2010 |
| Zhang Rui | Re: Linux 2.6.37-rc8
Right.
After discussion with Len, we agreed that the real problem is that we
should not probe/unprobe power_supply class device in
acpi_battery_update.
And we also agreed on reverting that commit for now, and rewriting the
battery driver, sometime in Q1 2011, with the problem fixed.
Sorry that I didn't update this in the mailing list.
thanks,
--
| Dec 29, 6:17 pm 2010 |
| Chris Wilson | Re: Linux 2.6.37-rc8 (no fb)
It appeared to be the easiest fix for the machines I had to hand and was
confirmed by several people with identical machines. However, it
definitely caused a regression for working panels and therefore it will
be reverted.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
--
| Dec 30, 11:36 am 2010 |
| Jesse Barnes | Re: Linux 2.6.37-rc8 (no fb)
On Thu, 30 Dec 2010 00:35:15 +0100
That's the easiest way; I think there are existing packages available
as well, but you may have to check Karmic or newer.
--
Jesse Barnes, Intel Open Source Technology Center
--
| Dec 29, 5:02 pm 2010 |
| Mario 'BitKoenig' Holbe | Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register()
CONFIG_B43=m
CONFIG_B43_PCI_AUTOSELECT=y
CONFIG_B43_PCICORE_AUTOSELECT=y
CONFIG_B43_PCMCIA=y
CONFIG_B43_SDIO=y
CONFIG_B43_PIO=y
CONFIG_B43_PHY_LP=y
CONFIG_B43_LEDS=y
CONFIG_B43_HWRNG=y
# CONFIG_B43_DEBUG is not set
CONFIG_B43LEGACY=m
CONFIG_B43LEGACY_PCI_AUTOSELECT=y
CONFIG_B43LEGACY_PCICORE_AUTOSELECT=y
CONFIG_B43LEGACY_LEDS=y
CONFIG_B43LEGACY_HWRNG=y
CONFIG_B43LEGACY_DEBUG=y
CONFIG_B43LEGACY_DMA=y
CONFIG_B43LEGACY_PIO=y
CONFIG_B43LEGACY_DMA_AND_PIO_MODE=y
# ...
| Dec 29, 6:20 pm 2010 |
| Mario 'BitKoenig' Holbe | Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register()
All right, 3 dmesg excerpts attached...
2.6.37-rc7-vanilla.dmesg:
2.6.37-rc7 vanilla (i.e. with 84c164a34ffe67908a), crashing
via-rng is registered first, b43-rng second
2.6.37-rc7-without.dmesg:
2.6.37-rc7 with 84c164a34ffe67908a reverted, not crashing
b43-rng is registered first, via-rng second
2.6.37-rc7-without+modprobe.dmesg:
2.6.37-rc7 with 84c164a34ffe67908a reverted, b43 blacklisted and
manually modprobed after via-rng, crashing
via-rng is registered first, b43-rng ...
| Dec 30, 1:45 pm 2010 |
| Larry Finger | Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register()
Thanks for finding the problem. Obviously, I did not go back far enough in the
record to find the commit that you implicate.
Please show the output of "egrep "B43|RNG|RANDOM" .config".
It should not matter, but please try the attached patch.
Larry
| Dec 29, 5:30 pm 2010 |
| Larry Finger | Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register()
No, don't bother. I do have a different request. The byte counts for my 32-bit
system do not match yours. Could you please use the following command to find
the instructions that are failing?
objdump -l -d drivers/char/hw_random/core.o | less
Use the search to find the start of hwrng_register, then add 0x4c to the
starting address. Once I see hte instruction that is failing, I should be able
to find where the failure occurs.
The order in which things are registered should not cause an ...
| Dec 29, 7:37 pm 2010 |
| Mario 'BitKoenig' Holbe | Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register()
I believe I can confirm the bug does not directly belong to b43:
I created a second via-rng driver (just copied via-rng.c to via-rng2.c
and changed the via_rng.name) and modprobed it. I blacklisted b43 to
keep it out of the game.
Virtually the same crash dump as with b43 shows up when I modprobe
via-rng2 after via-rng is loaded already.
Attached is a dmesg excerpt from a 2.6.37-rc7 kernel built with Larrys
hwrng_debug patch applied (which basically calls dump_stack() ...
| Dec 30, 4:17 pm 2010 |
| Mario 'BitKoenig' Holbe | Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register()
Alright, here we go...
[ 30.012695] BUG: unable to handle kernel paging request at 4b28f458
[ 30.012708] IP: [<f90703cc>] hwrng_register+0x4c/0x139 [rng_core]
00000380 <hwrng_register>:
hwrng_register():
/tmp/1/linux-source-2.6.37-rc7/drivers/char/hw_random/core.c:299
380: 56 push %esi
381: 53 push %ebx
...
/tmp/1/linux-source-2.6.37-rc7/drivers/char/hw_random/core.c:312
3c6: 8b 76 1c mov 0x1c(%esi),%esi
3c9: ...
| Dec 30, 7:34 am 2010 |
| Larry Finger | Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register()
The head of the rng_list is damaged. It is initialized at compile time and
should be OK. To help discover the order in which hwrng_register() is called,
apply the attached patch. Run it once with commit 84c164a34ffe67908a installed,
and once with it reverted.
Thanks,
Larry
| Dec 30, 11:37 am 2010 |
| Larry Finger | Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register()
Added the two listed maintainers for hardware randon-number generators and
dropped the wireless and b43 lists.
Matt and Herbert:
There is a regression in 2.6.37-rcX relative to 2.6.36. The problem shows as the
following kernel BUG:
[ 30.313362] BUG: unable to handle kernel paging request at 60870667
[ 30.313372] IP: [<f8f4e3df>] hwrng_register+0x5f/0x14d [rng_core]
[ 30.313391] *pdpt = 0000000036c34001 *pde = 0000000000000000
[ 30.313403] Oops: 0000 [#1] SMP
[ 30.313411] last ...
| Dec 30, 3:49 pm 2010 |
| Mark Brown | Re: [RFC/PATCH 3/3] mfd: twl4030-irq: implement bus_*lock
Yes, that looks like what I'd expect.
--
| Dec 30, 5:18 am 2010 |
| Felipe Balbi | Re: [RFC/PATCH 3/3] mfd: twl4030-irq: implement bus_*lock
Good, I'll clean the patches up and wait past the merge window before
sending final versions.
--
balbi
--
| Dec 30, 5:26 am 2010 |
| David Rientjes | Re: [PATCH 15/16] x86: Unify node_to_cpumask_map handlin ...
There's nothing new about NUMA emulation on x86_64, it's existed for well
over four years (we've been using it at Google since 2.6.18, see
Documentation/x86/x86_64/fake-numa-for-cpusets). Shaohui's patches are
completely seperate and add hotplug emulation. You _could_ boot with a
very minimal amount of memory and then hotplug all the emulated nodes like
numa=fake does, but you may find it difficult to parse the e820 and
interleave the nodes appropriately over the set of physical nodes in ...
| Dec 30, 11:43 am 2010 |
| Tejun Heo | Re: [PATCH 15/16] x86: Unify node_to_cpumask_map handlin ...
Sigh, the new NUMA emulation thing is 64bit only. :-( I'll see if it
can be applied to 32bit too. BTW, how does this interact with the
Shaohui's patchset. Isn't that about NUMA emulation too? Are these
the same patches?
Thanks.
--
tejun
--
| Dec 30, 5:48 am 2010 |
| Tejun Heo | Re: [PATCH 13/16] x86: Unify cpu/apicid <-> NUMA node ma ...
Will rebase & repost soon.
Thanks.
--
tejun
--
| Dec 30, 4:33 am 2010 |
| David Rientjes | Re: [PATCH 15/16] x86: Unify node_to_cpumask_map handlin ...
Shaohui's patchset is for node hotplug emulation, not for NUMA emulation
And pxm mappings since node_distance() must reflect the physical topology
on the emulated environment. We have specialized callbacks in the amd and
ACPI code to ascertain the physical topology because its discovery is
handled differently, either with an implied set of possible nodes in the
amd case and the statically-allocated nodes_parsed in the ACPI case, prior
You could export an apicid-to-node and pxm-to-node ...
| Dec 30, 11:40 am 2010 |
| Tejun Heo | Re: [PATCH 15/16] x86: Unify node_to_cpumask_map handlin ...
Hello, again.
Okay, after going through the changes, here are some thoughts FWIW.
I'm doubtful the direction was the correct one. NUMA emulation,
almost by definition, doesn't vary too much depending on the
underlying hardware and how it's configured. All that's necessary is
the physical node map an apicid to nid mapping, which can and probably
should be represented in common form regardless of emulation and the
emulation code should simply manipulate the parsed information.
The ...
| Dec 30, 7:58 am 2010 |
| Takashi Iwai | Re: linux-next: build failure after merge of the sound-a ...
At Tue, 28 Dec 2010 02:17:48 +0000,
I pulled now. Let me know if it's still broken (maybe in the new year?)
thanks,
Takashi
--
| Dec 30, 5:24 am 2010 |
| Arnd Bergmann | Re: [PATCH v0] add nano semaphore in kernel
It should normally only wake up once, at exactly the time that the other
thread releases the mutex. What exactly happens depends on the relative
priorities of the two lock holders and whether all CPUs are busy already.
If there is nothing else to do and the blocking thread is made runnable
by giving up the mutex, it will run immediately. Even if we keep the
current thread running, the jiffie timer is rather meaningless and
Actually, the timeout is the time after which the waiter gives up ...
| Dec 30, 8:56 am 2010 |
| Hillf Danton | Re: [PATCH v0] add nano semaphore in kernel
Is it waked up less than jeffy?
If not, checking more frequently in the endless loop could help receive
signal, other than that is extremely meaningless, as the holder of
mutex is not ready to release.
As to timeout, it is another story, in which waiter is able to determine
how many jiffies or nanoseconds are acceptable if waiting is necessary.
Thanks
--
| Dec 30, 7:21 am 2010 |
| Arnd Bergmann | Re: [PATCH] spufs: use simple_write_to_buffer
Looks good to me.
Acked-by: Arnd Bergmann <arnd@arndb.de>
--
| Dec 30, 6:04 am 2010 |
| Geert Uytterhoeven | Re: Build regressions/improvements in v2.6.37-rc7
Sorry for giving you all this warm feeling inside. I screwed up and
used an incorrect
command line :-( So yes, we still have new build regressions...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus ...
| Dec 30, 12:40 pm 2010 |
| torbenh | Re: [PATCH resend] Reading POSIX CPU timer from outside ...
http://www.kernel.org/doc/man-pages/online/pages/man3/pthread_getcpuclockid.3.html
this one works.
ok... it takes a pthread_t for identifying the thread.
--
torben Hohn
--
| Dec 30, 10:45 am 2010 |
| Kukjin Kim | RE: linux-next: manual merge of the sound tree with the ...
Happy New year everyone :-)
Firstly, thanks for Russell and Mark.
Hmm...
I thought it's very simple, but it is not. Because needs some peoples'
another work :-(
Anyway, so I decided that will drop/change some commits which occur conflict
between sound tree and build error in my tree. Already discussed about that
with Jassi and he agreed.
Then if possible, will send remained small stuff to Linus during -rc.
Thank you so much again ;-)
Best regards,
Kgene.
--
Kukjin Kim ...
| Dec 29, 5:54 pm 2010 |
| Hugh Dickins | Re: [PATCH 0/7] Change page reference handling semantic ...
Acked-by: Hugh Dickins <hughd@google.com>
for all seven: thanks.
--
| Dec 29, 8:17 pm 2010 |
| Gao, Yunpeng | RE: [RFC] sdhci: use ios->clock to know when sdhci is idle
Thanks for the response. I just curious that is this the only reason to change the framework? To my understanding, seems it's not a very strong reason :-)
Take the example of sd/mmc card -
by using the aggressive clock gating framework, it means the host controller will gate (clock gating or power gating) itself if not receiving requests for 8 clocks even if the request queue of mmc block driver is not empty at that time. So the host controller has to be gated / ungated repeatedly until the ...
| Dec 30, 3:37 am 2010 |
| Tejun Heo | Re: [PATCH 1/3] x86: Use this_cpu_ops to optimize code
Hello,
Okay, applied these three. I suppose the same goes for the newer
patches? I'll ping you there.
Thanks.
--
tejun
--
| Dec 30, 4:23 am 2010 |
| David Rientjes | Re: [build failure] Re: [PATCH -v2 3/6] x86, 64bit, numa ...
Yeah, you reported this one earlier and I sent a patch four days ago to
fix it (http://marc.info/?l=linux-kernel&m=129340072128297). I'll reply
to this email with it again.
Thanks!
| Dec 30, 11:53 am 2010 |
| David Rientjes | Re: [PATCH -v2 3/6] x86, 64bit, numa: Put pgtable to loc ...
The two patches above from x86/numa that create the conflict should be
dependent only on 4e76f4e67a (x86, numa: Avoid compiling NUMA emulation
functions without CONFIG_NUMA_EMU), so cherry-pick them into x86/bootmem?
--
| Dec 29, 6:07 pm 2010 |
| Ingo Molnar | Re: [boot crash] Re: [PATCH -v2 3/6] x86, 64bit, numa: P ...
It's x86/bootmem, one of these commits:
3c417751e4f0: x86: Rename e820_table_* to pgt_buf_*
d7992231c148: x86-64: Move out cleanup higmap [_brk_end, _end) out of init_memory_mapping()
4645b6af9427: x86: Use early pre-allocated page table buffer top-down
1411e0ec3123: x86-64, numa: Put pgtable to local node memory
dbef7b56d2fc: x86-64, numa: Allocate memnodemap under max_pfn_mapped
45635ab5e41b: x86: Change get_max_mapped() to inline
1a4a678b12c8: memblock: Make find_memory_core_early() find ...
| Dec 30, 3:30 am 2010 |
| Ingo Molnar | [boot crash] Re: [PATCH -v2 3/6] x86, 64bit, numa: Put p ...
FYI, either the x86/numa or the x86/bootmem changes cause the early boot crash
below. Config attached.
Thanks,
Ingo
---------------->
Linux version 2.6.37-rc8-tip-01830-g7937b8c-dirty (mingo@sirius) (gcc version 4.5.1 20100924 (Red Hat 4.5.1-4) (GCC) ) #76886 SMP Thu Dec 30 12:12:49 CET 2010
BIOS-provided physical RAM map:
BIOS-e820: 0000000000000000 - 000000000009f800 (usable)
BIOS-e820: 000000000009f800 - 00000000000a0000 (reserved)
BIOS-e820: 00000000000f0000 - 0000000000100000 ...
| Dec 30, 3:28 am 2010 |
| Ingo Molnar | [build failure] Re: [PATCH -v2 3/6] x86, 64bit, numa: Pu ...
and x86/numa has this build failure:
arch/x86/mm/numa_64.c: In function ‘numa_set_cpumask’:
arch/x86/mm/numa_64.c:851:14: error: ‘physnodes’ undeclared (first use in this function)
arch/x86/mm/numa_64.c:851:14: note: each undeclared identifier is reported only once for each function it appears in
config attached.
Thanks,
Ingo
| Dec 30, 5:01 am 2010 |
| Yinghai Lu | Re: [PATCH -v2 3/6] x86, 64bit, numa: Put pgtable to loc ...
your new x86/numa have
setup_physnodes(addr, max_addr, acpi, amd);
fake_physnodes(acpi, amd, num_nodes);
instead of
acpi_fake_nodes(nodes, num_nodes);
in numa_emulation()
Thanks
Yinghai
--
| Dec 29, 5:11 pm 2010 |
| David Rientjes | Re: [PATCH -v2 3/6] x86, 64bit, numa: Put pgtable to loc ...
That's from f51bf3073a1 (x86, numa: Fake apicid and pxm mappings for NUMA
emulation) and c1c3443c9c (x86, numa: Fake node-to-cpumask for NUMA
emulation) in x86/numa. Given the subject line, I think your patchset is
targeted to the same branch so I'm not sure what's concerning?
| Dec 29, 5:39 pm 2010 |
| H. Peter Anvin | Re: [PATCH -v2 3/6] x86, 64bit, numa: Put pgtable to loc ...
That would hurt more, I think.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
--
| Dec 29, 6:53 pm 2010 |
| H. Peter Anvin | Re: [PATCH -v2 3/6] x86, 64bit, numa: Put pgtable to loc ...
No, it's part of a much bigger patchset which doesn't have anything to
do with NUMA. That's the problem.
In other words, I need a sane way to merge them and resolve the conflict.
-hpa
--
| Dec 29, 5:58 pm 2010 |
| Ingo Molnar | Re: [PATCH -v2 3/6] x86, 64bit, numa: Put pgtable to loc ...
x86/bootmem could be based on x86/numa - the latter is stable so it's not like we'll
have to undo it from under x86/bootmem. We can then send it to Linus once x86/numa
is upstream.
Btw., i suspect we want to use x86/memblock instead of x86/bootmem?
Thanks,
Ingo
--
| Dec 30, 2:06 am 2010 |
| David Rientjes | [patch] x86, numa: Fix CONFIG_DEBUG_PER_CPU_MAPS without ...
"x86, numa: Fake node-to-cpumask for NUMA emulation" broke the build when
CONFIG_DEBUG_PER_CPU_MAPS is set and CONFIG_NUMA_EMU is not. This is
because it is possible to map a cpu to multiple nodes when NUMA emulation
is used; the patch required a physical node address table to find those
nodes that was only available when CONFIG_NUMA_EMU was enabled.
This extracts the common debug functionality to its own function for
CONFIG_DEBUG_PER_CPU_MAPS and uses it regardless of whether
CONFIG_NUMA_EMU ...
| Dec 30, 11:54 am 2010 |
| Yinghai Lu | Re: [boot crash] Re: [PATCH -v2 3/6] x86, 64bit, numa: P ...
caused by
4645b6af9427: x86: Use early pre-allocated page table buffer top-down
32 bit fixmap will use the pre-allocated range too. it needs range to
be continuous...
please drop
4645b6af9427: x86: Use early pre-allocated page table buffer top-down
3c417751e4f0: x86: Rename e820_table_* to pgt_buf_*
and will send out new version of
x86: Rename e820_table_* to pgt_buf_*
Thanks
Yinghai
--
| Dec 30, 2:18 pm 2010 |
| Yinghai Lu | [PATCH -v2 6/6] x86: Rename e820_table_* to pgt_buf_*
Now it is found from memblock way.
Change the name to purpose related.
-v2: Ingo found "4/6 x86: Use early pre-allocated page table buffer top-down"
cause 32bit crash.
and need to drop it, So update this one accordingly.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/include/asm/init.h | 6 +++---
arch/x86/mm/init.c | 20 ++++++++++----------
arch/x86/mm/init_32.c | 8 ++++----
arch/x86/mm/init_64.c | 4 ++--
arch/x86/xen/mmu.c ...
| Dec 30, 2:54 pm 2010 |
| Grant Likely | Re: [PATCH 01/15] x86/e820: remove conditional early map ...
I assume this patch is a prereq for the rest of the series. Should I
merge it via the devicetree tree when I pick up the other patches?
It looks okay to me. One comment below, but not one that would prevent
picking up this patch.
if you add
+ map_len = data_len;
...this can be simplified to:
- early_iounmap(data, PAGE_SIZE);
--
| Dec 30, 1:37 am 2010 |
| Grant Likely | Re: [PATCH 13/15] x86/rtc: don't register rtc if we have ...
More generically, rather than searching for an rtc node, I imagine
simply the presence of a device tree blob means that the rtc
registration should be suppressed.
--
| Dec 30, 1:59 am 2010 |
| Grant Likely | Re: [PATCH 02/15] x86: Add device tree support
Mostly looks good. Some comments below.
0 means NO_IRQ on x86 and most architectures. I will change this when
Why is the physical address being passed in when the virtual address
--
| Dec 30, 1:43 am 2010 |
| Grant Likely | Re: [PATCH 03/15] x86/dtb: Add a device tree for CE4100
To-date the convention has been to use all lowercase in compatible
I'd like to say ditto here, but it might require a change to the
current kernel code. I believe ePAPR specified a compatible value
If you put an interrupt-parent property in the root node, then it will
become the default interrupt controller for the system which is
All these i2c bus controllers should have a compatible value so that
the OS knows what driver to bind to them.
Also, the node names for the i2c devices ...
| Dec 30, 1:51 am 2010 |
| Grant Likely | Re: [PATCH 12/15] of/address: use propper endianess in g ...
This one is already applied to my next-devicetree branch
--
| Dec 30, 2:05 am 2010 |
| Grant Likely | Dec 30, 1:54 am 2010 | |
| Grant Likely | Re: [PATCH 02/15] x86: Add device tree support
Hi Peter,
Since this series is based on the tip tree, these should be merged via
the same route. Aside from the comments below, I'm okay with patches
1 & 2 going in for 2.6.38 (assuming NO_IRQ is fixed). I've picked up
patch 12 since it is a generic fix. I haven't made a decision on the
remaining 14 yet.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
| Dec 30, 2:01 pm 2010 |
| Tejun Heo | Re: x86: Use this_cpu_has for thermal_interrupt
I suppose I should take the two x86 and the gameport patches here into
percpu tree with your ACKs too. Would that be okay with you?
Thanks.
--
tejun
--
| Dec 30, 4:29 am 2010 |
| H. Peter Anvin | Re: x86: Use this_cpu_has for thermal_interrupt
Yes, please.
Acked-by: H. Peter Anvin <hpa@zytor.com>
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
--
| Dec 30, 11:19 am 2010 |
| Hugh Dickins | Re: [PATCH] writeback: skip balance_dirty_pages() for in ...
Thanks a lot for investigating further and writing it all up here.
Acked-by: Hugh Dickins <hughd@google.com>
I notice bdi_cap_writeback_dirty go from bdi_writeout_fraction(), and
bdi_cap_account_dirty appear in balance_dirty_pages_ratelimited_nr():
maybe one day a patch to use just one flag throughout? Unless you can
dream up a use for the divergence. (I hate wasting brainpower trying to
decide which of two always-the-sames to use, like page_cache_release()
and put_page(), until there's ...
| Dec 29, 8:15 pm 2010 |
| Grant Likely | Re: [PATCH] of/fdt: add kernel command line option for d ...
It's in my -next branch now.
g.
--
| Dec 30, 2:32 pm 2010 |
| Grant Likely | Re: [PATCH] of/fdt: add kernel command line option for d ...
Not DOA, but I want to discuss the linking vs. wrapper issue again
before I commit to merging it. BTW, sorry for being MIA on this stuff
for pretty much all December. I got over committed, but things should
be better now.
g.
--
| Dec 30, 2:34 pm 2010 |
| David Daney | Re: [PATCH v3 0/5] MIPS/Perf-events: Sync with mainline ...
Entire set:
Acked-by: David Daney <ddaney@caviumnetworks.com>
I am basing my modifications for Octeon perf counters on this set.
David Daney
--
| Dec 30, 3:57 pm 2010 |
| Guennadi Liakhovetski | Re: [PATCH 2/3] mx3_camera: Support correctly the YUV222 ...
Ok, I'm dropping this patch
Alberto, I've applied and pushed your other 2 patches from this series,
but I've dropped this one. The reason is not (only), that you didn't reply
to my two last mails with update-requests. But because of that I took the
time today to look deeper into detail at this patch. And as a result, I
don't think it is correct.
Currently the mx3_camera driver transfers data from video clients (camera
sensors) only in one mode - as raw data, 1-to-1. This is extablished ...
| Dec 30, 12:38 pm 2010 |
| webmaster | Re: per-chroot clock module ?
Sorry for the delay in responding -
but I've been very busy, amongst other things working on the "per-chroot" module, which
now works in a very basic but sufficient mode.
If anyone else would find it useful, I'll fill it out some more and post it to this list.
I'd like to see this "subterfuge.net" - but I'm unable to connect with HTTP:
$ curl http://subterfuge.net --trace-ascii /dev/fd/2
== Info: About to connect() to subterfuge.net port 80 (#0)
== Info: Trying 184.82.15.90... == Info: ...
| Dec 30, 1:31 pm 2010 |
| Grant Likely | Re: [PATCH 02/11] x86: Add device tree support
Right, but in all of those cases a boot wrapper provides the same
functionality with better flexability, such as being able to provided
the dtb image(s) at install time instead of compile time.
g.
--
| Dec 30, 1:58 pm 2010 |
| Rob Landley | Re: [PATCH 02/11] x86: Add device tree support
There's no one embedded setup on any platform, but one of the few
constants of embedded development is trying to eliminate unnecessary
requirements.
Just on standard-ish PC hardware I've seen people try to stick Linux in the
BIOS flash (generally not enough room), I've seen people try to stick
it as the first stage PXE payload, there's the fun and games with
kexec of emergency kernels for crash dumps...
If the capability to skip an unnecessary bootloader was available, people
would use ...
| Dec 30, 1:45 am 2010 |
| Grant Likely | Re: [PATCH 02/11] x86: Add device tree support
/me gets ready to dodge tomatoes thrown at him.
Hmmm, back up a minute...
Since Linux on x86 has pretty much always depended on a two stage boot
(firmware boots a bootloader like grub which in turn boots the
kernel), then what is the use case for pursuing an in-kernel dtb
linkage? simpleimage was used on powerpc for the use-case where there
is no 2nd stage bootloader, but instead only the kernel which is
booted from some firmware that is non-upgradeable (or at least too
risky to upgrade). ...
| Dec 30, 1:26 am 2010 |
| Grant Likely | Re: [PATCH 02/11] x86: Add device tree support
Hmmm, I shouldn't be sending email at 1:30 in the morning. The above
statement is not really true. One of the use-cases on ARM is using a
device tree with existing firmware that doesn't pass a dt blob. Right
now there are two possible methods for doing this. Option one is to
link the .dtbs in the the kernel proper and point to them from the
machine struct. The dtb would be used when a matching machine id is
passed by the firmware. Option 2 is to select the correct .dtb with a
kernel boot ...
| Dec 30, 1:57 pm 2010 |
| Evgeniy Dushistov | Re: [PATCH 0/7] BKL removal follow-up
At now I am busy with my PhD thesis, but some time ago one person
connected to me and say that he would like work on this problem,
if I have no time.
So I wait patches from him, and if there are no such after a couple
of months, I do it myself.
--
/Evgeniy
--
| Dec 30, 8:16 am 2010 |
| Arnd Bergmann | Re: [PATCH 0/7] BKL removal follow-up
Right, that was rather obvious, thanks for taking a look!
Now that I have your attention, do you expect to be able to prepare
a proper patch for 2.6.38? I don't have any experience with this file
system, nor do I have useful ways of testing it, so that would be
appreciated. Nick already volunteered to test patches, but I guess it
would make more sense if you could do the patch.
Arnd
--
| Dec 30, 7:58 am 2010 |
| Ted Ts'o | Re: [PATCH 2/2] ext4: Add error check in ext4_mkdir()
Thanks, added to the ext4 patch tree.
- Ted
--
| Dec 30, 6:30 am 2010 |
| previous day | today | next day |
|---|---|---|
| December 29, 2010 | December 30, 2010 | December 31, 2010 |
