RE: [v3 1/3] 1/3 Touchscreen: Cypress TTSP G3 MTDEV Core Driver

Previous thread: [PATCH] olpc_battery: Ambient temperature is not available on XO-1.5 by Daniel Drake on Wednesday, December 29, 2010 - 12:12 pm. (1 message)

Next thread: [v3 3/3] 3/3 spi: Cypress TTSP G3 MTDEV SPI Device Driver by Kevin McNeely on Wednesday, December 29, 2010 - 12:17 pm. (1 message)
From: Kevin McNeely
Date: Wednesday, December 29, 2010 - 12:17 pm

Cypress TTSP Gen3 Core Driver.
Core Driver includes platform data definition file,
core driver definition file, and core touchscreen
touch handling of device data. Generates
multi-touch input events.

Signed-off-by: Kevin McNeely <kev@cypress.com>
---
Changes since v2:
- Simplified Protocol A
- Modified pointed out driver writing style

 drivers/input/touchscreen/Kconfig       |    5 +
 drivers/input/touchscreen/Makefile      |    1 +
 drivers/input/touchscreen/cyttsp_core.c |  808 +++++++++++++++++++++++++++++++
 drivers/input/touchscreen/cyttsp_core.h |   55 +++
 include/linux/input/cyttsp.h            |   68 +++
 5 files changed, 937 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/touchscreen/cyttsp_core.c
 create mode 100644 drivers/input/touchscreen/cyttsp_core.h
 create mode 100644 include/linux/input/cyttsp.h

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 06ea8da..7d886bc 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -124,6 +124,11 @@ config TOUCHSCREEN_CY8CTMG110
 	  To compile this driver as a module, choose M here: the
 	  module will be called cy8ctmg110_ts.
 
+config TOUCHSCREEN_CYTTSP_CORE
+	bool "Cypress TTSP touchscreen core"
+	help
+	  Always activated for Cypress TTSP touchscreen
+
 config TOUCHSCREEN_DA9034
 	tristate "Touchscreen support for Dialog Semiconductor DA9034"
 	depends on PMIC_DA903X
diff --git a/drivers/input/touchscreen/Makefile b/drivers/input/touchscreen/Makefile
index 7cc1b4f..b6f1ba8 100644
--- a/drivers/input/touchscreen/Makefile
+++ b/drivers/input/touchscreen/Makefile
@@ -16,6 +16,7 @@ obj-$(CONFIG_TOUCHSCREEN_ATMEL_TSADCC)	+= atmel_tsadcc.o
 obj-$(CONFIG_TOUCHSCREEN_BITSY)		+= h3600_ts_input.o
 obj-$(CONFIG_TOUCHSCREEN_BU21013)       += bu21013_ts.o
 obj-$(CONFIG_TOUCHSCREEN_CY8CTMG110)	+= cy8ctmg110_ts.o
+obj-$(CONFIG_TOUCHSCREEN_CYTTSP_CORE)   += cyttsp_core.o
 obj-$(CONFIG_TOUCHSCREEN_DA9034)	+= da9034-ts.o
 ...
From: Shubhrajyoti Datta
Date: Wednesday, December 29, 2010 - 11:04 pm

Hi Kevin,
--

From: Henrik Rydberg
Date: Friday, December 31, 2010 - 4:53 am

Hi Kevin,

Thanks for the changes, it looks much better now. Some comments on the MT

Tristate please.


Does not appear to be used anywhere.



If the CY_BL* values are only used here, how about putting the numbers here directly?











If the in-kernel tracking module was in place, would you consider switching to the slots protocol?

Thanks,
Henrik
--

From: Trilok Soni
Date: Friday, December 31, 2010 - 5:55 am

Hi Henrik,


This code is just exporting APIs and doesn't need to be modular. No module_init/exit etc.,

---Trilok Soni

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--

From: Henrik Rydberg
Date: Friday, December 31, 2010 - 6:58 am

Any particular reason why "grep cytt /proc/kallsyms | wc" should be
non-zero when no suitable hardware is available?

Henrik
--

From: Trilok Soni
Date: Monday, January 3, 2011 - 2:44 am

Hi Henrik,


Ok. Let's make it tristate then. Thanks.

---Trilok Soni


-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--

From: Kevin McNeely
Date: Monday, January 3, 2011 - 10:03 am

Hi Henrik,














Hi Henrik, can you please clarify?  Should I remove MTDEV from the patch
title?

Thanks and best regards,

---------------------------------------------------------------
This message and any attachments may contain Cypress (or its
subsidiaries) confidential information. If it has been received
in error, please advise the sender and immediately delete this
message.
---------------------------------------------------------------

--

From: Henrik Rydberg
Date: Monday, January 3, 2011 - 11:45 am

Let me start over - is there a way to reliably track contacts from the
device? If yes, the question is whether you would consider switching
to type B right away. If no, the question was whether you would
consider a switch to type B if there was a in-kernel tracking module
to use. I understand if there are other reasons to stay with type A, I
am mostly curious.

And perhaps MTDEV is a bit misplaced in the title, unless it has
something to do with the device.

Thanks,
Henrik
--

From: Kevin McNeely
Date: Monday, January 3, 2011 - 1:50 pm

Hi Henrik,

The market we are currently servicing requires Protocol A and we are
trying to meet those submission requirements in the near term.

With Protocol A available to the market, we will immediately work on a
Protocol B driver which will take advantage of track id information that
our device can provide.  For that effort, I would sincerely appreciate
information about testing (in-kernel tracking module?).

Thank you and best regards,

---------------------------------------------------------------
This message and any attachments may contain Cypress (or its
subsidiaries) confidential information. If it has been received
in error, please advise the sender and immediately delete this
message.
---------------------------------------------------------------

--

From: Hong Liu
Date: Monday, January 3, 2011 - 6:50 pm

On Thu, 2010-12-30 at 03:17 +0800, Kevin McNeely wrote:

ts->dev is not assigned yet.

Thanks,


--

Previous thread: [PATCH] olpc_battery: Ambient temperature is not available on XO-1.5 by Daniel Drake on Wednesday, December 29, 2010 - 12:12 pm. (1 message)

Next thread: [v3 3/3] 3/3 spi: Cypress TTSP G3 MTDEV SPI Device Driver by Kevin McNeely on Wednesday, December 29, 2010 - 12:17 pm. (1 message)