linux-next: build failure after merge of the final tree (input tree related)

Previous thread: Linux 2.6.37-rc8 by Linus Torvalds on Tuesday, December 28, 2010 - 6:18 pm. (27 messages)

Next thread: linux-next: Tree for December 29 by Stephen Rothwell on Tuesday, December 28, 2010 - 7:07 pm. (13 messages)
From: Stephen Rothwell
Date: Tuesday, December 28, 2010 - 6:51 pm

Hi Dmitry,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'

Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
wacom_w8001 - support pen or touch only devices").  See Rule 1 in
Documentation/SubmitChecklist.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Dmitry Torokhov
Date: Tuesday, December 28, 2010 - 7:34 pm

Thank you Stephen, I'll fix this up in my tree.

-- 
Dmitry
--

From: Stephen Rothwell
Date: Wednesday, December 29, 2010 - 4:51 pm

Hi Dmitry,


I note that this commit has been redone in your tree (as commit
11a862ed9f04558e222fa15a5fbd76698fed11ff) but there have been no changes
to it at all (except the commit date).

I have reverted that commit from today's linux-next.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Ping Cheng
Date: Thursday, December 30, 2010 - 11:06 am

I do not see the error on my testing systems somehow. Does adding the
following line resolve the issue?

#include < include/linux/delay.h>

--

From: Geert Uytterhoeven
Date: Thursday, December 30, 2010 - 12:58 pm

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--

From: Ping Cheng
Date: Thursday, December 30, 2010 - 1:10 pm

On Thu, Dec 30, 2010 at 11:58 AM, Geert Uytterhoeven

You are right. Take it as a typo or copy/paste error ;).

Ping
--

From: Dmitry Torokhov
Date: Sunday, January 2, 2011 - 1:05 am

Gah, I forgot to do 'git add' before doing 'git commit --amend', should
be better now.

-- 
Dmitry
--

Previous thread: Linux 2.6.37-rc8 by Linus Torvalds on Tuesday, December 28, 2010 - 6:18 pm. (27 messages)

Next thread: linux-next: Tree for December 29 by Stephen Rothwell on Tuesday, December 28, 2010 - 7:07 pm. (13 messages)