[PATCH 5/7] perf: Optimise topology iteration

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Lin Ming
Date: Monday, December 27, 2010 - 8:38 am

Currently we iterate the full machine looking for a matching core_id/nb
for the percore and the amd northbridge stuff , using a smaller topology
mask makes sense. 

Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---
 arch/x86/kernel/cpu/perf_event_amd.c   |    2 +-
 arch/x86/kernel/cpu/perf_event_intel.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/perf_event_amd.c b/arch/x86/kernel/cpu/perf_event_amd.c
index 67e2202..5a3b7b8 100644
--- a/arch/x86/kernel/cpu/perf_event_amd.c
+++ b/arch/x86/kernel/cpu/perf_event_amd.c
@@ -323,7 +323,7 @@ static void amd_pmu_cpu_starting(int cpu)
 	nb_id = amd_get_nb_id(cpu);
 	WARN_ON_ONCE(nb_id == BAD_APICID);
 
-	for_each_online_cpu(i) {
+	for_each_cpu(i, topology_core_cpumask(cpu)) {
 		nb = per_cpu(cpu_hw_events, i).amd_nb;
 		if (WARN_ON_ONCE(!nb))
 			continue;
diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
index 354d1de..ad70c2c 100644
--- a/arch/x86/kernel/cpu/perf_event_intel.c
+++ b/arch/x86/kernel/cpu/perf_event_intel.c
@@ -1111,7 +1111,7 @@ static void intel_pmu_cpu_starting(int cpu)
 	if (!ht_enabled(cpu))
 		return;
 
-	for_each_online_cpu(i) {
+	for_each_cpu(i, topology_thread_cpumask(cpu)) {
 		struct intel_percore *pc = per_cpu(cpu_hw_events, i).per_core;
 
 		if (pc && pc->core_id == core_id) {
-- 
1.7.3





--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 5/7] perf: Optimise topology iteration, Lin Ming, (Mon Dec 27, 8:38 am)
Re: [PATCH 5/7] perf: Optimise topology iteration, Peter Zijlstra, (Mon Jan 3, 4:02 am)
Re: [PATCH 5/7] perf: Optimise topology iteration, Andi Kleen, (Mon Jan 3, 8:20 am)
Re: [PATCH 5/7] perf: Optimise topology iteration, Lin Ming, (Mon Jan 3, 11:18 pm)
Re: [PATCH 5/7] perf: Optimise topology iteration, Lin Ming, (Tue Jan 4, 12:13 am)
Re: [PATCH 5/7] perf: Optimise topology iteration, Peter Zijlstra, (Tue Jan 4, 5:06 am)
Re: [PATCH 5/7] perf: Optimise topology iteration, Borislav Petkov, (Tue Jan 4, 7:22 am)