NO! That's wrong, in fact non of them are being used, but removing them
will decrease the number of kmap_atomic slots, but those are still being

Feh, its only a few pages and since there is no way to actually tell if
you've got enough kmap atomic pages other than experiencing runtime

Nacked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
--

[ message continues ]

Would you mind pointing out examples of such uses (i.e. without
the proper enumerator)? How would those avoid collisions with

Whether 2Mb of lowmem is "only a few pages" certainly depends
on the perspective you take.

And even then - shouldn't the bad (non-enumerated) uses of
atomic kmap-s be fixed rather than keeping unused entries in
the enumeration just because there is broken code somewhere?

Jan

--

[ message continues ]

Nobody uses explicit slots anymore:

/*
 * Make both: kmap_atomic(page, idx) and kmap_atomic(page) work.
 */
#define kmap_atomic(page, args...) __kmap_atomic(page)

All instances of KM_foo are deprecated and in need of a cleanup.

With the current 20 slots on x86, its 80k per CPU, you need 25 CPUs to
cross the 2M boundary, 32bit kernels having that many CPUs deserve to
suffer.


--

[ message continues ]