Re: [PATCH] regulator: Add initial per-regulator debugfs support

Previous thread: [git pull] drm fixes by Dave Airlie on Tuesday, December 21, 2010 - 4:43 pm. (12 messages)

Next thread: [PATCH v2] USB: add support for Dream Cheeky DL100B Webmail Notifier (1d34:0004) by Melchior FRANZ on Tuesday, December 21, 2010 - 4:58 pm. (3 messages)
From: Mark Brown
Date: Tuesday, December 21, 2010 - 4:49 pm

We only expose the use and open counts to userspace, providing a tiny
bit of insight into what the API is up to.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---

This is clearly a completely different tack to Brandon's patches in
terms of content but it does expose a bit of the internals like I was
talking about in review of those patches and it gets the basic debugfs
setup stuff done so we don't need to re-review that.

 drivers/regulator/core.c         |   35 +++++++++++++++++++++++++++++++++++
 include/linux/regulator/driver.h |    8 ++++++--
 2 files changed, 41 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 6066a8f..9fa2095 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -17,6 +17,7 @@
 
 #include <linux/kernel.h>
 #include <linux/init.h>
+#include <linux/debugfs.h>
 #include <linux/device.h>
 #include <linux/slab.h>
 #include <linux/err.h>
@@ -47,6 +48,10 @@ static LIST_HEAD(regulator_map_list);
 static bool has_full_constraints;
 static bool board_wants_dummy_regulator;
 
+#ifdef CONFIG_DEBUG_FS
+static struct dentry *debugfs_root;
+#endif
+
 /*
  * struct regulator_map
  *
@@ -2404,6 +2409,23 @@ static int add_regulator_attributes(struct regulator_dev *rdev)
 	return status;
 }
 
+static void rdev_init_debugfs(struct regulator_dev *rdev)
+{
+#ifdef CONFIG_DEBUG_FS
+	rdev->debugfs = debugfs_create_dir(rdev_get_name(rdev), debugfs_root);
+	if (IS_ERR(rdev->debugfs) || !rdev->debugfs) {
+		rdev_warn(rdev, "Failed to create debugfs directory\n");
+		rdev->debugfs = NULL;
+		return;
+	}
+
+	debugfs_create_u32("use_count", 0444, rdev->debugfs,
+			   &rdev->use_count);
+	debugfs_create_u32("open_count", 0444, rdev->debugfs,
+			   &rdev->open_count);
+#endif
+}
+
 /**
  * regulator_register - register regulator
  * @regulator_desc: regulator to register
@@ -2548,6 +2570,8 @@ struct regulator_dev *regulator_register(struct regulator_desc ...
From: Liam Girdwood
Date: Wednesday, December 22, 2010 - 3:26 pm

Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--

Previous thread: [git pull] drm fixes by Dave Airlie on Tuesday, December 21, 2010 - 4:43 pm. (12 messages)

Next thread: [PATCH v2] USB: add support for Dream Cheeky DL100B Webmail Notifier (1d34:0004) by Melchior FRANZ on Tuesday, December 21, 2010 - 4:58 pm. (3 messages)