[PATCH 4/6] perf-probe: Fix line range description since a single file is allowed

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Franck Bui-Huu
Date: Monday, December 20, 2010 - 7:18 am

From: Franck Bui-Huu <fbuihuu@gmail.com>

	$ perf-probe -L sched.c

is currently allowed but not documented.

Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
---
 tools/perf/Documentation/perf-probe.txt |    2 +-
 tools/perf/util/probe-event.c           |   13 ++++++++-----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/tools/perf/Documentation/perf-probe.txt b/tools/perf/Documentation/perf-probe.txt
index 62de1b7..562501f 100644
--- a/tools/perf/Documentation/perf-probe.txt
+++ b/tools/perf/Documentation/perf-probe.txt
@@ -117,7 +117,7 @@ LINE SYNTAX
 -----------
 Line range is descripted by following syntax.
 
- "FUNC[:RLN[+NUM|-RLN2]]|SRC:ALN[+NUM|-ALN2]"
+ "FUNC[:RLN[+NUM|-RLN2]]|SRC[:ALN[+NUM|-ALN2]]"
 
 FUNC specifies the function name of showing lines. 'RLN' is the start line
 number from function entry line, and 'RLN2' is the end line number. As same as
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 3c92b92..8e5f5ff 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -525,15 +525,18 @@ int show_available_vars(struct perf_probe_event *pevs __unused,
 }
 #endif
 
+/*
+ * Stuff 'lr' according to the line range described by 'arg'.
+ * The line range syntax is described by:
+ *
+ *         SRC[:SLN[+NUM|-ELN]]
+ *         FNC[:SLN[+NUM|-ELN]]
+ */
 int parse_line_range_desc(const char *arg, struct line_range *lr)
 {
 	const char *ptr;
 	char *tmp;
-	/*
-	 * <Syntax>
-	 * SRC:SLN[+NUM|-ELN]
-	 * FUNC[:SLN[+NUM|-ELN]]
-	 */
+
 	ptr = strchr(arg, ':');
 	if (ptr) {
 		lr->start = (int)strtoul(ptr + 1, &tmp, 0);
-- 
1.7.3.2

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/6] Minor cleanups &amp; fixes for perf-probe(1), Franck Bui-Huu, (Mon Dec 20, 7:17 am)
[PATCH 4/6] perf-probe: Fix line range description since a ..., Franck Bui-Huu, (Mon Dec 20, 7:18 am)
Re: [PATCH 1/6] perf-tools: make perf-probe -L display the ..., Masami Hiramatsu, (Mon Dec 20, 10:30 pm)
Re: [PATCH 6/6] perf-probe: handle gracefully some stupid ..., Masami Hiramatsu, (Tue Dec 21, 6:10 am)
Re: [PATCH 0/6] Minor cleanups &amp; fixes for perf-probe(1), Masami Hiramatsu, (Tue Dec 21, 6:11 am)
Re: [PATCH 0/6] Minor cleanups &amp; fixes for perf-probe(1), Franck Bui-Huu, (Tue Dec 21, 11:01 am)
Re: [PATCH 0/6] Minor cleanups &amp; fixes for perf-probe(1), Arnaldo Carvalho de Melo, (Tue Dec 21, 2:05 pm)
[tip:perf/core] perf probe: Make -L display the absolute p ..., tip-bot for Franck B ..., (Wed Dec 22, 4:30 am)
[tip:perf/core] perf probe: Rewrite show_one_line() to mak ..., tip-bot for Franck B ..., (Wed Dec 22, 4:30 am)
[tip:perf/core] perf probe: Clean up redundant tests in sh ..., tip-bot for Franck B ..., (Wed Dec 22, 4:31 am)
[tip:perf/core] perf probe: Fix line range description sin ..., tip-bot for Franck B ..., (Wed Dec 22, 4:31 am)
[tip:perf/core] perf probe: Don't always consider EOF as a ..., tip-bot for Franck B ..., (Wed Dec 22, 4:31 am)
[tip:perf/core] perf probe: Handle gracefully some stupid ..., tip-bot for Franck B ..., (Wed Dec 22, 4:32 am)
Re: [tip:perf/core] perf probe: Don't always consider EOF ..., Arnaldo Carvalho de Melo, (Wed Dec 22, 7:43 am)
Re: [PATCH 0/6] Minor cleanups &amp; fixes for perf-probe(1), Masami Hiramatsu, (Thu Dec 23, 5:36 pm)
[tip:perf/core] perf probe: Fix wrong warning in __show_on ..., tip-bot for Franck B ..., (Sat Dec 25, 1:58 am)