[PATCH v3 0/3] Fix more NFS readdir regressions

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Trond Myklebust
Date: Wednesday, December 1, 2010 - 8:08 pm

> OK. The first patch in this series fixes the regression reported by



v2 fixes the following issues:
 - Fix up the cookie usage in uncached_readdir()
 - Changelog fixups for the second patch
 - .releasepage should use kmap_atomic() so that it can be called
   from all direct reclaim contexts.
 - Ensure that .releasepage also clears Pg_uptodate
 - Set/clear the Pg_private flag to ensure .releasepage gets called when
   appropriate.
 - Add a .invalidatepage to ensure truncate_inode_pages() works correctly
 - Ensure that the anonymous page that is generated by uncached_readdir()
   doesn't leak memory.

v3:
 - add the freepage() address space operation.
 - Dump the page locking
 - rewrite patch 'Fix a memory leak in nfs_readdir' to work with the new
   ->freepage() callback.

Linus Torvalds (1):
  Call the filesystem back whenever a page is removed from the page
    cache

Trond Myklebust (2):
  NFS: Ensure we use the correct cookie in nfs_readdir_xdr_filler
  NFS: Fix a memory leak in nfs_readdir

 Documentation/filesystems/Locking |    7 ++++++-
 Documentation/filesystems/vfs.txt |    7 +++++++
 fs/nfs/dir.c                      |   28 +++++++++++++++++-----------
 fs/nfs/inode.c                    |    1 +
 include/linux/fs.h                |    1 +
 include/linux/nfs_fs.h            |    1 +
 mm/truncate.c                     |    8 ++++++++
 mm/vmscan.c                       |   11 +++++++++++
 8 files changed, 52 insertions(+), 12 deletions(-)

-- 
1.7.3.2

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 2/3] NFS: lock the readdir page while it is in use, Trond Myklebust, (Tue Nov 30, 8:47 pm)
[PATCH 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Tue Nov 30, 8:47 pm)
[PATCH v2 0/3] Fix more NFS readdir regressions, Trond Myklebust, (Wed Dec 1, 8:36 am)
[PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 8:36 am)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 9:17 am)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 9:47 am)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 10:58 am)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Miklos Szeredi, (Wed Dec 1, 11:29 am)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 11:54 am)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 12:47 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 12:52 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 1:05 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 1:10 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 1:18 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 2:51 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 3:24 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 3:47 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 4:21 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 4:31 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 4:43 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 4:56 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 6:05 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 6:42 pm)
[PATCH v3 0/3] Fix more NFS readdir regressions, Trond Myklebust, (Wed Dec 1, 8:08 pm)
[PATCH v3 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 8:08 pm)
[PATCH v4 0/3] Fix more NFS readdir regressions, Trond Myklebust, (Mon Dec 6, 9:59 am)
[PATCH v4 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Mon Dec 6, 9:59 am)