Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Wednesday, December 1, 2010 - 6:05 pm

On Wed, Dec 1, 2010 at 3:36 PM, Andrew Morton <akpm@linux-foundation.org> wrote:

Did you even read the email?

Here, let me quote the important parts:

  "module won't be unloaded until the machine has gone through an idle cycle"

  "This is pretty much how all the module races are handled. Doing module
   ref-counts per page (or per packet in flight for things like
   networking) would be prohibitively expensive."

IOW, the whole "stop_machine()" part is fundamental. That whole
"module unload won't happen until we've gone through an idle cycle" is
EXACTLY why we don't need to have the page attached or ref-counted -
we're still safe.

                    Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 2/3] NFS: lock the readdir page while it is in use, Trond Myklebust, (Tue Nov 30, 8:47 pm)
[PATCH 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Tue Nov 30, 8:47 pm)
[PATCH v2 0/3] Fix more NFS readdir regressions, Trond Myklebust, (Wed Dec 1, 8:36 am)
[PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 8:36 am)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 9:17 am)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 9:47 am)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 10:58 am)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Miklos Szeredi, (Wed Dec 1, 11:29 am)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 11:54 am)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 12:47 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 12:52 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 1:05 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 1:10 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 1:18 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 2:51 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 3:24 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 3:47 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 4:21 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 4:31 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 4:43 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 4:56 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 6:05 pm)
Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir, Linus Torvalds, (Wed Dec 1, 6:42 pm)
[PATCH v3 0/3] Fix more NFS readdir regressions, Trond Myklebust, (Wed Dec 1, 8:08 pm)
[PATCH v3 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Wed Dec 1, 8:08 pm)
[PATCH v4 0/3] Fix more NFS readdir regressions, Trond Myklebust, (Mon Dec 6, 9:59 am)
[PATCH v4 3/3] NFS: Fix a memory leak in nfs_readdir, Trond Myklebust, (Mon Dec 6, 9:59 am)