[PATCHv6 09/16] pps: use BUG_ON for kernel API safety checks

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alexander Gordeev
Date: Friday, December 17, 2010 - 12:54 pm

This way less overhead is involved when running production kernel.
If you want to debug a pps client module please define DEBUG to enable
the checks.

Acked-by: Rodolfo Giometti <giometti@linux.it>
Signed-off-by: Alexander Gordeev <lasaine@lvk.cs.msu.su>
---
 drivers/pps/kapi.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/pps/kapi.c b/drivers/pps/kapi.c
index c42d3cb..3e8eb3f 100644
--- a/drivers/pps/kapi.c
+++ b/drivers/pps/kapi.c
@@ -166,10 +166,8 @@ void pps_event(struct pps_device *pps, struct pps_event_time *ts, int event,
 	int captured = 0;
 	struct pps_ktime ts_real;
 
-	if ((event & (PPS_CAPTUREASSERT | PPS_CAPTURECLEAR)) == 0) {
-		dev_err(pps->dev, "unknown event (%x)\n", event);
-		return;
-	}
+	/* check event type */
+	BUG_ON((event & (PPS_CAPTUREASSERT | PPS_CAPTURECLEAR)) == 0);
 
 	dev_dbg(pps->dev, "PPS event at %ld.%09ld\n",
 			ts->ts_real.tv_sec, ts->ts_real.tv_nsec);
-- 
1.7.2.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCHv6 00/16] pps: several fixes and improvements, Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 03/16] pps: fix race in PPS_FETCH handler, Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 04/16] pps: unify timestamp gathering, Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 05/16] pps: access pps device by direct pointer, Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 06/16] pps: convert printk/pr_* to dev_*, Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 07/16] pps: move idr stuff to pps.c, Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 08/16] pps: do not disable interrupts for idr ope ..., Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 09/16] pps: use BUG_ON for kernel API safety checks, Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 10/16] pps: simplify conditions a bit, Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 11/16] pps: timestamp is always passed to dcd_cha ..., Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 12/16] ntp: add hardpps implementation, Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 13/16] pps: capture MONOTONIC_RAW timestamps as well, Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 14/16] pps: add kernel consumer support, Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 15/16] pps: add parallel port PPS client, Alexander Gordeev, (Fri Dec 17, 12:54 pm)
[PATCHv6 16/16] pps: add parallel port PPS signal generator, Alexander Gordeev, (Fri Dec 17, 12:54 pm)
Re: [PATCHv6 07/16] pps: move idr stuff to pps.c, Andrew Morton, (Fri Dec 17, 5:13 pm)
Re: [PATCHv6 15/16] pps: add parallel port PPS client, Andrew Morton, (Fri Dec 17, 5:17 pm)
Re: [PATCHv6 00/16] pps: several fixes and improvements, Andrew Morton, (Fri Dec 17, 5:19 pm)
Re: [PATCHv6 15/16] pps: add parallel port PPS client, Alexander Gordeev, (Fri Dec 17, 5:50 pm)
Re: [PATCHv6 16/16] pps: add parallel port PPS signal gene ..., Alexander Gordeev, (Fri Dec 17, 5:52 pm)
Re: [PATCHv6 00/16] pps: several fixes and improvements, Alexander Gordeev, (Fri Dec 17, 6:00 pm)
Re: [PATCHv6 07/16] pps: move idr stuff to pps.c, Alexander Gordeev, (Fri Dec 17, 6:07 pm)
Re: [PATCHv6 15/16] pps: add parallel port PPS client, Andrew Morton, (Fri Dec 17, 6:13 pm)
Re: [PATCHv6 00/16] pps: several fixes and improvements, Andrew Morton, (Fri Dec 17, 6:14 pm)
Re: [PATCHv6 07/16] pps: move idr stuff to pps.c, Andrew Morton, (Fri Dec 17, 6:18 pm)
[PATCHv7 00/16] changed some patches, Alexander Gordeev, (Mon Dec 20, 4:54 am)
[PATCHv7 08/16] pps: make idr lock a mutex and protect idr ..., Alexander Gordeev, (Mon Dec 20, 4:54 am)
[PATCHv7 12/16] ntp: add hardpps implementation, Alexander Gordeev, (Mon Dec 20, 4:54 am)
[PATCHv7 13/16] pps: capture MONOTONIC_RAW timestamps as well, Alexander Gordeev, (Mon Dec 20, 4:54 am)
[PATCHv7 14/16] pps: add kernel consumer support, Alexander Gordeev, (Mon Dec 20, 4:54 am)
[PATCHv7 15/16] pps: add parallel port PPS client, Alexander Gordeev, (Mon Dec 20, 4:54 am)
[PATCHv7 16/16] pps: add parallel port PPS signal generator, Alexander Gordeev, (Mon Dec 20, 4:54 am)
Re: [PATCHv7 16/16] pps: add parallel port PPS signal gene ..., Alexander Gordeev, (Thu Dec 23, 6:37 pm)