[RFC 4/5] swap: Remove unnecessary page release

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Minchan Kim
Date: Friday, December 17, 2010 - 10:13 am

This patch series changes remove_from_page_cache's page ref counting
rule. page cache ref count is decreased in remove_from_page_cache.
So we don't need call again in caller context.

Cc:Hugh Dickins <hughd@google.com>
Cc: linux-mm@kvack.org
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
---
 mm/shmem.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index fa9acc9..16800f2 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1091,7 +1091,6 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc)
 		spin_unlock(&info->lock);
 		swap_shmem_alloc(swap);
 		BUG_ON(page_mapped(page));
-		page_cache_release(page);	/* pagecache ref */
 		swap_writepage(page, wbc);
 		if (inode) {
 			mutex_lock(&shmem_swaplist_mutex);
-- 
1.7.0.4

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC 1/5] drop page reference on remove_from_page_cache, Minchan Kim, (Fri Dec 17, 10:13 am)
[RFC 2/5] fuse: Remove unnecessary page release, Minchan Kim, (Fri Dec 17, 10:13 am)
[RFC 3/5] tlbfs: Remove unnecessary page release, Minchan Kim, (Fri Dec 17, 10:13 am)
[RFC 4/5] swap: Remove unnecessary page release, Minchan Kim, (Fri Dec 17, 10:13 am)
[RFC 5/5] truncate: Remove unnecessary page release, Minchan Kim, (Fri Dec 17, 10:13 am)
Re: [RFC 1/5] drop page reference on remove_from_page_cache, KAMEZAWA Hiroyuki, (Sun Dec 19, 6:53 pm)
Re: [RFC 2/5] fuse: Remove unnecessary page release, KAMEZAWA Hiroyuki, (Sun Dec 19, 6:54 pm)
Re: [RFC 3/5] tlbfs: Remove unnecessary page release, KAMEZAWA Hiroyuki, (Sun Dec 19, 6:54 pm)
Re: [RFC 4/5] swap: Remove unnecessary page release, KAMEZAWA Hiroyuki, (Sun Dec 19, 6:55 pm)
Re: [RFC 5/5] truncate: Remove unnecessary page release, KAMEZAWA Hiroyuki, (Sun Dec 19, 6:55 pm)
Re: [RFC 5/5] truncate: Remove unnecessary page release, KOSAKI Motohiro, (Sun Dec 19, 7:21 pm)
Re: [RFC 5/5] truncate: Remove unnecessary page release, KAMEZAWA Hiroyuki, (Sun Dec 19, 7:27 pm)
Re: [RFC 5/5] truncate: Remove unnecessary page release, KOSAKI Motohiro, (Sun Dec 19, 7:32 pm)
Re: [RFC 5/5] truncate: Remove unnecessary page release, KOSAKI Motohiro, (Sun Dec 19, 8:03 pm)
Re: [RFC 5/5] truncate: Remove unnecessary page release, KAMEZAWA Hiroyuki, (Sun Dec 19, 9:35 pm)
Re: [RFC 5/5] truncate: Remove unnecessary page release, KAMEZAWA Hiroyuki, (Mon Dec 20, 1:54 am)
Re: [RFC 0/5] Change page reference hanlding semantic of p ..., Christoph Hellwig, (Mon Dec 20, 3:33 am)