login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
December
»
16
Re: [PATCH] cramfs: generate unique inode number for better inode cache usage
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Pekka Enberg
Subject:
Re: [PATCH] cramfs: generate unique inode number for better inode cache usage
Date: Thursday, December 16, 2010 - 4:45 am
On 12/16/10 11:52 AM,
stefani@seibold.net
wrote:
quoted text
> +static unsigned long cramino(struct cramfs_inode * cino, unsigned int offset) > +{ > + if (!cino->offset) > + return offset + 1; > + if (!cino->size) > + return offset + 1; > + > + /* the mode test fix buggy mkcramfs implementations */
I'm getting into the bikeshedding territory but a less terse comment would be in order here, I think.
quoted text
> + switch (cino->mode& S_IFMT) { > + case S_IFREG: > + case S_IFDIR: > + case S_IFLNK: > + return cino->offset<< 2; > + default: > + break; > + } > + return offset + 1; > +}
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] cramfs: generate unique inode number for better in ...
, stefani
, (Thu Dec 16, 2:52 am)
Re: [PATCH] cramfs: generate unique inode number for bette ...
, Pekka Enberg
, (Thu Dec 16, 4:45 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
Og dreams of kernels
Jens Axboe
[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann
Re: finding your own dead "CONFIG_" variables
Mark Brown
[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds
[LGUEST] Look in object dir for .config
git
:
Brian Downing
Re: Git in a Nutshell guide
John Benes
Re: master has some toys
Matthias Lederhofer
[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian
[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano
Re: Rss produced by git is not valid xml?
git-commits-head
:
Linux Kernel Mailing List
iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List
ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List
ixgbe: fix several counter register errata
Linux Kernel Mailing List
b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List
9p: block-based virtio client
linux-netdev
:
Michael Breuer
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
Michael Breuer
Re: [