[PATCH v2] btrfs: fix memory leak on error path in btrfs_get_acl()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Mariusz Kozlowski
Date: Wednesday, December 15, 2010 - 11:10 pm

If posix_acl_from_xattr() fails we leak memory stored in 'value'.

Signed-off-by: Mariusz Kozlowski <mk@lab.zgora.pl>
---
 fs/btrfs/acl.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index 2222d16..6d1410e 100644
--- a/fs/btrfs/acl.c
+++ b/fs/btrfs/acl.c
@@ -60,8 +60,10 @@ static struct posix_acl *btrfs_get_acl(struct inode *inode, int type)
 		size = __btrfs_getxattr(inode, name, value, size);
 		if (size > 0) {
 			acl = posix_acl_from_xattr(value, size);
-			if (IS_ERR(acl))
+			if (IS_ERR(acl)) {
+				kfree(value);
 				return acl;
+			}
 			set_cached_acl(inode, type, acl);
 		}
 		kfree(value);
-- 
1.7.0.4

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] btrfs: fix memory leak on error path in btrfs_get_ ..., Mariusz Kozlowski, (Wed Dec 15, 2:57 pm)
Re: [PATCH] btrfs: fix memory leak on error path in btrfs_ ..., Mariusz Kozlowski, (Wed Dec 15, 10:56 pm)
[PATCH v2] btrfs: fix memory leak on error path in btrfs_g ..., Mariusz Kozlowski, (Wed Dec 15, 11:10 pm)