Re: [PATCH 1/3] Kernel interfaces for multiqueue aware socket

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: John Fastabend
Date: Wednesday, December 15, 2010 - 1:52 pm

On 12/15/2010 12:02 PM, Yu, Fenghua wrote:

I think it would be easier to manipulate the sk_hash to accomplish this. Allowing this from user space doesn't seem so great to me. You don't really want to pick the tx/rx bindings for sockets I think what you actually want is to optimize the hashing for this case to avoid the bottleneck you observe.

I'm not too familiar with the af_packet stuff but could you do this with a single flag that indicates the sk_hash should be set in {t}packet_snd(). Maybe I missed your point or there is a reason this wouldn't work. But, then you don't need to do funny stuff in select_queue and it works with rps/xps as well.

--John.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 1/3] Kernel interfaces for multiqueue aware socket, John Fastabend, (Wed Dec 15, 1:52 pm)
Re: [PATCH 1/3] Kernel interfaces for multiqueue aware socket, Stephen Hemminger, (Wed Dec 15, 6:23 pm)
Re: [PATCH 1/3] Kernel interfaces for multiqueue aware socket, Dimitris Michailidis, (Wed Dec 15, 7:43 pm)