Re: [cpuops cmpxchg double V1 2/4] x86: this_cpu_cmpxchg_double() support

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Christoph Lameter
Date: Wednesday, December 15, 2010 - 9:20 am

Better comments:

Subject: Fixup comments for cmpxchg16b_cpuops_emu

Indicate that the sematics are not fullly atomic but just per cpu atomic.

Signed-off-by: Christoph Lameter <cl@linux.com>

---
 arch/x86/lib/cmpxchg16b_emu.S |    4 ++++
 1 file changed, 4 insertions(+)

Index: linux-2.6/arch/x86/lib/cmpxchg16b_emu.S
===================================================================
--- linux-2.6.orig/arch/x86/lib/cmpxchg16b_emu.S	2010-12-15 10:18:18.000000000 -0600
+++ linux-2.6/arch/x86/lib/cmpxchg16b_emu.S	2010-12-15 10:19:11.000000000 -0600
@@ -30,6 +30,10 @@ CFI_STARTPROC
 # Emulate 'cmpxchg16b %gs:(%rsi)' except we return the result in
 # al not via the ZF. Caller will access al to get result.
 #
+# Note that this is only useful for a cpuops operation. Meaning that we
+# do *not* have a fully atomic operation but just an operation that is
+# *atomic* on a single cpu (as provided by the this_cpu_xx class of macros)
+#
 cmpxchg16b_cpuops_emu:
 	pushf
 	cli

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[cpuops cmpxchg double V1 0/4] this_cpu_cmpxchg_double support, Christoph Lameter, (Tue Dec 14, 10:48 am)
[cpuops cmpxchg double V1 1/4] Generic support for this_cp ..., Christoph Lameter, (Tue Dec 14, 10:48 am)
[cpuops cmpxchg double V1 2/4] x86: this_cpu_cmpxchg_doubl ..., Christoph Lameter, (Tue Dec 14, 10:48 am)
[cpuops cmpxchg double V1 3/4] slub: Get rid of slab_free_ ..., Christoph Lameter, (Tue Dec 14, 10:48 am)
[cpuops cmpxchg double V1 4/4] Lockless (and preemptless) ..., Christoph Lameter, (Tue Dec 14, 10:48 am)
Re: [cpuops cmpxchg double V1 2/4] x86: this_cpu_cmpxchg_d ..., Christoph Lameter, (Wed Dec 15, 9:12 am)
Re: [cpuops cmpxchg double V1 2/4] x86: this_cpu_cmpxchg_d ..., Christoph Lameter, (Wed Dec 15, 9:20 am)
Re: [cpuops cmpxchg double V1 2/4] x86: this_cpu_cmpxchg_d ..., Christoph Lameter, (Wed Dec 15, 9:41 am)
Re: [cpuops cmpxchg double V1 2/4] x86: this_cpu_cmpxchg_d ..., Christoph Lameter, (Wed Dec 15, 10:53 am)
Re: [cpuops cmpxchg double V1 1/4] Generic support for thi ..., Christoph Lameter, (Tue Dec 21, 3:36 pm)
Re: [cpuops cmpxchg double V1 1/4] Generic support for thi ..., Christoph Lameter, (Thu Dec 23, 5:16 pm)
Re: [cpuops cmpxchg double V1 1/4] Generic support for thi ..., Christoph Lameter, (Fri Dec 24, 9:53 pm)
Re: [cpuops cmpxchg double V1 1/4] Generic support for thi ..., Christoph Lameter, (Sat Dec 25, 4:55 pm)