Re: [PATCH v6 0/5] da850-evm: add gpio-{keys,leds} for UI and BB expanders

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ben Gardiner
Date: Tuesday, December 14, 2010 - 9:17 am

On Mon, Dec 13, 2010 at 4:53 PM, Kevin Hilman
<khilman@deeprootsystems.com> wrote:

Oops on my part...

I looked at git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-davinci.git#davinci-next
again ; HEAD at the time was:

  commit 5682cfebad5e68736f4c54a268b5b371698f5262
  Author: Ben Gardiner <bengardiner@nanometrics.ca>
  Date:   Thu Dec 9 16:51:07 2010 -0500

      da850-evm: KEYBOARD_GPIO_POLLED Kconfig conditional

      Use the mach-davinci/Kconfig to enable gpio-keys-polled as default when
      da850-evm machine is enabled.

      Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca>
      CC: Kevin Hilman <khilman@deeprootsystems.com>
      CC: "Nori, Sekhar" <nsekhar@ti.com>
      CC: Gabor Juhos <juhosg@openwrt.org>
      Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>

and I was unable to build a kernel from da8xx_omapl_defconfig b/c:

  arch/arm/mach-davinci/board-da850-evm.c:333: error: unknown field
'poll_interval' specified in initializer

It appears that dropping the cherry-pick caused the build failure.

The commit that introduces the polled gpio keys driver (which was
included in the series as a cherry pick) is commit
0e7d0c860a0dee49dacb7bbb248d1eba637075ad which is in
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git#master
_after_ the tag v2.6.37-rc5.

That's my fault. I incorrectly thought that commit
0e7d0c860a0dee49dacb7bbb248d1eba637075ad was _in_ 2.6.37-rc5 and
stated this is previous emails. I'm sorry for the confusion; I think I
jumped the gun there due to my excitement at getting this prerequisite
driver committed.

Best Regards,
Ben Gardiner

---
Nanometrics Inc.
http://www.nanometrics.ca
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH v3 1/4] input: gpio_keys: polling mode support, Ben Gardiner, (Fri Nov 19, 2:37 pm)
[PATCH v3 2/4] da850-evm: add UI Expander pushbuttons, Ben Gardiner, (Fri Nov 19, 2:37 pm)
[PATCH v4 1/5] input: gpio_keys: polling mode support, Ben Gardiner, (Tue Nov 23, 12:40 pm)
[PATCH v4 2/5] da850-evm: add UI Expander pushbuttons, Ben Gardiner, (Tue Nov 23, 12:40 pm)
Re: [PATCH v4 2/5] da850-evm: add UI Expander pushbuttons, Ben Gardiner, (Wed Nov 24, 10:16 am)
[PATCH v5 2/5] da850-evm: add UI Expander pushbuttons, Ben Gardiner, (Wed Nov 24, 2:59 pm)
[PATCH v6 2/5] da850-evm: add UI Expander pushbuttons, Ben Gardiner, (Thu Dec 9, 2:51 pm)
Re: [PATCH v6 0/5] da850-evm: add gpio-{keys,leds} for UI ..., Ben Gardiner, (Tue Dec 14, 9:17 am)