Home » Mailing list archives » linux-kernel » 2010 » December » 12

[PATCH] bttv: fix mutex use before init

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dave Young
Subject: [PATCH] bttv: fix mutex use before init
Date: Sunday, December 12, 2010 - 6:15 am

oops happen in bttv_open while locking uninitialized mutex fh->cap.vb_lock
add mutex_init before usage

Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
Tested-by: Chris Clayton <chris2553@googlemail.com>
---
 drivers/media/video/bt8xx/bttv-driver.c |    2 ++
 1 file changed, 2 insertions(+)

--- linux-2.6.orig/drivers/media/video/bt8xx/bttv-driver.c	2010-11-27 11:21:30.000000000 +0800
+++ linux-2.6/drivers/media/video/bt8xx/bttv-driver.c	2010-12-12 16:31:39.633333338 +0800
@@ -3291,6 +3291,8 @@ static int bttv_open(struct file *file)
 	fh = kmalloc(sizeof(*fh), GFP_KERNEL);
 	if (unlikely(!fh))
 		return -ENOMEM;
+
+	mutex_init(&fh->cap.vb_lock);
 	file->private_data = fh;
 
 	/*
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] bttv: fix mutex use before init, Dave Young, (Sun Dec 12, 6:15 am)
Re: [PATCH] bttv: fix mutex use before init, Torsten Kaiser, (Sun Dec 12, 9:13 am)
Re: [PATCH] bttv: fix mutex use before init, Dave Young, (Mon Dec 13, 7:04 am)
Re: [PATCH] bttv: fix mutex use before init, Torsten Kaiser, (Mon Dec 13, 12:06 pm)
Re: [PATCH] bttv: fix mutex use before init, Brandon Philips, (Mon Dec 13, 5:30 pm)
Re: [PATCH] bttv: fix mutex use before init, Dave Young, (Tue Dec 14, 5:05 am)
Re: [PATCH] bttv: fix mutex use before init, Torsten Kaiser, (Tue Dec 14, 1:56 pm)
Re: [PATCH] bttv: fix mutex use before init, Torsten Kaiser, (Tue Dec 14, 2:13 pm)
Re: [PATCH] bttv: fix mutex use before init, Brandon Philips, (Tue Dec 14, 2:43 pm)
Re: [PATCH] bttv: fix mutex use before init, Brandon Philips, (Tue Dec 14, 2:48 pm)
Re: [PATCH] bttv: fix mutex use before init, Dave Young, (Tue Dec 14, 7:42 pm)
Re: [PATCH] bttv: fix mutex use before init, Torsten Kaiser, (Tue Dec 14, 11:47 pm)
Re: [PATCH] bttv: fix mutex use before init, Chris Clayton, (Wed Dec 15, 11:44 am)
Re: [PATCH] bttv: fix mutex use before init, Mauro Carvalho Chehab, (Wed Dec 15, 2:45 pm)
Re: [PATCH] bttv: fix mutex use before init, Chris Clayton, (Thu Dec 16, 10:26 am)
Re: [PATCH] bttv: fix mutex use before init, Torsten Kaiser, (Fri Dec 17, 7:05 am)
Re: [PATCH] bttv: fix mutex use before init, Brandon Philips, (Fri Dec 17, 9:07 am)
Re: [PATCH] bttv: fix mutex use before init, Mauro Carvalho Chehab, (Fri Dec 17, 1:11 pm)