Re: [PATCH 5/9] Add i.MX5 framebuffer driver

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Liu Ying
Date: Saturday, December 11, 2010 - 11:13 pm

Hello, Sascha,

I have following comments to this patch:
1) Please modify the commit message, as IPUv3 is not embedded in i.MX50 SoC.
2) ADC is not supported yet in the framebuffer driver, so please
modify this comment:
   > + * Framebuffer Framebuffer Driver for SDC and ADC.
3) 'ipu_dp_set_window_pos()' is called only once in
imx_ipu_fb_set_par_overlay(). So, the framebuffer driver doesn't
support to change the overlay framebuffer position. Need a
mechanism/interface for users to change the overlay framebuffer
position.
4) Need to make sure the framebuffer on DP-FG is blanked before the
framebuffer on DP-BG is blanked. Meanwhile, the framebuffer on DP-FG
should be unblanked after the framebuffer on DP-BG is unblanked
5) Need to check the framebuffer on DP-FG doesn't run out of the range
of the framebuffer on DP-BG.
6) I prefer to find the video mode in modedb first, and if we cannot
find the video mode in common video mode data base, we can find a
video mode in custom video mode data base which is defined in platform
data. In this way, we don't need to export common modefb.

Best Regards,
Liu Ying


2010/12/9 Sascha Hauer <s.hauer@pengutronix.de>:
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH RFC] i.MX51 Framebuffer support, Sascha Hauer, (Thu Dec 9, 6:47 am)
[PATCH 1/9] ARM i.MX51: Add ipu clock support, Sascha Hauer, (Thu Dec 9, 6:47 am)
[PATCH 2/9] ARM i.MX51: rename IPU irqs, Sascha Hauer, (Thu Dec 9, 6:47 am)
[PATCH 3/9] Add a mfd IPUv3 driver, Sascha Hauer, (Thu Dec 9, 6:47 am)
[PATCH 4/9] fb: export fb mode db table, Sascha Hauer, (Thu Dec 9, 6:47 am)
[PATCH 5/9] Add i.MX5 framebuffer driver, Sascha Hauer, (Thu Dec 9, 6:47 am)
[PATCH 6/9] ARM i.MX51: Add IPU device support, Sascha Hauer, (Thu Dec 9, 6:47 am)
Re: [PATCH 2/9] ARM i.MX51: rename IPU irqs, Uwe Kleine-König, (Thu Dec 9, 7:34 am)
Re: [PATCH 3/9] Add a mfd IPUv3 driver, Liu Ying, (Sat Dec 11, 10:21 pm)
Re: [PATCH 5/9] Add i.MX5 framebuffer driver, Liu Ying, (Sat Dec 11, 11:13 pm)
Re: [PATCH 5/9] Add i.MX5 framebuffer driver, Lothar Waßmann, (Mon Dec 13, 12:23 am)
Re: [PATCH 3/9] Add a mfd IPUv3 driver, Sascha Hauer, (Mon Dec 13, 4:23 am)
Re: [PATCH 5/9] Add i.MX5 framebuffer driver, Liu Ying, (Mon Dec 13, 4:35 am)
Re: [PATCH 5/9] Add i.MX5 framebuffer driver, Sascha Hauer, (Mon Dec 13, 4:38 am)
Re: [PATCH 3/9] Add a mfd IPUv3 driver, Liu Ying, (Mon Dec 13, 9:05 pm)
Re: [PATCH 5/9] Add i.MX5 framebuffer driver, Liu Ying, (Mon Dec 13, 11:40 pm)
Re: [PATCH 3/9] Add a mfd IPUv3 driver, Sascha Hauer, (Tue Dec 14, 1:40 am)
Re: [PATCH 5/9] Add i.MX5 framebuffer driver, Sascha Hauer, (Tue Dec 14, 1:45 am)
Re: [PATCH 3/9] Add a mfd IPUv3 driver, Liu Ying, (Tue Dec 14, 6:13 am)
Re: [PATCH 5/9] Add i.MX5 framebuffer driver, Liu Ying, (Tue Dec 14, 6:23 am)
Re: [PATCH 5/9] Add i.MX5 framebuffer driver, Sascha Hauer, (Wed Dec 15, 4:17 am)
Re: [PATCH 1/9] ARM i.MX51: Add ipu clock support, Arnd Bergmann, (Wed Dec 15, 8:40 am)
Re: [PATCH 6/9] ARM i.MX51: Add IPU device support, Arnd Bergmann, (Wed Dec 15, 8:49 am)
Re: [PATCH 6/9] ARM i.MX51: Add IPU device support, Arnaud Patard, (Wed Dec 15, 9:26 am)
Re: [PATCH 6/9] ARM i.MX51: Add IPU device support, Arnd Bergmann, (Wed Dec 15, 9:29 am)
Re: [PATCH 1/9] ARM i.MX51: Add ipu clock support, Russell King - ARM Linux, (Wed Dec 15, 9:34 am)
Re: [PATCH 1/9] ARM i.MX51: Add ipu clock support, Arnd Bergmann, (Wed Dec 15, 9:49 am)
Re: [PATCH 1/9] ARM i.MX51: Add ipu clock support, Russell King - ARM Linux, (Wed Dec 15, 10:12 am)