Home » Mailing list archives » linux-kernel » 2010 » December » 10

Re: [RFC][PATCH v2 2/3] spi_bitbang : get nsecs delay from cs during transfer

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Wolfram Sang
Subject: Re: [RFC][PATCH v2 2/3] spi_bitbang : get nsecs delay from cs during transfer
Date: Friday, December 10, 2010 - 4:46 am

Hi,

thanks for the submission. It has some issues, though:

On Thu, Dec 09, 2010 at 03:34:55PM -0500, Ben Gardiner wrote:


This coding style is very hard to read and gains nothing for it. Also,
slower_spi should rather be a per-device than a config option.

Kind regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH][RFC] spi-gpio: implement spidelay() for platforms ..., Ben Gardiner, (Fri Nov 19, 3:19 pm)
[RFC][PATCH v2 0/3] slower spi-gpio, Ben Gardiner, (Thu Dec 9, 1:34 pm)
[RFC][PATCH v2 1/3] spi-gpio: implement spidelay() for pla ..., Ben Gardiner, (Thu Dec 9, 1:34 pm)
[RFC][PATCH v2 2/3] spi_bitbang : get nsecs delay from cs ..., Ben Gardiner, (Thu Dec 9, 1:34 pm)
[RFC][PATCH v2 3/3] spi-gpio: use _cansleep when CONFIG_SL ..., Ben Gardiner, (Thu Dec 9, 1:34 pm)
Re: [RFC][PATCH v2 2/3] spi_bitbang : get nsecs delay from ..., Wolfram Sang, (Fri Dec 10, 4:46 am)
Re: [RFC][PATCH v2 2/3] spi_bitbang : get nsecs delay from ..., Ben Gardiner, (Tue Dec 14, 9:58 am)
Re: [RFC][PATCH v2 2/3] spi_bitbang : get nsecs delay from ..., Wolfram Sang, (Tue Dec 14, 11:08 am)
Re: [RFC][PATCH v2 2/3] spi_bitbang : get nsecs delay from ..., Ben Gardiner, (Tue Dec 14, 11:17 am)