Re: [PATCH 1/4] drm: fix headers to include linux/types.h

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Kristian Høgsberg

Subject: Re: [PATCH 1/4] drm: fix headers to include linux/types.h

Date: Wednesday, December 1, 2010 - 10:54 am

On Wed, Dec 1, 2010 at 11:54 AM, Julien Cristau <jcristau@debian.org> wrote:
quoted text> On Wed, Dec  1, 2010 at 17:10:42 +0200, Alexander Shishkin wrote:
>
>> For headers that get exported to userland and make use of u32 style
>> type names, it is advised to include linux/types.h.
>>
>> This fixes 5 headers_check warnings.
>>
> How many times does this need to be NAKed?  These headers are shared
> with the BSDs, and they include drm.h which has the linux/types.h
> include on linux already.

I'll NAK it too, if that helps.

Kristian
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/4] trivial header fixes, Alexander Shishkin, (Wed Dec 1, 8:10 am)

[PATCH 1/4] drm: fix headers to include linux/types.h, Alexander Shishkin, (Wed Dec 1, 8:10 am)

[PATCH 2/4] cramfs: hide function prototypes behind __KERN ..., Alexander Shishkin, (Wed Dec 1, 8:10 am)

[PATCH 3/4] scsi: fix a header to include linux/types.h, Alexander Shishkin, (Wed Dec 1, 8:10 am)

[PATCH 4/4] toshiba.h: hide a function prototypes behind _ ..., Alexander Shishkin, (Wed Dec 1, 8:10 am)

Re: [PATCH 1/4] drm: fix headers to include linux/types.h, Julien Cristau, (Wed Dec 1, 9:54 am)

Re: [PATCH 1/4] drm: fix headers to include linux/types.h, Alexander Shishkin, (Wed Dec 1, 10:37 am)

Re: [PATCH 1/4] drm: fix headers to include linux/types.h, Kristian Høgsberg, (Wed Dec 1, 10:54 am)

Re: [PATCH 1/4] drm: fix headers to include linux/types.h, Andrew Morton, (Wed Dec 1, 12:38 pm)

Re: [Intel-gfx] [PATCH 1/4] drm: fix headers to include li ..., Dave Airlie, (Wed Dec 1, 12:55 pm)

Re: [Intel-gfx] [PATCH 1/4] drm: fix headers to include li ..., Randy Dunlap, (Wed Dec 1, 1:12 pm)


linux-kernel:
Mel Gorman	Re: [PATCH 1/4] vmstat: remove zone->lock from walk_zones_in_node
Guenter Roeck	Re: [lm-sensors] Location for thermal drivers
David Woodhouse	Re: RFC: Moving firmware blobs out of the kernel.
Siddha, Suresh B	Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU k...
Peter Zijlstra	Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)
git-commits-head:
Linux Kernel Mailing List	[MIPS] Fix potential latency problem due to non-atomic cpu_wait.
Linux Kernel Mailing List	USB: rename USB_SPEED_VARIABLE to USB_SPEED_WIRELESS
Linux Kernel Mailing List	lib/vsprintf.c: fix bug omitting minus sign of numbers (module_param)
Linux Kernel Mailing List	[Bluetooth] Initiate authentication during connection establishment
Linux Kernel Mailing List	[POWERPC] 4xx: Add ppc40x_defconfig
linux-netdev:
MERCEDES	Your mail id has won 950,000.00 in the MERCEDES Benz Online Promo.for claims send:
David Miller	Re: [PATCH] xen/netfront: do not mark packets of length < MSS as GSO
David Miller	Re: skb_segment() questions
Shan Wei	[RFC PATCH net-next 2/5]IPv6:netfilter: Send an ICMPv6 "Fragment Reassembly Timeou...
Stanislaw Gruszka	[PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations
git:
Nicolas Sebrecht	git-svn died of signal 11 (was "3 failures on test t9100 (svn)")
Junio C Hamano	Re: [PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
Martin Langhoff	Re: [PATCH] GIT commit statistics.
Alexandre Julliard	[PATCH] gitweb: Put back shortlog instead of graphiclog in the project list.
Josh Triplett	[PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
openbsd-misc:
Taisto Qvist XX	Re: AMD GEODE LX-800 just works with kernel from install42.iso and kernelpanics wi...
Nico Meijer	Re: gOS Develop Kit with VIA pc-1 Processor Platform VIA C7-D
Andreas Bihlmaier	Re: jetway board sensors (Fintek F71805F)
admin	Drive a 2009 car from R799p/m
Antti Harri	Re: how to create a sha256 hash