Home » Mailing list archives » linux-kernel » 2010 » December » 1

Re: [PATCH] Kconfig: add new symbol MIGHT_HAVE_PCI

Previous thread: Re: [PATCH] PM: Prevent dpm_prepare() from returning errors unnecessarily by Alan Stern on Wednesday, December 1, 2010 - 8:15 am. (2 messages)

Next thread: VIEW ATTACHED DOCUMENT. by WCS BIG5 PROMO!!! on Wednesday, December 1, 2010 - 8:57 am. (1 message)
[view original message]
From: Hans Ulli Kroll
Subject: [PATCH] Kconfig: add new symbol MIGHT_HAVE_PCI
Date: Wednesday, December 1, 2010 - 8:30 am

Today more boards with arm cpu have selectable pci bus.
This patch makes this more scalable and remove line continuations in
Kconfig

Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans Ulli Kroll <ulli.kroll@googlemail.com>
---
 arch/arm/Kconfig                 |    7 ++++++-
 arch/arm/mach-cns3xxx/Kconfig    |    1 +
 arch/arm/mach-integrator/Kconfig |    1 +
 arch/arm/mach-ks8695/Kconfig     |    1 +
 arch/arm/mach-pxa/Kconfig        |    1 +
 arch/arm/mach-versatile/Kconfig  |    1 +
 6 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index a19a526..614cf2f 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -34,6 +34,9 @@ config ARM
 config HAVE_PWM
 	bool
 
+config MIGHT_HAVE_PCI
+	bool
+
 config SYS_SUPPORTS_APM_EMULATION
 	bool
 
@@ -298,6 +301,7 @@ config ARCH_CNS3XXX
 	select CPU_V6
 	select GENERIC_CLOCKEVENTS
 	select ARM_GIC
+	select MIGHT_HAVE_PCI
 	select PCI_DOMAINS if PCI
 	help
 	  Support for Cavium Networks CNS3XXX platform.
@@ -433,6 +437,7 @@ config ARCH_IXP4XX
 	select CPU_XSCALE
 	select GENERIC_GPIO
 	select GENERIC_CLOCKEVENTS
+	select MIGHT_HAVE_PCI
 	select DMABOUNCE if PCI
 	help
 	  Support for Intel's IXP4XX (XScale) family of processors.
@@ -1164,7 +1169,7 @@ config ISA_DMA_API
 	bool
 
 config PCI
-	bool "PCI support" if ARCH_INTEGRATOR_AP || ARCH_VERSATILE_PB || ARCH_IXP4XX || ARCH_KS8695 || MACH_ARMCORE || ARCH_CNS3XXX
+	bool "PCI support" if MIGHT_HAVE_PCI
 	help
 	  Find out whether you have a PCI motherboard. PCI is the name of a
 	  bus system, i.e. the way the CPU talks to the other stuff inside
diff --git a/arch/arm/mach-cns3xxx/Kconfig b/arch/arm/mach-cns3xxx/Kconfig
index 9ebfcc4..29b13f2 100644
--- a/arch/arm/mach-cns3xxx/Kconfig
+++ b/arch/arm/mach-cns3xxx/Kconfig
@@ -3,6 +3,7 @@ menu "CNS3XXX platform type"
 
 config MACH_CNS3420VB
 	bool "Support for CNS3420 Validation Board"
+	select MIGHT_HAVE_PCI
 	help
 	  Include support for the Cavium ...
[ message continues ]
[view original message]
From: Arnd Bergmann
Subject: Re: [PATCH] Kconfig: add new symbol MIGHT_HAVE_PCI
Date: Wednesday, December 1, 2010 - 8:41 am

Looks good to me!

Acked-by: Arnd Bergmann <arnd@arndb.de>
--


[ message continues ]
[view original message]
From: Uwe Kleine-König
Subject: Re: [PATCH] Kconfig: add new symbol MIGHT_HAVE_PCI
Date: Wednesday, December 1, 2010 - 11:51 am

HAVE_PCI or HAS_PCI is a more usual name for this purpose.

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--


[ message continues ]
[view original message]
From: Russell King - ARM Linux
Subject: Re: [PATCH] Kconfig: add new symbol MIGHT_HAVE_PCI
Date: Wednesday, December 1, 2010 - 12:04 pm

This has been discussed in the thread "[PATCH] ARM: Gemini: Add support
for PCI Bus".
--


[ message continues ]
[view original message]
From: Uwe Kleine-König
Subject: Re: [PATCH] Kconfig: add new symbol MIGHT_HAVE_PCI
Date: Wednesday, December 1, 2010 - 12:55 pm

Ah, I see, MIGHT_HAVE_PCI only makes the prompt available.  Hmm, well
OK.

Thanks for clearifying
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--


[ message continues ]
[view original message]
From: avictor.za@gmail.com
Subject: Re: [PATCH] Kconfig: add new symbol MIGHT_HAVE_PCI
Date: Wednesday, December 1, 2010 - 2:01 pm

Where-as this only enables it for the KS8695 Development board (MACH_KS8695)....


Regards.
  Andrew Victor
--


[ message continues ]
Previous thread: Re: [PATCH] PM: Prevent dpm_prepare() from returning errors unnecessarily by Alan Stern on Wednesday, December 1, 2010 - 8:15 am. (2 messages)

Next thread: VIEW ATTACHED DOCUMENT. by WCS BIG5 PROMO!!! on Wednesday, December 1, 2010 - 8:57 am. (1 message)