perf hw in kexeced kernel broken in tip

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Yinghai Lu
Date: Wednesday, December 1, 2010 - 1:00 am

First kernel:
[    1.139418] calling  init_hw_perf_events+0x0/0xb77 @ 1
[    1.159111] Performance Events: PEBS fmt1+, Nehalem events, Intel PMU
driver.
[    1.159567] ... version:                3
[    1.179121] ... bit width:              48
[    1.179353] ... generic registers:      4
[    1.179593] ... value mask:             0000ffffffffffff
[    1.199211] ... max period:             000000007fffffff
[    1.199554] ... fixed-purpose events:   3
[    1.219108] ... event mask:             000000070000000f
[    1.219454] initcall init_hw_perf_events+0x0/0xb77 returned 0 after
11719 usecs

.....
[   20.220997] checking TSC synchronization [CPU#0 -> CPU#11]: passed.
[   20.260818] NMI watchdog enabled, takes one hw-pmu counter.

kexeced kernel.


[    1.169470] calling  init_hw_perf_events+0x0/0xb77 @ 1
[    1.189265] Performance Events: PEBS fmt1+, Nehalem events, Broken
PMU hardware detected, software events only.
...
[   21.010407] NMI watchdog failed to create perf event on cpu14:
fffffffffffffffe

caused by:

commit 33c6d6a7ad0ffab9b1b15f8e4107a2af072a05a0
Author: Don Zickus <dzickus@redhat.com>
Date:   Mon Nov 22 16:55:23 2010 -0500

    x86, perf, nmi: Disable perf if counters are not accessible
   
    In a kvm virt guests, the perf counters are not emulated.  Instead they
    return zero on a rdmsrl. The perf nmi handler uses the fact that
crossing
    a zero means the counter overflowed (for those counters that do not have
    specific interrupt bits). Therefore on kvm guests, perf will swallow all
    NMIs thinking the counters overflowed.
   
    This causes problems for subsystems like kgdb which needs NMIs to do its
    magic. This problem was discovered by running kgdb tests.
   
    The solution is to write garbage into a perf counter during the
    initialization and hopefully reading back the same number.  On kvm
    guests, the value will be read back as zero and we disable perf as
    a result.
   
    Reported-by: Jason Wessel <jason.wessel@windriver.com>
    Patch-inspired-by: Peter Zijlstra <peterz@infradead.org>
    Signed-off-by: Don Zickus <dzickus@redhat.com>
    Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Stephane Eranian <eranian@google.com>
    LKML-Reference: <1290462923-30734-1-git-send-email-dzickus@redhat.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/arch/x86/kernel/cpu/perf_event.c
b/arch/x86/kernel/cpu/perf_event.c
index ed63101..6d75b91 100644
--- a/arch/x86/kernel/cpu/perf_event.c
+++ b/arch/x86/kernel/cpu/perf_event.c
@@ -381,6 +381,20 @@ static void release_pmc_hardware(void) {}
 
 #endif
 
+static bool check_hw_exists(void)
+{
+       u64 val, val_new = 0;
+       int ret = 0;
+
+       val = 0xabcdUL;
+       ret |= checking_wrmsrl(x86_pmu.perfctr, val);
+       ret |= rdmsrl_safe(x86_pmu.perfctr, &val_new);
+       if (ret || val != val_new)
+               return false;
+
+       return true;
+}
+
 static void reserve_ds_buffers(void);
 static void release_ds_buffers(void);
 
@@ -1372,6 +1386,12 @@ void __init init_hw_perf_events(void)
 
        pmu_check_apic();
 
+       /* sanity check that the hardware exists or is emulated */
+       if (!check_hw_exists()) {
+               pr_cont("Broken PMU hardware detected, software events
only.\n");
+               return;
+       }
+
        pr_cont("%s PMU driver.\n", x86_pmu.name);
 
        if (x86_pmu.quirks)


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
perf hw in kexeced kernel broken in tip, Yinghai Lu, (Wed Dec 1, 1:00 am)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Wed Dec 1, 4:27 am)
Re: perf hw in kexeced kernel broken in tip, Vivek Goyal, (Wed Dec 1, 9:06 am)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Wed Dec 1, 9:11 am)
Re: perf hw in kexeced kernel broken in tip, Vivek Goyal, (Wed Dec 1, 9:23 am)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Wed Dec 1, 12:38 pm)
Re: perf hw in kexeced kernel broken in tip, Vivek Goyal, (Wed Dec 1, 12:46 pm)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Wed Dec 1, 12:49 pm)
Re: perf hw in kexeced kernel broken in tip, Vivek Goyal, (Wed Dec 1, 12:58 pm)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Wed Dec 1, 1:07 pm)
Re: perf hw in kexeced kernel broken in tip, Eric W. Biederman, (Wed Dec 1, 1:41 pm)
Re: perf hw in kexeced kernel broken in tip, Eric W. Biederman, (Wed Dec 1, 2:48 pm)
Re: perf hw in kexeced kernel broken in tip, Don Zickus, (Wed Dec 1, 10:23 pm)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Thu Dec 2, 12:34 am)
Re: perf hw in kexeced kernel broken in tip, Don Zickus, (Thu Dec 2, 9:15 am)
Re: perf hw in kexeced kernel broken in tip, Don Zickus, (Tue Dec 7, 2:16 pm)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Tue Dec 7, 4:30 pm)
Re: perf hw in kexeced kernel broken in tip, Yinghai Lu, (Tue Dec 7, 5:26 pm)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Wed Dec 8, 3:39 am)
Re: perf hw in kexeced kernel broken in tip, Don Zickus, (Wed Dec 8, 7:01 am)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Wed Dec 8, 7:20 am)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Wed Dec 8, 7:33 am)
Re: perf hw in kexeced kernel broken in tip, Vivek Goyal, (Wed Dec 8, 7:39 am)
Re: perf hw in kexeced kernel broken in tip, Vivek Goyal, (Wed Dec 8, 7:42 am)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Wed Dec 8, 7:48 am)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Wed Dec 8, 7:59 am)
Re: perf hw in kexeced kernel broken in tip, Vivek Goyal, (Wed Dec 8, 8:02 am)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Wed Dec 8, 8:15 am)
Re: perf hw in kexeced kernel broken in tip, Vivek Goyal, (Wed Dec 8, 8:22 am)
Re: perf hw in kexeced kernel broken in tip, Yinghai Lu, (Wed Dec 8, 11:43 am)
Re: perf hw in kexeced kernel broken in tip, Don Zickus, (Wed Dec 8, 12:01 pm)
Re: perf hw in kexeced kernel broken in tip, Yinghai Lu, (Wed Dec 8, 12:05 pm)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Wed Dec 8, 12:06 pm)
Re: perf hw in kexeced kernel broken in tip, Peter Zijlstra, (Wed Dec 8, 12:17 pm)
Re: perf hw in kexeced kernel broken in tip, Yinghai Lu, (Wed Dec 8, 12:20 pm)
Re: perf hw in kexeced kernel broken in tip, Yinghai Lu, (Wed Dec 8, 12:20 pm)
Re: perf hw in kexeced kernel broken in tip, Eric W. Biederman, (Wed Dec 8, 2:16 pm)
Re: perf hw in kexeced kernel broken in tip, Don Zickus, (Wed Dec 8, 3:37 pm)
Re: perf hw in kexeced kernel broken in tip, Eric W. Biederman, (Wed Dec 8, 4:20 pm)
Re: perf hw in kexeced kernel broken in tip, Don Zickus, (Wed Dec 8, 9:34 pm)
Re: perf hw in kexeced kernel broken in tip, Don Zickus, (Thu Dec 9, 1:20 pm)
Re: perf hw in kexeced kernel broken in tip, Cyrill Gorcunov, (Thu Dec 9, 1:44 pm)