Re: [2.6.37-rc1] udevd-event prints errors.

Previous thread: Re: OOM when adding ipv6 route: How to make available more per-cpu memory? by Eric Dumazet on Friday, November 5, 2010 - 11:06 am. (13 messages)

Next thread: [RFC PATCH 5/5] usb,keyboard,kdb: Implement HID keyboard polling by Jason Wessel on Friday, November 5, 2010 - 12:05 pm. (1 message)
From: Tetsuo Handa
Date: Friday, November 5, 2010 - 11:07 am

Hello.

I noticed that udevd-event started to print error messages.

  Starting udev: udevd-event[1682]: wait_for_sysfs: waiting for '/sys/devices/pci0000:00/0000:00:10.0/host0/ioerr_cnt' failed
  udevd-event[2103]: wait_for_sysfs: waiting for '/sys/devices/pci0000:00/0000:00:10.0/host0/target0:0:1/ioerr_cnt' failed
  udevd-event[2102]: wait_for_sysfs: waiting for '/sys/devices/pci0000:00/0000:00:10.0/host0/target0:0:0/ioerr_cnt' failed

These error messages are caused by one or more of below commits.
(Sorry, I can't find exact one because I can't boot as of below commits.)

5cfc64ce "base/platform: Safe handling for NULL platform data and resources"
807508c8 "base/platform: Simplifications for NULL platform data/resources handling"
39aba963 "driver core: remove CONFIG_SYSFS_DEPRECATED_V2 but keep it for block devices"

Is this a regression? (Is this an intended change?)

2.6.36 was OK and below is tail of bisection log.

# good: [da0d7f982d538f4a5bcdddb84df4a484a3b1770b] pch_phub: fix build warnings
git bisect good da0d7f982d538f4a5bcdddb84df4a484a3b1770b
# bad: [39aba963d937edb20db7d9d93e6dda5d2adfdcdd] driver core: remove CONFIG_SYSFS_DEPRECATED_V2 but keep it for block devices
git bisect bad 39aba963d937edb20db7d9d93e6dda5d2adfdcdd
# skip: [5cfc64ceb6222aabec640ba76e89529a8fc2c1f0] base/platform: Safe handling for NULL platform data and resources
git bisect skip 5cfc64ceb6222aabec640ba76e89529a8fc2c1f0
# skip: [807508c8ff9af6ce8f25c5ca5f3eb06a8e7d3286] base/platform: Simplifications for NULL platform data/resources handling
git bisect skip 807508c8ff9af6ce8f25c5ca5f3eb06a8e7d3286
# skip: [87544653abe4a03324bc85dae32d5bdaabcfccef] debugfs: mark me as the maintainer
git bisect skip 87544653abe4a03324bc85dae32d5bdaabcfccef

My environment is CentOS 5.5(GCC 4.1.2) i686 with 512MB RAM.

Regards.
--

From: Greg KH
Date: Friday, November 5, 2010 - 1:02 pm

Do you still have CONFIG_SYSFS_DEPRECATED enabled?

Other than that, everything works ok, right?

thanks,

greg k-h
--

From: Tetsuo Handa
Date: Saturday, November 6, 2010 - 4:18 am

# rpm -qf /sbin/udevd
udev-095-14.21.el5_5.1
# /usr/bin/udevinfo -V
Oh, around above commits, CONFIG_SYSFS_DEPRECATED has changed to "n"
by some reason. I changed to

  # grep CONFIG_SYSFS .config
  CONFIG_SYSFS_DEPRECATED=y
  CONFIG_SYSFS_DEPRECATED_V2=y
  CONFIG_SYSFS=y

and re-bisected. Now it turned out that

  39aba963 "driver core: remove CONFIG_SYSFS_DEPRECATED_V2 but keep it for block devices"

is the commit which caused these error messages.

Guessing from error messages, changes in drivers/scsi/hosts.c and
Right.

Regards.
--

From: Kay Sievers
Date: Saturday, November 6, 2010 - 7:23 am

On Sat, Nov 6, 2010 at 12:18, Tetsuo Handa

It's something that should be fixed in the udev rules. This is the
fixed line, we used in later releases. It adds an additional match to
prevent the warning you see:
  SUBSYSTEM=="scsi", KERNEL=="[0-9]*:[0-9]*", WAIT_FOR_SYSFS="ioerr_cnt"

All of that is not needed with current kernels, it was a hacky
workaround for broken sysfs/event timing issues we had years ago.

Kay
--

From: Tetsuo Handa
Date: Saturday, November 6, 2010 - 7:51 am

Hello.


I see.
Applying below patch solved these error messages on my CentOS 5.5 environment.

Thank you.

--- /etc/udev/rules.d/05-udev-early.rules
+++ /etc/udev/rules.d/05-udev-early.rules
@@ -1,7 +1,7 @@
 # sysfs is populated after the event is sent
 ACTION=="add", DEVPATH=="/devices/*", ENV{PHYSDEVBUS}=="?*", WAIT_FOR_SYSFS="bus"
 ACTION=="add", SUBSYSTEM=="net", WAIT_FOR_SYSFS="address"
-ACTION=="add", SUBSYSTEM=="scsi", WAIT_FOR_SYSFS="ioerr_cnt"                    
+ACTION=="add", SUBSYSTEM=="scsi", KERNEL=="[0-9]*:[0-9]*", WAIT_FOR_SYSFS="ioerr_cnt"
 
 # ignore these events until someone needs them
 SUBSYSTEM=="drivers",		OPTIONS="ignore_device"
--

Previous thread: Re: OOM when adding ipv6 route: How to make available more per-cpu memory? by Eric Dumazet on Friday, November 5, 2010 - 11:06 am. (13 messages)

Next thread: [RFC PATCH 5/5] usb,keyboard,kdb: Implement HID keyboard polling by Jason Wessel on Friday, November 5, 2010 - 12:05 pm. (1 message)