Home » Mailing list archives » linux-kernel » 2010 » November » 30

[RFC v2 0/8] TI DMM-TILER driver

Previous thread: [PATCH] drivers: char: hvc: add arm JTAG DCC console support by Daniel Walker on Tuesday, November 30, 2010 - 12:25 pm. (26 messages)

Next thread: [Patch 0/2] x86, UV: UV fixes for extra bits in nodeid register by steiner on Tuesday, November 30, 2010 - 12:55 pm. (5 messages)
[view original message]
From: David Sin
Subject: [RFC v2 0/8] TI DMM-TILER driver
Date: Tuesday, November 30, 2010 - 12:58 pm

Tiling and Isometric Lightweight Engine for Rotation (TILER) driver

Dynamic Memory Manager (DMM) is a hardware block made by Texas Instruments.
Within the DMM exists at least one TILER hardware component.  Its purpose is to
organize video/image memory in a 2-dimensional fashion to limit memory
bandwidth and facilitate 0 effort rotation and mirroring.  The TILER driver
facilitates allocating, freeing, as well as mapping 2D blocks (areas) in the
TILER container(s).  It also facilitates rotating and mirroring the allocated
blocks or its rectangular subsections.

TERMINOLOGY

"slot"

The basic TILER driver operates on blocks of slots.  A slot is the granularity
of the TILER hardware device.  For all current uses it is 4K, but could also be
16 or 64K.  The DMM-TILER TRM refers to this as "page" but we want to separate
this concept from the MMU pages.

"page"

The granularity of the MMU, used by the kernel.  This is 4K.

"block"

The TILER hardware component supports 1D and 2D blocks.  A 2D block is a
rectangular arrangement of slots with arbitrary width and height in a 2D 
container.  A 1D block is a linear arrangement of slots with arbitrary length
 in a 1D container.  This TILER driver only supports 2D blocks.

"container"

The TILER driver supports an arbitrary TILER container size.  However, for
all current implementations it is 256 by 128 slots.  The container currently can
only be used as a 2D container.

"reserved area"

Each block resides within a reserved area in the container.  This area may
be larger than the actual set of slots that a block occupies.  The reason for
this is to protect access from one block into another.  Since TILER container is
mmap-ped into user space as individual pages, all slots that are spanned by
that page become visible to the user.  The tiler driver allows restricting the
granularity of the reserved area (default alignment) as well as the mapped
area (granularity).

Changes made from RFC v1: ...
[ message continues ]
[view original message]
From: David Sin
Subject: [RFC v2 2/8] TILER-DMM: Container manager interface and utility definitons
Date: Tuesday, November 30, 2010 - 12:58 pm

From: Lajos Molnar <molnar@ti.com>

This patch defined the TILER Container Manager (TCM) interface and
provides utility methods for implementing a TCM.

Signed-off-by: Lajos Molnar <molnar@ti.com>
Signed-off-by: David Sin <davidsin@ti.com>
Signed-off-by: Ravi Ramachandra <r.ramachandra@ti.com>
---
 drivers/misc/tiler/tcm.h           |  171 ++++++++++++++++++++++++++++++++++++
 drivers/misc/tiler/tcm/tcm-utils.h |   51 +++++++++++
 2 files changed, 222 insertions(+), 0 deletions(-)
 create mode 100644 drivers/misc/tiler/tcm.h
 create mode 100644 drivers/misc/tiler/tcm/tcm-utils.h

diff --git a/drivers/misc/tiler/tcm.h b/drivers/misc/tiler/tcm.h
new file mode 100644
index 0000000..8968108
--- /dev/null
+++ b/drivers/misc/tiler/tcm.h
@@ -0,0 +1,171 @@
+/*
+ * TILER container manager specification and support functions for TI
+ * TILER driver.
+ *
+ * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation version 2.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether express or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef TCM_H
+#define TCM_H
+
+struct tcm;
+
+/* point */
+struct tcm_pt {
+	u16 x;
+	u16 y;
+};
+
+/* 2d area */
+struct tcm_area {
+	struct tcm    *tcm;	/* parent */
+	struct tcm_pt  p0;
+	struct tcm_pt  p1;
+};
+
+struct tcm {
+	u16 width, height;	/* container dimensions */
+
+	/*
+	 * 'pvt' structure shall contain any tcm details (attr) along with
+	 * linked list of allocated areas and mutex for mutually exclusive
+	 * access to the list.  It may also contain copies of width and height
+	 * to notice any changes to the publicly available width and height
+	 * fields.
+	 ...
[ message continues ]
[view original message]
From: David Sin
Subject: [RFC v2 3/8] TILER-DMM: Sample TCM implementation: Simple TILER Allocator (SiTA)
Date: Tuesday, November 30, 2010 - 12:58 pm

From: Ravi Ramachandra <r.ramachandra@ti.com>

This patch implements a simple TILER Container Manager (TCM).

Signed-off-by: Ravi Ramachandra <r.ramachandra@ti.com>
Signed-off-by: Lajos Molnar <molnar@ti.com>
Signed-off-by: David Sin <davidsin@ti.com>
---
 drivers/misc/tiler/tcm/Makefile    |    1 +
 drivers/misc/tiler/tcm/_tcm-sita.h |   61 +++++
 drivers/misc/tiler/tcm/tcm-sita.c  |  422 ++++++++++++++++++++++++++++++++++++
 drivers/misc/tiler/tcm/tcm-sita.h  |   28 +++
 4 files changed, 512 insertions(+), 0 deletions(-)
 create mode 100644 drivers/misc/tiler/tcm/Makefile
 create mode 100644 drivers/misc/tiler/tcm/_tcm-sita.h
 create mode 100644 drivers/misc/tiler/tcm/tcm-sita.c
 create mode 100644 drivers/misc/tiler/tcm/tcm-sita.h

diff --git a/drivers/misc/tiler/tcm/Makefile b/drivers/misc/tiler/tcm/Makefile
new file mode 100644
index 0000000..8434607
--- /dev/null
+++ b/drivers/misc/tiler/tcm/Makefile
@@ -0,0 +1 @@
+obj-$(CONFIG_TI_TILER) += tcm-sita.o
diff --git a/drivers/misc/tiler/tcm/_tcm-sita.h b/drivers/misc/tiler/tcm/_tcm-sita.h
new file mode 100644
index 0000000..6e4d292
--- /dev/null
+++ b/drivers/misc/tiler/tcm/_tcm-sita.h
@@ -0,0 +1,61 @@
+/*
+ * SImple Tiler Allocator (SiTA) private structures.
+ *
+ * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation version 2.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether express or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef _TCM_SITA_H
+#define _TCM_SITA_H
+
+#include "../tcm.h"
+
+/* length between two coordinates */
+#define LEN(a, b) ((a) > (b) ? (a) - (b) + 1 : (b) - (a) + 1)
+
+enum criteria {
+	CR_MAX_NEIGHS		= ...
[ message continues ]
[view original message]
From: David Sin
Subject: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER
Date: Tuesday, November 30, 2010 - 12:58 pm

This patch adds support for DMM-PAT initialization and programming.

Signed-off-by: David Sin <davidsin@ti.com>
Signed-off-by: Lajos Molnar <molnar@ti.com>
---
 arch/arm/mach-omap2/dmm-omap44xx.c     |   81 ++++++++++++++
 arch/arm/mach-omap2/include/mach/dmm.h |   92 ++++++++++++++++
 drivers/misc/tiler/dmm-main.c          |  187 ++++++++++++++++++++++++++++++++
 3 files changed, 360 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-omap2/dmm-omap44xx.c
 create mode 100644 arch/arm/mach-omap2/include/mach/dmm.h
 create mode 100644 drivers/misc/tiler/dmm-main.c

diff --git a/arch/arm/mach-omap2/dmm-omap44xx.c b/arch/arm/mach-omap2/dmm-omap44xx.c
new file mode 100644
index 0000000..2919d8e
--- /dev/null
+++ b/arch/arm/mach-omap2/dmm-omap44xx.c
@@ -0,0 +1,81 @@
+/*
+ * DMM driver support functions for TI OMAP processors.
+ *
+ * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation version 2.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether express or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/init.h>
+#include <linux/module.h>
+#include <mach/dmm.h>
+#include <plat/omap_device.h>
+#include <plat/omap_hwmod.h>
+#include <linux/errno.h>
+#include <linux/err.h>
+
+static struct dmm *plat_data;
+static int pdata;
+
+#ifdef CONFIG_ARCH_OMAP4
+static struct dmm omap4_plat_data[] = {
+	{
+		.oh_name = "dmm",
+	},
+};
+#define NUM_PDATA ARRAY_SIZE(omap4_plat_data)
+#else
+#define omap4_plat_data NULL
+#define NUM_PDATA 0
+#endif
+
+static struct omap_device_pm_latency omap_dmm_latency[] = {
+	[0] = {
+		.deactivate_func = omap_device_idle_hwmods,
+		.activate_func = ...
[ message continues ]
[view original message]
From: Varadarajan, Charulatha
Subject: Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER
Date: Tuesday, November 30, 2010 - 11:04 pm

David,


Do not use these #ifdefs as it would not work as intended in multi-omap build.
This driver is making use of omap_hwmod fw. Try to take advantage of hwmod_fw


Any specific reson for not assigning it directly to omap_dmm_latency?
I think this is redundant and omap_dmm_latency can be directly passed

name "pdata" is confusing. Also no need to iterate over the list of
devices using

I do not find any other devices sharing same name for the device name
and oh->name.
Normally the device's name is preferred to be "omap_devname.id" to be
consistent across all drivers
and the oh->name is given as "devname(id)"

example: McSPI's device name could be "omap_mcspi" and it's hwmod name

not required. Make use of platform_get APIs in probe to extract the


<<snip>>
--


[ message continues ]
[view original message]
From: Kanigeri, Hari
Subject: Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER
Date: Wednesday, December 1, 2010 - 7:10 pm

Not sure about using platform_get APIs. I think one has to use
omap_hwmod_get_mpu_rt_va to get the address, which internally returns
oh-<_mpu_rt_va.
omap_hwmod_get_mpu_rt_va was added so that the individual drivers can
avoid doing the ioremap.
check the discussion regarding this.
http://www.spinics.net/lists/linux-omap/msg33048.html


Thank you,
Best regards,
Hari Kanigeri
--


[ message continues ]
[view original message]
From: Kanigeri, Hari
Subject: Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER
Date: Wednesday, December 1, 2010 - 7:27 pm

small correction... omap_device_get_rt_va and not omap_hwmod_get_mpu_rt_va.

Thank you,
Best regards,
Hari Kanigeri
--


[ message continues ]
[view original message]
From: Varadarajan, Charulatha
Subject: Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER
Date: Wednesday, December 1, 2010 - 10:16 pm

To get the base address & irq, you need not have to use
omap_device_get_rt_va and pass it as
pdata and then use it during probe. Instead in probe, you may do
something like the following:

static int __devinit  dev_probe (*pdev) {
   struct resource *res;
   void __iomem *base;
   u16 irq;
   ....
   ....
   res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
   if (unlikely(!res)) {
              ....
              return -ENODEV;
   }

   base = ioremap(res->start, resource_size(res));
   if (base) {
               ....
               return -ENOMEM;
   }

   res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
   if (unlikely(!res)) {
               ....
               return -ENODEV;
   }
   irq = res->start;
   ....
   ....
}

-V Charulatha
--


[ message continues ]
[view original message]
From: Hari Kanigeri
Subject: Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER
Date: Thursday, December 2, 2010 - 3:23 am

If hwmod framework is already doing the ioremap on device address,
then it is better to use it rather than duplicating the ioremap part
again in probe function.
From what I understand regarding omap_device_get_rt_va() function, it
is added so that Driver's can avoid doing ioremap.
check Santosh's comment on this API
--


[ message continues ]
[view original message]
From: Varadarajan, Charulatha
Subject: Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER
Date: Thursday, December 2, 2010 - 3:31 am

Okay. For base address, I agree, as it avoids redoing ioremap in drivers.
--


[ message continues ]
[view original message]
From: David Sin
Subject: [RFC v2 4/8] TILER-DMM: TILER Memory Manager interface and implementation
Date: Tuesday, November 30, 2010 - 12:58 pm

From: Lajos Molnar <molnar@ti.com>

This patch defines the TILER Memory Manager (TMM) interface and
provides implementation for a PAT-supporting TMM.

Signed-off-by: Lajos Molnar <molnar@ti.com>
Signed-off-by: David Sin <davidsin@ti.com>
---
 drivers/misc/tiler/tmm-pat.c |  266 ++++++++++++++++++++++++++++++++++++++++++
 drivers/misc/tiler/tmm.h     |  103 ++++++++++++++++
 2 files changed, 369 insertions(+), 0 deletions(-)
 create mode 100644 drivers/misc/tiler/tmm-pat.c
 create mode 100644 drivers/misc/tiler/tmm.h

diff --git a/drivers/misc/tiler/tmm-pat.c b/drivers/misc/tiler/tmm-pat.c
new file mode 100644
index 0000000..26b4da3
--- /dev/null
+++ b/drivers/misc/tiler/tmm-pat.c
@@ -0,0 +1,266 @@
+/*
+ * DMM driver support functions for TI TILER hardware block.
+ *
+ * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation version 2.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether express or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/init.h>
+#include <linux/module.h>
+#include <linux/mm.h>
+#include <linux/mmzone.h>
+#include <asm/cacheflush.h>
+#include <linux/mutex.h>
+#include <linux/list.h>
+#include <linux/slab.h>
+#include <linux/dma-mapping.h>
+
+#include "tmm.h"
+
+/* Page size granularity can be 4k, 16k, or 64k */
+#define DMM_PAGE SZ_4K
+
+/* Memory limit to cache free pages. TILER will eventually use this much */
+static u32 cache_limit = CONFIG_TILER_CACHE_LIMIT << 20;
+module_param_named(cache, cache_limit, uint, 0644);
+MODULE_PARM_DESC(cache, "Cache free pages if total memory is under this limit");
+
+/* global state - statically initialized */
+static ...
[ message continues ]
[view original message]
From: David Sin
Subject: [RFC v2 6/8] TILER-DMM: Geometry and view manipulation functions
Date: Tuesday, November 30, 2010 - 12:58 pm

From: Lajos Molnar <molnar@ti.com>

This patch contains information on TILER geometry, as well as
tiler_view_t object manipulation functions.

It also contains an internal TILER header file to share geometric
information with other TILER files.

Signed-off-by: Lajos Molnar <molnar@ti.com>
Signed-off-by: David Sin <davidsin@ti.com>
---
 drivers/misc/tiler/_tiler.h     |   48 +++++
 drivers/misc/tiler/tiler-geom.c |  362 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 410 insertions(+), 0 deletions(-)
 create mode 100644 drivers/misc/tiler/_tiler.h
 create mode 100644 drivers/misc/tiler/tiler-geom.c

diff --git a/drivers/misc/tiler/_tiler.h b/drivers/misc/tiler/_tiler.h
new file mode 100644
index 0000000..0f00330
--- /dev/null
+++ b/drivers/misc/tiler/_tiler.h
@@ -0,0 +1,48 @@
+/*
+ * TI TILER driver internal shared definitions.
+ *
+ * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation version 2.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether express or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef _TILER_H
+#define _TILER_H
+
+#include <linux/kernel.h>
+#include <mach/tiler.h>
+#include "tcm.h"
+
+#define TILER_FORMATS		(TILFMT_MAX - TILFMT_MIN + 1)
+
+/* tiler geometry information */
+struct tiler_geom {
+	u32 x_shft;	/* unused X-bits (as part of bpp) */
+	u32 y_shft;	/* unused Y-bits (as part of bpp) */
+	u32 bpp;	/* bytes per pixel */
+	u32 slot_w;	/* width of each slot (in pixels) */
+	u32 slot_h;	/* height of each slot (in pixels) */
+};
+
+/* methods and variables shared between source files */
+struct tiler_ops {
+	/* geometry operations */
+	void (*xy) (u32 ssptr, ...
[ message continues ]
[view original message]
From: Greg KH
Subject: Re: [RFC v2 6/8] TILER-DMM: Geometry and view manipulation functions
Date: Tuesday, November 30, 2010 - 5:55 pm

Ick, no, just name it "tiler.h" please.  There should not be any need to

Don't cause the kernel to crash within a driver for no good reason like
this.  Please fix these to WARN_ON if it's really something that can
happen.


EXPORT_SYMBOL_GPL() perhaps for all of these?

thanks,

greg k-h
--


[ message continues ]
[view original message]
From: David Sin
Subject: [RFC v2 7/8] TILER-DMM: Main TILER driver implementation
Date: Tuesday, November 30, 2010 - 12:58 pm

From: Lajos Molnar <molnar@ti.com>

This patch contains the TILER driver and implementation of the TILER
block manipulation and mapping functions.

It also contains the makefile and config file for the TILER driver.

Signed-off-by: Lajos Molnar <molnar@ti.com>
Signed-off-by: David Sin <davidsin@ti.com>
---
 arch/arm/mach-omap2/Makefile     |    1 +
 drivers/misc/tiler/Kconfig       |   72 +++++++
 drivers/misc/tiler/Makefile      |    7 +
 drivers/misc/tiler/tiler-iface.c |   66 ++++++
 drivers/misc/tiler/tiler-main.c  |  405 ++++++++++++++++++++++++++++++++++++++
 5 files changed, 551 insertions(+), 0 deletions(-)
 create mode 100644 drivers/misc/tiler/Kconfig
 create mode 100644 drivers/misc/tiler/Makefile
 create mode 100644 drivers/misc/tiler/tiler-iface.c
 create mode 100644 drivers/misc/tiler/tiler-main.c

diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
index ebd2589..d55e29c 100644
--- a/arch/arm/mach-omap2/Makefile
+++ b/arch/arm/mach-omap2/Makefile
@@ -183,3 +183,4 @@ obj-y					+= $(nand-m) $(nand-y)
 smc91x-$(CONFIG_SMC91X)			:= gpmc-smc91x.o
 obj-y					+= $(smc91x-m) $(smc91x-y)
 obj-$(CONFIG_ARCH_OMAP4)		+= hwspinlocks.o
+obj-$(CONFIG_ARCH_OMAP4)		+= dmm-omap44xx.o
diff --git a/drivers/misc/tiler/Kconfig b/drivers/misc/tiler/Kconfig
new file mode 100644
index 0000000..9b8bfed
--- /dev/null
+++ b/drivers/misc/tiler/Kconfig
@@ -0,0 +1,72 @@
+config HAVE_TI_DMM
+	bool
+	default y
+	depends on ARCH_OMAP4
+
+menuconfig TI_DMM
+        tristate "TI DMM support"
+        default y
+        depends on HAVE_TI_DMM
+        help
+           DMM driver for TI chips.
+
+menuconfig TI_TILER
+        tristate "TI TILER support"
+        default y
+        depends on TI_DMM
+        help
+           TILER driver for TI chips.  The TI TILER device
+           enables video rotation on certain TI chips such as OMAP4 or
+           TI816x.  Video rotation will be limited without TILER support.
+
+config TILER_GRANULARITY
+        int ...
[ message continues ]
[view original message]
From: Randy Dunlap
Subject: Re: [RFC v2 7/8] TILER-DMM: Main TILER driver implementation
Date: Tuesday, November 30, 2010 - 12:57 pm

Having (2^n) in the prompt makes me think that the value set here is "n",

and changing 2^n here to just say:

	  Must be a power of 2 in the range of 1 to 4096; however, ...



---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--


[ message continues ]
[view original message]
From: David Sin
Subject: [RFC v2 5/8] TILER-DMM: TILER interface file and documentation
Date: Tuesday, November 30, 2010 - 12:58 pm

From: Lajos Molnar <molnar@ti.com>

This patch contains the TILER interface file and the documentation.

Signed-off-by: Lajos Molnar <molnar@ti.com>
Signed-off-by: David Sin <davidsin@ti.com>
---
 Documentation/arm/OMAP/TILER             |  126 ++++++++++++++++++++++
 arch/arm/mach-omap2/include/mach/tiler.h |  173 ++++++++++++++++++++++++++++++
 2 files changed, 299 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/arm/OMAP/TILER
 create mode 100644 arch/arm/mach-omap2/include/mach/tiler.h

diff --git a/Documentation/arm/OMAP/TILER b/Documentation/arm/OMAP/TILER
new file mode 100644
index 0000000..2e94ad7
--- /dev/null
+++ b/Documentation/arm/OMAP/TILER
@@ -0,0 +1,126 @@
+Tiling and Isometric Lightweight Engine for Rotation (TILER) driver
+
+Dynamic Memory Manager (DMM) is a hardware block made by Texas Instruments.
+Within the DMM exists at least one TILER hardware component.  Its purpose is to
+organize video/image memory in a 2-dimensional fashion to limit memory
+bandwidth and facilitate 0 effort rotation and mirroring.  The TILER driver
+facilitates allocating, freeing, as well as mapping 2D blocks (areas) in the
+TILER container(s).  It also facilitates rotating and mirroring the allocated
+blocks or its rectangular subsections.
+
+TERMINOLOGY
+
+"slot"
+
+The basic TILER driver operates on blocks of slots.  A slot is the granularity
+of the TILER hardware device.  For all current uses it is 4K, but could also be
+16 or 64K.  The DMM-TILER TRM refers to this as "page" but we want to separate
+this concept from the MMU pages.
+
+"page"
+
+The granularity of the MMU, used by the kernel.  This is 4K.
+
+"block"
+
+The TILER hardware component supports 1D and 2D blocks.  A 2D block is a
+rectangular arrangement of slots with arbitrary width and height in a 2D 
+container.  A 1D block is a linear arrangement of slots with arbitrary length
+ in a 1D container.  This TILER driver only supports 2D blocks.
+
+"container"
+
+The TILER driver ...
[ message continues ]
[view original message]
From: Greg KH
Subject: Re: [RFC v2 5/8] TILER-DMM: TILER interface file and documentation
Date: Tuesday, November 30, 2010 - 5:53 pm

Shouldn't this .h file be in include/linux/ instead?  Why is it arch
specific?

thanks,

greg k-h
--


[ message continues ]
[view original message]
From: David Sin
Subject: [RFC v2 8/8] TILER-DMM: Linking TILER driver into the Linux kernel build
Date: Tuesday, November 30, 2010 - 12:58 pm

From: Lajos Molnar <molnar@ti.com>

This patch links the TILER driver into the Linux kernel build
and config system.

Signed-off-by: Lajos Molnar <molnar@ti.com>
Signed-off-by: David Sin <davidsin@ti.com>
---
 drivers/misc/Kconfig  |    5 +++++
 drivers/misc/Makefile |    1 +
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index ac6d6ac..fff7927 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -378,4 +378,9 @@ source "drivers/misc/eeprom/Kconfig"
 source "drivers/misc/cb710/Kconfig"
 source "drivers/misc/iwmc3200top/Kconfig"
 
+#
+# TI TILER driver support
+#
+source "drivers/misc/tiler/Kconfig"
+
 endif # MISC_DEVICES
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index bf6f0e0..9985a6f 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -33,3 +33,4 @@ obj-y				+= eeprom/
 obj-y				+= cb710/
 obj-$(CONFIG_VMWARE_BALLOON)	+= vmware_balloon.o
 obj-$(CONFIG_SENSORS_BH1780)	+= bh1780gli.o
+obj-$(CONFIG_TI_TILER)		+= tiler/
-- 
1.7.0.4

--


[ message continues ]
[view original message]
From: Greg KH
Subject: Re: [RFC v2 8/8] TILER-DMM: Linking TILER driver into the Linux kernel build
Date: Tuesday, November 30, 2010 - 5:56 pm

Comments not needed.

thanks,

greg k-h
--


[ message continues ]
[view original message]
From: David Sin
Subject: Re: [RFC v2 8/8] TILER-DMM: Linking TILER driver into the Linux kernel build
Date: Thursday, December 2, 2010 - 6:46 am

thanks, Greg, for the comments.  I will make all of these changes 
in the next revision.
-- 
David Sin
--


[ message continues ]
[view original message]
From: Varadarajan, Charulatha
Subject: Re: [RFC v2 0/8] TI DMM-TILER driver
Date: Tuesday, November 30, 2010 - 11:47 pm

The dmm driver is making use of omap_hwmod fw. But I could not see a patch
to add  dmm hwmod data to omap4 hwmod base in this series. Is this patch series
tested?
--


[ message continues ]
[view original message]
From: David Sin
Subject: Re: [RFC v2 0/8] TI DMM-TILER driver
Date: Thursday, December 2, 2010 - 6:52 am

yes -- this code has been tested against the omap_hwmod fw.  I will send 
out a patch in the next rev.  Thanks for your comments.
-- 
David Sin
--


[ message continues ]
Previous thread: [PATCH] drivers: char: hvc: add arm JTAG DCC console support by Daniel Walker on Tuesday, November 30, 2010 - 12:25 pm. (26 messages)

Next thread: [Patch 0/2] x86, UV: UV fixes for extra bits in nodeid register by steiner on Tuesday, November 30, 2010 - 12:55 pm. (5 messages)