login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
November
»
30
Re: [patch 2/9] perf: Use appropriate pointer type instead of silly typecasting
view
thread
Previous message: [thread] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Arnaldo Carvalho de Melo
Subject:
Re: [patch 2/9] perf: Use appropriate pointer type instead of silly typecasting
Date: Tuesday, November 30, 2010 - 11:33 am
Em Tue, Nov 30, 2010 at 05:49:35PM -0000, Thomas Gleixner escreveu:
quoted text
> There is no reason to use a struct sample_event pointer in struct sample_queue > and type cast it when flushing the queue.
quoted text
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
I touched that code in a branch I'm working on, same change :-\ Well, testing the other patches, thanks! - Arnaldo
quoted text
> tools/perf/util/session.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: linux-2.6-tip/tools/perf/util/session.c > =================================================================== > --- linux-2.6-tip.orig/tools/perf/util/session.c > +++ linux-2.6-tip/tools/perf/util/session.c > @@ -386,7 +386,7 @@ static event__swap_op event__swap_ops[] > > struct sample_queue { > u64 timestamp; > - struct sample_event *event; > + event_t *event; > struct list_head list; > }; > > @@ -406,7 +406,7 @@ static void flush_sample_queue(struct pe > if (iter->timestamp > limit) > break; > > - ops->sample((event_t *)iter->event, s); > + ops->sample(iter->event, s); > > os->last_flush = iter->timestamp; > list_del(&iter->list); >
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [thread] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
Re: [patch 2/9] perf: Use appropriate pointer type instead ...
, Arnaldo Carvalho de Melo
, (Tue Nov 30, 11:33 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ken Chen
[patch] sched: fix inconsistency when redistribute per-cpu tg->cfs_rq shares.
Hugh Dickins
Re: Linux 2.6.26-rc1 - pgtable_32.c:178 pmd_bad
Bernhard Beck
[PATCH 001/001] usb-serial: Add ThinkOptics WavIT
Oleg Nesterov
Re: [PATCH 4/5] don't panic if /sbin/init exits or killed
Greg KH
[patch 07/21] rtc-pcf8563: detect polarity of century bit automatically
git
:
Jonathan del Strother
Re: [PATCH] Fixing path quoting issues
Gerrit Pape
[PATCH] fix skipping merge-order test with NO_OPENSSL=1.
Linus Torvalds
Re: Implementing branch attributes in git config
Johannes Schindelin
Re: Trying to use git-filter-branch to compress history by removing large, obsolet...
Gerrit Pape
[PATCH] hooks--update: fix test for properly set up project description file
linux-netdev
:
David Miller
Re: [PATCH 04/15] tg3: Preserve LAA when device control is released
Jean-Louis Dupond
Re: tg3 driver not advertising 1000mbit
Sven Wegener
[PATCH] ipvs: Add missing locking during connection table hashing and unhashing
David Miller
Re: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2
Stephen Hemminger
[PATCH 2/2] sky2: fix transmit state on resume
git-commits-head
:
Linux Kernel Mailing List
[SCSI] scsi ioctl: fix kernel-doc warning
Linux Kernel Mailing List
ALSA: HDA - Correct trivial typos in comments.
Linux Kernel Mailing List
i2c-viapro: Add support for SMBus Process Call transactions
Linux Kernel Mailing List
i2c: Documentation: upgrading clients HOWTO
Linux Kernel Mailing List
[PATCH] fix sysctl_nr_open bugs
openbsd-misc
:
Die Gestalt
Re: How to re-build openssl with SHA1 support?
Edwin Eyan Moragas
Re: managing routes for multiple PPPoE connections
Brian Candler
Re: OBSD's perspective on SELinux
Jonathan Schleifer
Why is getaddrinfo breaking POSIX?
Predrag Punosevac
Re: Kernel developers guide/tutorial
Colocation donated by:
Syndicate