Home » Mailing list archives » linux-kernel » 2010 » November » 30

Re: [PATCH UPDATED#2 04/16] x86: Use local variable to cache smp_processor_id() in setup_local_APIC()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Cyrill Gorcunov
Subject: Re: [PATCH UPDATED#2 04/16] x86: Use local variable to cache smp_processor_id() in setup_local_APIC()
Date: Tuesday, November 30, 2010 - 11:22 am

On Tue, Nov 30, 2010 at 07:11:45PM +0100, Tejun Heo wrote:

code structure, if we would be referring variable taken inside preempt
off this always look suspicious, i think you agree with me :)

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCHSET] x86: unify x86_32 and 64 NUMA init paths, take#2, Tejun Heo, (Sat Nov 27, 8:21 am)
[PATCH 01/16] x86: Kill unused static boot_cpu_logical_api ..., Tejun Heo, (Sat Nov 27, 8:21 am)
[PATCH 04/16] x86: Use local variable to cache smp_process ..., Tejun Heo, (Sat Nov 27, 8:21 am)
[PATCH 05/16] x86: Replace cpu_2_logical_apicid[] with ear ..., Tejun Heo, (Sat Nov 27, 8:21 am)
[PATCH 06/16] x86: Always use x86_cpu_to_logical_apicid fo ..., Tejun Heo, (Sat Nov 27, 8:21 am)
[PATCH 07/16] x86: Remove custom apic->cpu_to_logical_apic ..., Tejun Heo, (Sat Nov 27, 8:21 am)
[PATCH 08/16] x86: Use apic->cpu_to_logical_apicid() to fi ..., Tejun Heo, (Sat Nov 27, 8:21 am)
[PATCH 09/16] x86: Implement cpu_to_logical_apicid() for b ..., Tejun Heo, (Sat Nov 27, 8:21 am)
[PATCH 10/16] x86: Implement cpu_to_logical_apicid() for s ..., Tejun Heo, (Sat Nov 27, 8:21 am)
[PATCH 11/16] x86: Implement cpu_to_logical_apicid() for n ..., Tejun Heo, (Sat Nov 27, 8:22 am)
[PATCH 12/16] x86: Replace apic->apicid_to_node() with ->n ..., Tejun Heo, (Sat Nov 27, 8:22 am)
[PATCH 13/16] x86: Unify cpu/apicid <-> NUMA node mapping ..., Tejun Heo, (Sat Nov 27, 8:22 am)
[PATCH 14/16] x86: Unify CPU -> NUMA node mapping between ..., Tejun Heo, (Sat Nov 27, 8:22 am)
[PATCH 15/16] x86: Unify node_to_cpumask_map handling betw ..., Tejun Heo, (Sat Nov 27, 8:22 am)
[PATCH 16/16] x86: Unify NUMA initialization between 32 an ..., Tejun Heo, (Sat Nov 27, 8:22 am)
Re: [PATCH 04/16] x86: Use local variable to cache smp_pro ..., Cyrill Gorcunov, (Sat Nov 27, 2:32 pm)
[PATCH UPDATED 04/16] x86: Use local variable to cache smp ..., Tejun Heo, (Tue Nov 30, 9:17 am)
[PATCH UPDATED#2 04/16] x86: Use local variable to cache s ..., Tejun Heo, (Tue Nov 30, 11:11 am)
Re: [PATCH UPDATED#2 04/16] x86: Use local variable to cac ..., Cyrill Gorcunov, (Tue Nov 30, 11:22 am)
Re: [PATCH UPDATED#2 04/16] x86: Use local variable to cac ..., Tejun Heo, (Tue Nov 30, 12:42 pm)
Re: [PATCH UPDATED#2 04/16] x86: Use local variable to cac ..., Cyrill Gorcunov, (Tue Nov 30, 1:52 pm)
Re: [PATCHSET] x86: unify x86_32 and 64 NUMA init paths, t ..., Tejun Heo, (Tue Dec 7, 9:22 am)
Re: [PATCH UPDATED#2 04/16] x86: Use local variable to cac ..., Pekka Enberg, (Thu Dec 9, 2:37 am)
Re: [PATCH UPDATED#3 04/16] x86: setup_local_APIC() must a ..., Cyrill Gorcunov, (Thu Dec 9, 9:17 am)
Re: [PATCH UPDATED#3 04/16] x86: setup_local_APIC() must a ..., Pekka Enberg, (Thu Dec 9, 9:18 am)
Re: [PATCH 07/16] x86: Remove custom apic->cpu_to_logical_ ..., Thomas Gleixner, (Thu Dec 9, 2:28 pm)
Re: [PATCH 13/16] x86: Unify cpu/apicid <-> NUMA node mapp ..., Thomas Gleixner, (Thu Dec 9, 2:43 pm)
Re: [PATCH 14/16] x86: Unify CPU -> NUMA node mapping betw ..., Thomas Gleixner, (Thu Dec 9, 2:49 pm)
Re: [PATCH UPDATED#3 04/16] x86: setup_local_APIC() must a ..., Thomas Gleixner, (Thu Dec 9, 2:56 pm)
Re: [PATCH UPDATED#3 04/16] x86: setup_local_APIC() must a ..., Tejun Heo, (Fri Dec 10, 4:09 am)
Re: [PATCH UPDATED#3 04/16] x86: setup_local_APIC() must a ..., Thomas Gleixner, (Fri Dec 10, 4:10 am)
Re: [PATCH 07/16] x86: Remove custom apic->cpu_to_logical_ ..., Tejun Heo, (Fri Dec 10, 4:12 am)
Re: [PATCH 14/16] x86: Unify CPU -> NUMA node mapping betw ..., Tejun Heo, (Fri Dec 10, 4:13 am)
Re: [PATCH 07/16] x86: Remove custom apic->cpu_to_logical_ ..., Thomas Gleixner, (Fri Dec 10, 4:18 am)
Re: [PATCH 13/16] x86: Unify cpu/apicid <-> NUMA node mapp ..., Tejun Heo, (Fri Dec 10, 1:45 pm)
Re: [PATCH 13/16] x86: Unify cpu/apicid <-> NUMA node mapp ..., Tejun Heo, (Fri Dec 10, 1:54 pm)
Re: [PATCH 13/16] x86: Unify cpu/apicid <-> NUMA node mapp ..., Yinghai Lu, (Fri Dec 10, 2:17 pm)