Home » Mailing list archives » linux-kernel » 2010 » November » 29

Re: [PATCH 3/6] perf: Add timestamp to COMM and MMAP events

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ian Munsie
Subject: Re: [PATCH 3/6] perf: Add timestamp to COMM and MMAP events
Date: Monday, November 29, 2010 - 4:45 pm

Hi Peter,

Excerpts from Peter Zijlstra's message of Mon Nov 29 22:54:50 +1100 2010:

Oh the timestamps coming from the kernel are fine, I should have been
clearer in my email. This bug is purely restricted to the userspace code
that prints them out - in the perf_session__print_tstamp function. It
tries to print the timestamps out so that they start at 0 and if it
doesn't know what CPU the events came from it uses the very first event
it sees as epoch, but at the moment that is not necessarily going to be
the earliest event.

Thinking about it overnight, I realise that this should also go away if
we sort them before printing things out at all, which is exactly what
I'm proposing to do in my patches.

Cheers,
-Ian
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
perf: Timestamp COMM and MMAP events for correct attribution, Ian Munsie, (Mon Nov 22, 10:35 pm)
[PATCH 2/6] perf: Move all output for perf report -D into ..., Ian Munsie, (Mon Nov 22, 10:35 pm)
[PATCH 3/6] perf: Add timestamp to COMM and MMAP events, Ian Munsie, (Mon Nov 22, 10:35 pm)
[PATCH 4/6] perf: Add timestamp to READ and LOST events, Ian Munsie, (Mon Nov 22, 10:35 pm)
[PATCH 5/6] perf tool: Process COMM and MMAP events in order, Ian Munsie, (Mon Nov 22, 10:35 pm)
[PATCH 6/6] perf tool: Process READ and LOST events in order, Ian Munsie, (Mon Nov 22, 10:35 pm)
Re: perf: Timestamp COMM and MMAP events for correct attri ..., Ian Munsie, (Mon Nov 22, 11:37 pm)
Re: [PATCH 3/6] perf: Add timestamp to COMM and MMAP events, Peter Zijlstra, (Tue Nov 23, 4:08 am)
Re: [PATCH 3/6] perf: Add timestamp to COMM and MMAP events, Arnaldo Carvalho de Melo, (Tue Nov 23, 5:41 am)
Re: [PATCH 3/6] perf: Add timestamp to COMM and MMAP events, Arnaldo Carvalho de Melo, (Thu Nov 25, 8:47 am)
Re: [PATCH 3/6] perf: Add timestamp to COMM and MMAP events, Arnaldo Carvalho de Melo, (Fri Nov 26, 2:54 pm)
Re: [PATCH 3/6] perf: Add timestamp to COMM and MMAP events, Ian Munsie, (Sun Nov 28, 11:06 pm)
Re: [PATCH 3/6] perf: Add timestamp to COMM and MMAP events, Peter Zijlstra, (Mon Nov 29, 4:54 am)
Re: [PATCH 3/6] perf: Add timestamp to COMM and MMAP events, Ian Munsie, (Mon Nov 29, 4:45 pm)
Re: [PATCH 3/6] perf: Add timestamp to COMM and MMAP events, Arnaldo Carvalho de Melo, (Tue Nov 30, 7:02 am)