Re: [patch 4/7] fs: preserve inode dirty bits on failed metadata writeback

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Christoph Hellwig

Subject: Re: [patch 4/7] fs: preserve inode dirty bits on failed metadata writeback

Date: Monday, November 29, 2010 - 7:59 am

On Wed, Nov 24, 2010 at 01:06:14AM +1100, npiggin@kernel.dk wrote:
quoted text> Otherwise we think the inode is clean even if syncing failed.

The patch itself looks fine, but I'm not sure it's enough.  If we do
an synchronous writeout it could fail long after ->write_inode
has returned.

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[patch 0/7] icache dirty / sync fixes, npiggin, (Tue Nov 23, 7:06 am)

[patch 1/7] fs: mark_inode_dirty barrier fix, npiggin, (Tue Nov 23, 7:06 am)

[patch 2/7] fs: simple fsync race fix, npiggin, (Tue Nov 23, 7:06 am)

[patch 3/7] fs: introduce inode writeback helpers, npiggin, (Tue Nov 23, 7:06 am)

[patch 4/7] fs: preserve inode dirty bits on failed metada ..., npiggin, (Tue Nov 23, 7:06 am)

[patch 5/7] fs: ext2 inode sync fix, npiggin, (Tue Nov 23, 7:06 am)

[patch 6/7] fs: fsync optimisations, npiggin, (Tue Nov 23, 7:06 am)

[patch 7/7] fs: fix or note I_DIRTY handling bugs in files ..., npiggin, (Tue Nov 23, 7:06 am)

Re: [patch 7/7] fs: fix or note I_DIRTY handling bugs in f ..., Dave Chinner, (Tue Nov 23, 3:51 pm)

Re: [patch 7/7] fs: fix or note I_DIRTY handling bugs in ..., Nick Piggin, (Tue Nov 23, 5:23 pm)

Re: [patch 2/7] fs: simple fsync race fix, Christoph Hellwig, (Mon Nov 29, 7:58 am)

Re: [patch 4/7] fs: preserve inode dirty bits on failed me ..., Christoph Hellwig, (Mon Nov 29, 7:59 am)

Re: [patch 6/7] fs: fsync optimisations, Christoph Hellwig, (Mon Nov 29, 8:03 am)

Re: [patch 3/7] fs: introduce inode writeback helpers, Christoph Hellwig, (Mon Nov 29, 8:13 am)

Re: [patch 4/7] fs: preserve inode dirty bits on failed me ..., Nick Piggin, (Mon Nov 29, 5:08 pm)

Re: [patch 6/7] fs: fsync optimisations, Nick Piggin