Re: [PATCH v2 1/3] deactivate invalidated pages

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Mel Gorman
Date: Monday, November 29, 2010 - 5:07 am

On Mon, Nov 29, 2010 at 12:02:55AM +0900, Minchan Kim wrote:

Why do we move active pages to the inactive list? I thought the decision was
that mapped pages are certainly in use so we they should be not affected by
fadvise(). In contrast, I see you leave inactive pages alone.


I think this is safe but the comment could be expanded to mention that
the page is locked at this point and explain how it's impossible for
PageReclaim to be set on a !PageWriteback page here.


Unnecessary whitespace change there.


Functionally, I think this will work (although I'd like a clarification
on why active pages are rotated). It'd be nice if there was a test case
for this but it's a bit of a chicken-and-egg problem :/

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH v2 1/3] deactivate invalidated pages, Minchan Kim, (Sun Nov 28, 8:02 am)
[PATCH v2 2/3] move ClearPageReclaim, Minchan Kim, (Sun Nov 28, 8:02 am)
Re: [PATCH v2 1/3] deactivate invalidated pages, Minchan Kim, (Sun Nov 28, 8:13 am)
Re: [PATCH v2 1/3] deactivate invalidated pages, Rik van Riel, (Sun Nov 28, 12:02 pm)
Re: [PATCH v2 1/3] deactivate invalidated pages, KOSAKI Motohiro, (Sun Nov 28, 5:33 pm)
Re: [PATCH v2 1/3] deactivate invalidated pages, Ben Gamari, (Sun Nov 28, 6:58 pm)
Re: [PATCH v2 1/3] deactivate invalidated pages, Minchan Kim, (Sun Nov 28, 7:13 pm)
Re: [PATCH v2 1/3] deactivate invalidated pages, KOSAKI Motohiro, (Sun Nov 28, 7:13 pm)
Re: [PATCH v2 1/3] deactivate invalidated pages, Ben Gamari, (Sun Nov 28, 7:26 pm)
Re: [PATCH v2 1/3] deactivate invalidated pages, KOSAKI Motohiro, (Sun Nov 28, 7:35 pm)
Re: [PATCH v2 2/3] move ClearPageReclaim, Rik van Riel, (Sun Nov 28, 9:25 pm)
Re: [PATCH v2 2/3] move ClearPageReclaim, Wu Fengguang, (Mon Nov 29, 12:29 am)
Re: [PATCH v2 1/3] deactivate invalidated pages, Wu Fengguang, (Mon Nov 29, 12:49 am)
Re: [PATCH v2 1/3] deactivate invalidated pages, Minchan Kim, (Mon Nov 29, 1:09 am)
Re: [PATCH v2 2/3] move ClearPageReclaim, Minchan Kim, (Mon Nov 29, 1:16 am)
Re: [PATCH v2 2/3] move ClearPageReclaim, Wu Fengguang, (Mon Nov 29, 1:26 am)
Re: [PATCH v2 1/3] deactivate invalidated pages, Mel Gorman, (Mon Nov 29, 5:07 am)
Re: [PATCH v2 1/3] deactivate invalidated pages, Minchan Kim, (Mon Nov 29, 8:28 am)