Re: [PATCH v2] add netdev led trigger

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andi Kleen
Date: Monday, November 29, 2010 - 3:15 am

Eric Cooper <ecc@cmu.edu> writes:


You should really send this to netdev too.

Some comments:

The timer seems power unfriendly -- it will always tick even if nothing 
happens.

Using the device name as an identifier is not reliable, they may 
not be unique.

rwlocks are deprecated.

your store code has a off by one I think, it's possible to put 
not 0 terminated data in the string.


-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH v2] add netdev led trigger, Eric Cooper, (Sun Nov 28, 7:34 pm)
Re: [PATCH v2] add netdev led trigger, Andi Kleen, (Mon Nov 29, 3:15 am)
Re: [PATCH v2] add netdev led trigger, Lars-Peter Clausen, (Tue Nov 30, 4:40 pm)
Re: [PATCH v2] add netdev led trigger, Eric Cooper, (Tue Nov 30, 5:03 pm)
Re: [PATCH v2] add netdev led trigger, Andi Kleen, (Wed Dec 1, 7:03 am)