[PATCH] fix endianity on ath9k_htc

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Pavel Machek
Date: Monday, November 29, 2010 - 2:58 am

It seems struct eep_header lacks proper #ifdef BIG_ENDIAN_BITFIELD
markup. eep_4k_header has proper markup, but two fields were swapped.

Signed-off-by: Pavel Machek <pma@sysgo.com>

diff --git a/drivers/net/wireless/ath/ath9k/eeprom.h b/drivers/net/wireless/ath/ath9k/eeprom.h
index 3c99830..022589d 100644
--- a/drivers/net/wireless/ath/ath9k/eeprom.h
+++ b/drivers/net/wireless/ath/ath9k/eeprom.h
@@ -378,10 +374,14 @@ struct modal_eep_header {
 	u8 xatten2Margin[AR5416_MAX_CHAINS];
 	u8 ob_ch1;
 	u8 db_ch1;
-	u8 useAnt1:1,
-	    force_xpaon:1,
-	    local_bias:1,
+#ifndef __BIG_ENDIAN_BITFIELD
+	u8 useAnt1:1, force_xpaon:1, local_bias:1,
 	    femBandSelectUsed:1, xlnabufin:1, xlnaisel:2, xlnabufmode:1;
+#else
+	u8 xlnabufmode:1, xlnaisel:2, xlnabufin:1, 
+	    femBandSelectUsed:1, local_bias:1, force_xpaon:1, useAnt1:1;
+#endif
+
 	u8 miscBits;
 	u16 xpaBiasLvlFreq[3];
 	u8 futureModal[6];
@@ -443,7 +444,7 @@ struct modal_eep_4k_header {
 	u8 antdiv_ctl1:4, ob_4:4;
 	u8 db1_3:4, db1_2:4;
 	u8 antdiv_ctl2:4, db1_4:4;
-	u8 db2_2:4, db2_3:4;
+	u8 db2_3:4, db2_2:4;
 	u8 reserved:4, db2_4:4;
 #else
 	u8 ob_2:4, ob_3:4;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
working usb wifi card, that is still possible to buy, Pavel Machek, (Wed Nov 3, 2:24 am)
Re: working usb wifi card, that is still possible to buy, Johannes Berg, (Wed Nov 24, 1:42 am)
[PATCH] ath9k_htc: cleanup eeprom endiannes handling, Pavel Machek, (Fri Nov 26, 4:35 am)
[PATCH] fix endianity on ath9k_htc, Pavel Machek, (Mon Nov 29, 2:58 am)
[PATCH] ath9k_htc cleanups, Pavel Machek, (Mon Nov 29, 2:59 am)
[PATCH] ath9k_htc more cleanups, Pavel Machek, (Mon Nov 29, 4:34 am)
Re: [ath9k-devel] [PATCH] fix endianity on ath9k_htc, Felix Fietkau, (Mon Nov 29, 4:46 am)
Re: [ath9k-devel] [PATCH] fix endianity on ath9k_htc, Pavel Machek, (Mon Nov 29, 5:07 am)
[patch] remove unneeded prototype on ath9k_htc, Pavel Machek, (Mon Nov 29, 5:11 am)