Re: How do I choose an arbitrary minor number for my tty device?

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Michael Ellerman
Date: Wednesday, November 24, 2010 - 3:44 pm

On Wed, 2010-11-24 at 10:23 -0800, Greg KH wrote:

Why? The network & wireless code uses it, so presumably it can work? If
not please consider:

commit f470f680dfaad8731f079a033a50440082e20930
Author: Michael Ellerman <michael@ellerman.id.au>
Date:   Thu Nov 25 09:41:28 2010 +1100

    driver core: Document that device_rename() is not to be used
    
    Signed-off-by: Michael Ellerman <michael@ellerman.id.au>

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 6ed6454..f1fac19 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1513,6 +1513,8 @@ EXPORT_SYMBOL_GPL(device_destroy);
  * exclusion between two different calls of device_rename
  * on the same device to ensure that new_name is valid and
  * won't conflict with other devices.
+ *
+ * "Never use this function, bad things will happen" - gregkh
  */
 int device_rename(struct device *dev, const char *new_name)
 {
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: How do I choose an arbitrary minor number for my tty d ..., Michael Ellerman, (Wed Nov 24, 3:44 pm)
Re: How do I choose an arbitrary minor number for my tty d ..., Tabi Timur-B04825, (Mon Nov 29, 9:15 pm)