[PATCH] Change return type of obvious Boolean list fns to "bool".

Previous thread: [PATCH] Fix "forcably" typo. by Robert P. J. Day on Sunday, November 21, 2010 - 6:15 am. (2 messages)

Next thread: Re: [PATCH v4] sched: automated per session task groups by Ingo Molnar on Sunday, November 21, 2010 - 6:37 am. (59 messages)
From: Robert P. J. Day
Date: Sunday, November 21, 2010 - 6:35 am

It's clear that a number of basic list routines return simply a
Boolean value, so change their return type from "int" to "bool".

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  Compile-tested with defconfig on x86_64.  Not sure who should
be CCed when a patch touches something this basic.  Andrew?


diff --git a/include/linux/list.h b/include/linux/list.h
index 9a5f8a7..1d6ed55 100644
--- a/include/linux/list.h
+++ b/include/linux/list.h
@@ -167,7 +167,7 @@ static inline void list_move_tail(struct list_head *list,
  * @list: the entry to test
  * @head: the head of the list
  */
-static inline int list_is_last(const struct list_head *list,
+static inline bool list_is_last(const struct list_head *list,
 				const struct list_head *head)
 {
 	return list->next == head;
@@ -177,7 +177,7 @@ static inline int list_is_last(const struct list_head *list,
  * list_empty - tests whether a list is empty
  * @head: the list to test.
  */
-static inline int list_empty(const struct list_head *head)
+static inline bool list_empty(const struct list_head *head)
 {
 	return head->next == head;
 }
@@ -195,7 +195,7 @@ static inline int list_empty(const struct list_head *head)
  * to the list entry is list_del_init(). Eg. it cannot be used
  * if another CPU could re-list_add() it.
  */
-static inline int list_empty_careful(const struct list_head *head)
+static inline bool list_empty_careful(const struct list_head *head)
 {
 	struct list_head *next = head->next;
 	return (next == head) && (next == head->prev);
@@ -219,7 +219,7 @@ static inline void list_rotate_left(struct list_head *head)
  * list_is_singular - tests whether a list has just one entry.
  * @head: the list to test.
  */
-static inline int list_is_singular(const struct list_head *head)
+static inline bool list_is_singular(const struct list_head *head)
 {
 	return !list_empty(head) && (head->next == head->prev);
 ...
From: Rakib Mullick
Date: Sunday, November 21, 2010 - 9:59 pm

You can use scripts/get_maintainer.pl to find out who should be cc'ed.



thanks,
rakib
--

From: Randy Dunlap
Date: Tuesday, November 23, 2010 - 12:16 pm

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>



---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--

Previous thread: [PATCH] Fix "forcably" typo. by Robert P. J. Day on Sunday, November 21, 2010 - 6:15 am. (2 messages)

Next thread: Re: [PATCH v4] sched: automated per session task groups by Ingo Molnar on Sunday, November 21, 2010 - 6:37 am. (59 messages)