Home » Mailing list archives » linux-kernel » 2010 » November » 2

[PATCH] vfio: Extended capability fixes

Previous thread: [PATCH] Add Kconfig option for default swappiness by Ben Gamari on Monday, November 1, 2010 - 8:20 pm. (14 messages)

Next thread: [PATCH] drivers/misc/apds9802als.c: fix runtime PM errors by Hong Liu on Monday, November 1, 2010 - 11:38 pm. (1 message)
[view original message]
From: Alex Williamson
Subject: [PATCH] vfio: Extended capability fixes
Date: Monday, November 1, 2010 - 10:08 pm

- Virtual channel position gets truncated as a u8
 - Print the ecap that's unknown, not the last cap we saw
 - Print actual config offset, which provides enough info to make
   some sense of the error.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

 drivers/vfio/vfio_pci_config.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/vfio/vfio_pci_config.c b/drivers/vfio/vfio_pci_config.c
index 8af995d..8304316 100644
--- a/drivers/vfio/vfio_pci_config.c
+++ b/drivers/vfio/vfio_pci_config.c
@@ -410,7 +410,7 @@ static int vfio_msi_cap_len(struct vfio_dev *vdev, u8 pos)
  * Determine extended capability length for VC (2 & 9) and
  * MFVC capabilities
  */
-static int vfio_vc_cap_len(struct vfio_dev *vdev, u8 pos)
+static int vfio_vc_cap_len(struct vfio_dev *vdev, u16 pos)
 {
 	struct pci_dev *pdev = vdev->pdev;
 	u32 dw;
@@ -580,7 +580,7 @@ int vfio_build_config_map(struct vfio_dev *vdev)
 				printk(KERN_WARNING
 					"%s: pci config conflict at %x, "
 					"caps %x %x\n",
-					__func__, i, map[pos+i], cap);
+					__func__, pos+i, map[pos+i], cap);
 			map[pos+i] = cap;
 		}
 		ret = pci_read_config_byte(pdev, pos + PCI_CAP_LIST_NEXT, &pos);
@@ -683,7 +683,7 @@ int vfio_build_config_map(struct vfio_dev *vdev)
 		if (len == 0 || len == 0xFF) {
 			printk(KERN_WARNING
 				"%s: unknown length for pci ext cap %x\n",
-				__func__, cap);
+				__func__, ecap);
 			len = PCI_CAP_SIZEOF;
 		}
 		for (i = 0; i < len; i++) {
@@ -691,7 +691,7 @@ int vfio_build_config_map(struct vfio_dev *vdev)
 				printk(KERN_WARNING
 					"%s: pci config conflict at %x, "
 					"caps %x %x\n",
-					__func__, i, map[epos+i], ecap);
+					__func__, epos+i, map[epos+i], ecap);
 			map[epos+i] = ecap;
 		}
 

--


[ message continues ]
[view original message]
From: Michael S. Tsirkin
Subject: Re: [PATCH] vfio: Extended capability fixes
Date: Tuesday, November 2, 2010 - 12:11 pm

Not related to this patch, but I am surprised checkpatch does not
complain about lack of spaces around + here and elsewhere.
--


[ message continues ]
[view original message]
From: Tom Lyon
Subject: Re: [PATCH] vfio: Extended capability fixes
Date: Tuesday, November 2, 2010 - 3:19 pm

--


[ message continues ]
[view original message]
From: Tom Lyon
Subject: Re: [PATCH] vfio: Extended capability fixes
Date: Tuesday, November 2, 2010 - 3:18 pm

Applied. Thanks!

--


[ message continues ]
Previous thread: [PATCH] Add Kconfig option for default swappiness by Ben Gamari on Monday, November 1, 2010 - 8:20 pm. (14 messages)

Next thread: [PATCH] drivers/misc/apds9802als.c: fix runtime PM errors by Hong Liu on Monday, November 1, 2010 - 11:38 pm. (1 message)