Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separate super_operation

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Mark Lord
Date: Friday, November 19, 2010 - 7:01 am

On 10-11-19 06:55 AM, Christoph Hellwig wrote:

That is my intent already, thanks.  Just needs time, perhaps this winter.

I think a reasonable approach would be to modify the existing interfaces
so that the LLD can report a "max discard ranges per command" back up
the stack.

This way, libata could report a max of say, 64 ranges per "discard" (trim),
and DM/RAID could simply (for now) report a max of one range per discard.

Way up at the FITRIM level, code could interrogate the "discard" limit
for the device holding the fs, and construct the discard commands such that
they respect that limit.  For a filesystem on DM/RAID, we would (for now)
end up with single-range discards, no change from the present.

For the much more common case of end-user SATA SSDs, though, we would
suddenly get multi-range trims working with probably very little effort.

That's the plan.  Feel free to beat me to it -- you've been working on
the I/O stack nearly as long as I have (since 1992), and I expect you
know it far better by now, too!  ;)

Cheers
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Christoph Hellwig, (Thu Nov 18, 7:29 am)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Markus Trippelsdorf, (Thu Nov 18, 12:32 pm)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Martin K. Petersen, (Thu Nov 18, 4:52 pm)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Martin K. Petersen, (Thu Nov 18, 6:49 pm)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Christoph Hellwig, (Fri Nov 19, 4:09 am)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Christoph Hellwig, (Fri Nov 19, 4:55 am)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Steven Whitehouse, (Fri Nov 19, 5:16 am)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Mark Lord, (Fri Nov 19, 7:01 am)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Christoph Hellwig, (Fri Nov 19, 7:06 am)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Christoph Hellwig, (Fri Nov 19, 7:10 am)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Christoph Hellwig, (Fri Nov 19, 7:54 am)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Christoph Hellwig, (Fri Nov 19, 7:57 am)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Christoph Hellwig, (Fri Nov 19, 8:34 am)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Christoph Hellwig, (Fri Nov 19, 8:50 am)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Christoph Hellwig, (Fri Nov 19, 8:50 am)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Christoph Hellwig, (Fri Nov 19, 9:38 am)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Valdis.Kletnieks, (Sun Nov 21, 12:07 pm)
Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separat ..., Martin K. Petersen, (Wed Nov 24, 9:23 pm)