Re: [PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level

Previous thread: [PATCH] ext4: Fix 'return 0' for error case in ext4_fill_super by Joerg Roedel on Thursday, November 18, 2010 - 2:47 pm. (3 messages)

Next thread: [PATCH] POWER: gpio-chager: Provide default name for the power_supply by Lars-Peter Clausen on Thursday, November 18, 2010 - 3:08 pm. (2 messages)
From: Sonny Rao
Date: Thursday, November 18, 2010 - 2:50 pm

Driver appears to be mistaking the permission field with default value
in the case of debug and qlge_irq_type.

Driver is also passing debug as a bitmask into netif_msg_init()
which wants a number of bits.  Ron Mercer suggests we should
change this to pass in -1 so the defaults get used instead,
which makes the default much less verbose.

Signed-off-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
---

v2: Changed debug to be -1 and updated changelog

 drivers/net/qlge/qlge_main.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
index d9a7626..66878bb 100644
--- a/drivers/net/qlge/qlge_main.c
+++ b/drivers/net/qlge/qlge_main.c
@@ -62,15 +62,15 @@ static const u32 default_msg =
 /* NETIF_MSG_PKTDATA | */
     NETIF_MSG_HW | NETIF_MSG_WOL | 0;
 
-static int debug = 0x00007fff;	/* defaults above */
-module_param(debug, int, 0);
+static int debug = -1;	/* defaults above */
+module_param(debug, int, 0664);
 MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
 
 #define MSIX_IRQ 0
 #define MSI_IRQ 1
 #define LEG_IRQ 2
 static int qlge_irq_type = MSIX_IRQ;
-module_param(qlge_irq_type, int, MSIX_IRQ);
+module_param(qlge_irq_type, int, 0664);
 MODULE_PARM_DESC(qlge_irq_type, "0 = MSI-X, 1 = MSI, 2 = Legacy.");
 
 static int qlge_mpi_coredump;
--

From: Ron Mercer
Date: Thursday, November 18, 2010 - 3:17 pm

Milton/Sonny,
Did you happen to test this to see if the log output was the same? 
--

From: Sonny Rao
Date: Thursday, November 18, 2010 - 4:12 pm

Well, I haven't tried the -1 but I suspect it is much more sane than
the 15 I had before because that was excessively verbose and I always
ended up turning it down.  I'll try it out and see.

-- 
Sonny Rao, LTC OzLabs, BML team
--

Previous thread: [PATCH] ext4: Fix 'return 0' for error case in ext4_fill_super by Joerg Roedel on Thursday, November 18, 2010 - 2:47 pm. (3 messages)

Next thread: [PATCH] POWER: gpio-chager: Provide default name for the power_supply by Lars-Peter Clausen on Thursday, November 18, 2010 - 3:08 pm. (2 messages)