Re: [RFC][PATCH v2 5/7] taskstats: Improve cumulative CPU time accounting

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Oleg Nesterov
Date: Thursday, November 18, 2010 - 10:10 am

Sorry for delay.

On 11/16, Michael Holzheu wrote:

Yes, more or less I see what this patch does (I hope ;).


Yes, I see.

But I must admit, _personally_ I am not sure this problem worth the
trouble. And, I already mentioned daemonize() case, IOW I am not sure
it is _always_ right to choose exiting_parent->parent for accounting.
To me, this can be equally confusing. A user sees the running deamon
with ppid = 1, then this daemon exits and top reports the "unrelated"
process as cpu consumer.


But once again. I am _not_ against this patch. I never know when it
comes to new features. Certainly you know better if this suits top.

What I actually meant is: dear CC list, please look at this change
and comment ;)

Oleg.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [RFC][PATCH v2 5/7] taskstats: Improve cumulative CPU ..., Martin Schwidefsky, (Mon Nov 15, 8:55 am)
Re: [RFC][PATCH v2 5/7] taskstats: Improve cumulative CPU ..., Martin Schwidefsky, (Mon Nov 15, 10:49 am)
Re: [RFC][PATCH v2 5/7] taskstats: Improve cumulative CPU ..., Martin Schwidefsky, (Mon Nov 15, 11:00 am)
Re: [RFC][PATCH v2 5/7] taskstats: Improve cumulative CPU ..., Martin Schwidefsky, (Tue Nov 16, 1:54 am)
Re: [RFC][PATCH v2 5/7] taskstats: Improve cumulative CPU ..., Michael Holzheu, (Tue Nov 16, 10:34 am)
Re: [RFC][PATCH v2 5/7] taskstats: Improve cumulative CPU ..., Oleg Nesterov, (Thu Nov 18, 10:10 am)
Re: [RFC][PATCH v2 5/7] taskstats: Improve cumulative CPU ..., Michael Holzheu, (Fri Nov 19, 12:46 pm)