Re: [PATCH v6] usb: Adding SuperSpeed support to dummy_hcd

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg KH
Date: Thursday, November 18, 2010 - 8:55 am

On Thu, Nov 18, 2010 at 02:57:32PM +0200, Tatyana Brokhman wrote:

{sigh}

This changelog entry makes absolutely no sense.  Please write something
that describes what you are doing, and why you are doing it, with full
details (i.e. links to the tests you ran, etc.)  Look at how other
people write their comments for major patches like this, be descriptive
and verbose.  It will help when in 3 years you are asked why this patch
did what it did.

I'm sorry if it feels like I'm picking on you, but I'm trying to help
you get it right for this, and future contributions.

thanks,

greg k-h
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH v6] usb: Adding SuperSpeed support to dummy_hcd, Tatyana Brokhman, (Thu Nov 18, 5:57 am)
Re: [PATCH v6] usb: Adding SuperSpeed support to dummy_hcd, Greg KH, (Thu Nov 18, 8:55 am)