Re: [PATCH 4/6] Ext4: fail if we try to use hole punch

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ted Ts'o
Date: Tuesday, November 16, 2010 - 8:06 pm

> >There is no simple way to test if a filesystem supports hole punching or not so

No, it couldn't be in super_operations.  It may vary on a per-inode
basis for some file systems, such as ext4 (depending on whether the
inode is extent-mapped or indirect-block mapped).

So at least for ext4 we'd need to call into fallocate() function
anyway, once we add support.  I suppose if other file systems really
want it, we could add a flag to the super block ops structure, so they
don't have do the "do we support the punch" operation.  I can go
either way on that; although if we think the majority of file systems
are going support punch in the long-term, then it might not be worth
it to add such a flag.

						- Ted
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Hole Punching V2, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 5/6] Btrfs: fail if we try to use hole punch, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 6/6] Gfs2: fail if we try to use hole punch, Josef Bacik, (Mon Nov 15, 10:05 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Tue Nov 16, 5:50 am)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Tue Nov 16, 5:52 am)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Tue Nov 16, 5:53 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Tue Nov 16, 9:05 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Pádraig Brady, (Tue Nov 16, 9:20 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Tue Nov 16, 9:33 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Pádraig Brady, (Tue Nov 16, 9:56 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Greg Freemyer, (Tue Nov 16, 1:47 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Andreas Dilger, (Tue Nov 16, 5:22 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Dave Chinner, (Tue Nov 16, 7:11 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Tue Nov 16, 7:28 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Tue Nov 16, 7:34 pm)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Ted Ts'o, (Tue Nov 16, 8:06 pm)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Tue Nov 16, 11:31 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Andreas Dilger, (Wed Nov 17, 2:19 am)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Andreas Dilger, (Wed Nov 17, 2:30 am)