login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
November
»
15
Re: [PATCH 07/11] drivers/net/vxge/vxge-main.c: Remove unnecessary casts of pci_get_drvdata
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Jon Mason
Subject:
Re: [PATCH 07/11] drivers/net/vxge/vxge-main.c: Remove unnecessary casts of pci_get_drvdata
Date: Monday, November 15, 2010 - 3:50 pm
On Mon, Nov 15, 2010 at 12:13:58PM -0800, Joe Perches wrote:
quoted text
> Signed-off-by: Joe Perches <joe@perches.com>
Looks good to me. Acked-by: Jon Mason <jon.mason@exar.com>
quoted text
> --- > drivers/net/vxge/vxge-main.c | 28 ++++++++++++---------------- > 1 files changed, 12 insertions(+), 16 deletions(-) > > diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c > index 3f2d6ed..22c7d79 100644 > --- a/drivers/net/vxge/vxge-main.c > +++ b/drivers/net/vxge/vxge-main.c > @@ -688,7 +688,7 @@ static int vxge_learn_mac(struct vxgedev *vdev, u8 *mac_header) > struct vxge_vpath *vpath = NULL; > struct __vxge_hw_device *hldev; > > - hldev = (struct __vxge_hw_device *)pci_get_drvdata(vdev->pdev); > + hldev = pci_get_drvdata(vdev->pdev); > > mac_address = (u8 *)&mac_addr; > memcpy(mac_address, mac_header, ETH_ALEN); > @@ -1313,7 +1313,7 @@ static void vxge_vpath_intr_disable(struct vxgedev *vdev, int vp_id) > struct __vxge_hw_device *hldev; > int msix_id; > > - hldev = (struct __vxge_hw_device *)pci_get_drvdata(vdev->pdev); > + hldev = pci_get_drvdata(vdev->pdev); > > vxge_hw_vpath_wait_receive_idle(hldev, vpath->device_id); > > @@ -1632,8 +1632,7 @@ static int vxge_poll_inta(struct napi_struct *napi, int budget) > int budget_org = budget; > struct vxge_ring *ring; > > - struct __vxge_hw_device *hldev = (struct __vxge_hw_device *) > - pci_get_drvdata(vdev->pdev); > + struct __vxge_hw_device *hldev = pci_get_drvdata(vdev->pdev); > > for (i = 0; i < vdev->no_of_vpath; i++) { > ring = &vdev->vpaths[i].ring; > @@ -1673,7 +1672,7 @@ static void vxge_netpoll(struct net_device *dev) > struct vxgedev *vdev; > > vdev = (struct vxgedev *)netdev_priv(dev); > - hldev = (struct __vxge_hw_device *)pci_get_drvdata(vdev->pdev); > + hldev = pci_get_drvdata(vdev->pdev); > > vxge_debug_entryexit(VXGE_TRACE, "%s:%d", __func__, __LINE__); > > @@ -2107,7 +2106,7 @@ static irqreturn_t vxge_isr_napi(int irq, void *dev_id) > vxge_debug_intr(VXGE_TRACE, "%s:%d", __func__, __LINE__); > > dev = vdev->ndev; > - hldev = (struct __vxge_hw_device *)pci_get_drvdata(vdev->pdev); > + hldev = pci_get_drvdata(vdev->pdev); > > if (pci_channel_offline(vdev->pdev)) > return IRQ_NONE; > @@ -2342,7 +2341,7 @@ static void vxge_rem_msix_isr(struct vxgedev *vdev) > static void vxge_rem_isr(struct vxgedev *vdev) > { > struct __vxge_hw_device *hldev; > - hldev = (struct __vxge_hw_device *)pci_get_drvdata(vdev->pdev); > + hldev = pci_get_drvdata(vdev->pdev); > > #ifdef CONFIG_PCI_MSI > if (vdev->config.intr_type == MSI_X) { > @@ -2583,7 +2582,7 @@ vxge_open(struct net_device *dev) > "%s: %s:%d", dev->name, __func__, __LINE__); > > vdev = (struct vxgedev *)netdev_priv(dev); > - hldev = (struct __vxge_hw_device *)pci_get_drvdata(vdev->pdev); > + hldev = pci_get_drvdata(vdev->pdev); > function_mode = vdev->config.device_hw_info.function_mode; > > /* make sure you have link off by default every time Nic is > @@ -2811,7 +2810,7 @@ static int do_vxge_close(struct net_device *dev, int do_io) > dev->name, __func__, __LINE__); > > vdev = (struct vxgedev *)netdev_priv(dev); > - hldev = (struct __vxge_hw_device *)pci_get_drvdata(vdev->pdev); > + hldev = pci_get_drvdata(vdev->pdev); > > if (unlikely(!is_vxge_card_up(vdev))) > return 0; > @@ -3985,8 +3984,7 @@ static int vxge_pm_resume(struct pci_dev *pdev) > static pci_ers_result_t vxge_io_error_detected(struct pci_dev *pdev, > pci_channel_state_t state) > { > - struct __vxge_hw_device *hldev = > - (struct __vxge_hw_device *)pci_get_drvdata(pdev); > + struct __vxge_hw_device *hldev = pci_get_drvdata(pdev); > struct net_device *netdev = hldev->ndev; > > netif_device_detach(netdev); > @@ -4015,8 +4013,7 @@ static pci_ers_result_t vxge_io_error_detected(struct pci_dev *pdev, > */ > static pci_ers_result_t vxge_io_slot_reset(struct pci_dev *pdev) > { > - struct __vxge_hw_device *hldev = > - (struct __vxge_hw_device *)pci_get_drvdata(pdev); > + struct __vxge_hw_device *hldev = pci_get_drvdata(pdev); > struct net_device *netdev = hldev->ndev; > > struct vxgedev *vdev = netdev_priv(netdev); > @@ -4041,8 +4038,7 @@ static pci_ers_result_t vxge_io_slot_reset(struct pci_dev *pdev) > */ > static void vxge_io_resume(struct pci_dev *pdev) > { > - struct __vxge_hw_device *hldev = > - (struct __vxge_hw_device *)pci_get_drvdata(pdev); > + struct __vxge_hw_device *hldev = pci_get_drvdata(pdev); > struct net_device *netdev = hldev->ndev; > > if (netif_running(netdev)) { > @@ -4689,7 +4685,7 @@ static void __devexit vxge_remove(struct pci_dev *pdev) > struct net_device *dev; > int i = 0; > > - hldev = (struct __vxge_hw_device *)pci_get_drvdata(pdev); > + hldev = pci_get_drvdata(pdev); > > if (hldev == NULL) > return; > -- > 1.7.3.1.g432b3.dirty >
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 07/11] drivers/net/vxge/vxge-main.c: Remove unneces ...
, Joe Perches
, (Mon Nov 15, 1:13 pm)
Re: [PATCH 07/11] drivers/net/vxge/vxge-main.c: Remove unn ...
, Jon Mason
, (Mon Nov 15, 3:50 pm)
Re: [PATCH 07/11] drivers/net/vxge/vxge-main.c: Remove unn ...
, David Miller
, (Wed Nov 17, 1:28 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Paul Turner
[tg_shares_up rewrite v4 11/11] sched: update tg->shares after cpu.shares write
Mr. James W. Laferriere
Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'
Linus Torvalds
Linux 2.6.34-rc4
Colin Cross
[PATCH 12/21] ARM: tegra: Add suspend and hotplug support
Chuck Ebbert
Re: PCI: Unable to reserve mem region problem
git
:
Fredrik Kuivinen
Re: fatal: unable to create '.git/index': File exists
Wink Saville
How-to combine several separate git repos?
Emily Ren
How to pull remote branch with specified commit id?
Denis Bueno
Git clone error
pradeep singh
git-update-server-info may be required,cannot clone and pull from a remote reposit...
linux-netdev
:
Jamie Lokier
Re: POHMELFS high performance network filesystem. Transactions, failover, performa...
Timo Teräs
ip xfrm policy semantics
Jarek Poplawski
Re: socket api problem: can't bind an ipv6 socket to ::ffff:0.0.0.0
Michael S. Tsirkin
[PATCH 3/3] vhost: fix get_user_pages_fast error handling
Jeff Garzik
Re: [0/3] POHMELFS high performance network filesystem. First steps in parallel pr...
openbsd-misc
:
Sevan / Venture37
Re: This is what Linus Torvalds calls openBSD crowd
Netmaffia.hu
Tini Lányok AKCIÓBAN OTTHON
Siju George
This is what Linus Torvalds calls openBSD crowd
Darrin Chandler
Re: OT: Python (was Re: vi in /bin)
frantisek holop
Re: splassert: vwakeup: and friends
git-commits-head
:
Linux Kernel Mailing List
ASoC: fix registration of the SoC card in the Freescale MPC8610 drivers
Linux Kernel Mailing List
drivers/acpi: use kasprintf
Linux Kernel Mailing List
powerpc/fsl_msi: enable msi allocation in all banks
Linux Kernel Mailing List
bnx2x: Moving includes
Linux Kernel Mailing List
nfsd41: sanity check client drc maxreqs
Colocation donated by:
Syndicate