login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
November
»
15
Re: [PATCH 1/1] net: rtnetlink.h -- only include linux/netdevice.h when used by the kernel
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: David Miller
Subject:
Re: [PATCH 1/1] net: rtnetlink.h -- only include linux/netdevice.h when used by the kernel
Date: Monday, November 15, 2010 - 12:30 pm
From: Andy Whitcroft <apw@canonical.com> Date: Mon, 15 Nov 2010 16:01:59 +0000
quoted text
> The commit below added a new helper dev_ingress_queue to cleanly obtain the > ingress queue pointer. This necessitated including 'linux/netdevice.h':
...
quoted text
> However this include triggers issues for applications in userspace > which use the rtnetlink interfaces. Commonly this requires they include > 'net/if.h' and 'linux/rtnetlink.h' leading to a compiler error as below: > > In file included from /usr/include/linux/netdevice.h:28:0, > from /usr/include/linux/rtnetlink.h:9, > from t.c:2: > /usr/include/linux/if.h:135:8: error: redefinition of ‘struct ifmap’ > /usr/include/net/if.h:112:8: note: originally defined here > /usr/include/linux/if.h:169:8: error: redefinition of ‘struct ifreq’ > /usr/include/net/if.h:127:8: note: originally defined here > /usr/include/linux/if.h:218:8: error: redefinition of ‘struct ifconf’ > /usr/include/net/if.h:177:8: note: originally defined here > > The new helper is only defined for the kernel and protected by __KERNEL__ > therefore we can simply pull the include down into the same protected > section. > > Signed-off-by: Andy Whitcroft <apw@canonical.com>
Applied, thanks Andy.
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH 1/1] net: rtnetlink.h -- only include linux/netdevi ...
, Andy Whitcroft
, (Mon Nov 15, 9:01 am)
Re: [PATCH 1/1] net: rtnetlink.h -- only include linux/net ...
, David Miller
, (Mon Nov 15, 12:30 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Paul Turner
[tg_shares_up rewrite v4 11/11] sched: update tg->shares after cpu.shares write
Mr. James W. Laferriere
Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'
Linus Torvalds
Linux 2.6.34-rc4
Colin Cross
[PATCH 12/21] ARM: tegra: Add suspend and hotplug support
Chuck Ebbert
Re: PCI: Unable to reserve mem region problem
git
:
Fredrik Kuivinen
Re: fatal: unable to create '.git/index': File exists
Wink Saville
How-to combine several separate git repos?
Emily Ren
How to pull remote branch with specified commit id?
Denis Bueno
Git clone error
pradeep singh
git-update-server-info may be required,cannot clone and pull from a remote reposit...
linux-netdev
:
Jamie Lokier
Re: POHMELFS high performance network filesystem. Transactions, failover, performa...
Timo Teräs
ip xfrm policy semantics
Jarek Poplawski
Re: socket api problem: can't bind an ipv6 socket to ::ffff:0.0.0.0
Michael S. Tsirkin
[PATCH 3/3] vhost: fix get_user_pages_fast error handling
Jeff Garzik
Re: [0/3] POHMELFS high performance network filesystem. First steps in parallel pr...
openbsd-misc
:
Sevan / Venture37
Re: This is what Linus Torvalds calls openBSD crowd
Netmaffia.hu
Tini Lányok AKCIÓBAN OTTHON
Siju George
This is what Linus Torvalds calls openBSD crowd
Darrin Chandler
Re: OT: Python (was Re: vi in /bin)
frantisek holop
Re: splassert: vwakeup: and friends
git-commits-head
:
Linux Kernel Mailing List
ASoC: fix registration of the SoC card in the Freescale MPC8610 drivers
Linux Kernel Mailing List
drivers/acpi: use kasprintf
Linux Kernel Mailing List
powerpc/fsl_msi: enable msi allocation in all banks
Linux Kernel Mailing List
bnx2x: Moving includes
Linux Kernel Mailing List
nfsd41: sanity check client drc maxreqs
Colocation donated by:
Syndicate