Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ?

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Monday, November 15, 2010 - 12:21 pm

On Mon, Nov 15, 2010 at 11:12 AM, Jakub Jelinek <jakub@redhat.com> wrote:

Ok. And I guess you can verify that all versions of gcc do this
correctly for "asm volatile"?

Because since we'll have to work around this problem in the kernel, I
suspect the simplest solution is to remove the "+m" that causes
register pressure problems, and then use "asm volatile" to work around
the const-function bug.

And add a large comment about why "asm volatile" is probably always a
good idea when you have a memory clobber and don't have any other
visible memory modifications.

I do wonder if this explains some of the problems we had with the
bitop asms too.

Hmm?

                       Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] i8k: Tell gcc that *regs gets clobbered, Jim Bos, (Sat Nov 13, 4:13 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Linus Torvalds, (Mon Nov 15, 12:21 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Richard Henderson, (Mon Nov 15, 12:53 pm)