[PATCH 4/6] Ext4: fail if we try to use hole punch

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Josef Bacik
Date: Monday, November 15, 2010 - 10:05 am

Ext4 doesn't have the ability to punch holes yet, so make sure we return
EOPNOTSUPP if we try to use hole punching through fallocate.  This support can
be added later.  Thanks,

Signed-off-by: Josef Bacik <josef@redhat.com>
---
 fs/ext4/extents.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 0554c48..35bca73 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len)
 	struct ext4_map_blocks map;
 	unsigned int credits, blkbits = inode->i_blkbits;
 
+	/* We only support the FALLOC_FL_KEEP_SIZE mode */
+	if (mode && (mode != FALLOC_FL_KEEP_SIZE))
+		return -EOPNOTSUPP;
+
 	/*
 	 * currently supporting (pre)allocate mode for extent-based
 	 * files _only_
-- 
1.6.6.1

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Hole Punching V2, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 5/6] Btrfs: fail if we try to use hole punch, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 6/6] Gfs2: fail if we try to use hole punch, Josef Bacik, (Mon Nov 15, 10:05 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Tue Nov 16, 5:50 am)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Tue Nov 16, 5:52 am)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Tue Nov 16, 5:53 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Tue Nov 16, 9:05 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Pádraig Brady, (Tue Nov 16, 9:20 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Tue Nov 16, 9:33 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Pádraig Brady, (Tue Nov 16, 9:56 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Greg Freemyer, (Tue Nov 16, 1:47 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Andreas Dilger, (Tue Nov 16, 5:22 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Dave Chinner, (Tue Nov 16, 7:11 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Tue Nov 16, 7:28 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Tue Nov 16, 7:34 pm)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Tue Nov 16, 11:31 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Andreas Dilger, (Wed Nov 17, 2:19 am)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Andreas Dilger, (Wed Nov 17, 2:30 am)