Re: [RFC 0/4]x86: allocate up to 32 tlb invalidate vectors

Previous thread: [regression, 2.6.37-rc1] 'ip link tap0 up' stuck in do_exit() by Dave Chinner on Tuesday, November 2, 2010 - 11:26 pm. (13 messages)

Next thread: [RFC 1/4]x86: cleanup vector usage by Shaohua Li on Tuesday, November 2, 2010 - 11:44 pm. (4 messages)
From: Shaohua Li
Date: Tuesday, November 2, 2010 - 11:44 pm

Hi,
In workload with heavy page reclaim, flush_tlb_page() is frequently
used. We currently have 8 vectors for tlb flush, which is fine for small
machines. But for big machines with a lot of CPUs, the 8 vectors are
shared by all CPUs and we need lock to protect them. This will cause a
lot of lock contentions. please see the patch 3 for detailed number of
the lock contention.
Andi Kleen suggests we can use 32 vectors for tlb flush, which should be
fine for even 8 socket machines. Test shows this reduces lock contention
dramatically (see patch 3 for number).
One might argue if this will waste too many vectors and leave less
vectors for devices. This could be a problem. But even we use 32
vectors, we still leave 78 vectors for devices. And we now have per-cpu
vector, vector isn't scarce any more, but I'm open if anybody has
objections.

Thanks,
Shaohua

--

From: Shaohua Li
Date: Monday, November 15, 2010 - 7:02 am

Hi Ingo & hpa, any comments about this series?

Thanks,
Shaohua

--

From: H. Peter Anvin
Date: Monday, November 15, 2010 - 10:53 am

Hi Shaohua,

It looks good... I need to do a more thorough review and put it in; I
just have been consumed a bit too much by a certain internal project.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--

Previous thread: [regression, 2.6.37-rc1] 'ip link tap0 up' stuck in do_exit() by Dave Chinner on Tuesday, November 2, 2010 - 11:26 pm. (13 messages)

Next thread: [RFC 1/4]x86: cleanup vector usage by Shaohua Li on Tuesday, November 2, 2010 - 11:44 pm. (4 messages)