Home » Mailing list archives » linux-kernel » 2010 » November » 13

[PATCH] i8k: Tell gcc that *regs gets clobbered

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jim Bos
Subject: [PATCH] i8k: Tell gcc that *regs gets clobbered
Date: Saturday, November 13, 2010 - 4:13 am

More recent GCC caused the i8k driver to stop working, on Slackware
compiler was upgraded from gcc-4.4.4 to gcc-4.5.1 after which it
didn't work anymore, meaning the driver didn't load or gave total
nonsensical output.
As it turned out the asm(..) statement forgot to mention it modifies
the *regs variable.
Credits to Andi Kleen <andi@firstfloor.org> and Andreas Schwab
<schwab@linux-m68k.org> for providing the fix.

Signed-off-by: Jim Bos <jim876@xs4all.nl>
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ?, Jim, (Sat Nov 6, 4:15 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char ..., Andi Kleen, (Sun Nov 7, 2:31 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char ..., Andreas Schwab, (Sun Nov 7, 3:41 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char ..., Andi Kleen, (Sun Nov 7, 4:03 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Richard Guenther, (Mon Nov 8, 3:49 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Andi Kleen, (Mon Nov 8, 4:20 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Richard Guenther, (Mon Nov 8, 4:20 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Paul Koning, (Mon Nov 8, 4:47 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jakub Jelinek, (Mon Nov 8, 4:53 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Michael Matz, (Mon Nov 8, 5:20 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Dave Korn, (Mon Nov 8, 11:39 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Michael Matz, (Tue Nov 9, 6:00 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Andi Kleen, (Tue Nov 9, 6:48 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Andreas Schwab, (Tue Nov 9, 6:57 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jim, (Tue Nov 9, 9:43 am)
[PATCH] i8k: Tell gcc that *regs gets clobbered, Jim Bos, (Sat Nov 13, 4:13 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., James Cloos, (Sun Nov 14, 5:52 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Linus Torvalds, (Sun Nov 14, 8:21 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jakub Jelinek, (Mon Nov 15, 1:56 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Andi Kleen, (Mon Nov 15, 2:12 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jakub Jelinek, (Mon Nov 15, 2:20 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jakub Jelinek, (Mon Nov 15, 3:03 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Richard Guenther, (Mon Nov 15, 3:24 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Andi Kleen, (Mon Nov 15, 3:54 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jakub Jelinek, (Mon Nov 15, 4:16 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Andi Kleen, (Mon Nov 15, 4:37 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Linus Torvalds, (Mon Nov 15, 9:04 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jim Bos, (Mon Nov 15, 10:36 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jim Bos, (Mon Nov 15, 10:40 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jakub Jelinek, (Mon Nov 15, 10:44 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Linus Torvalds, (Mon Nov 15, 11:08 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jim Bos, (Mon Nov 15, 11:17 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jakub Jelinek, (Mon Nov 15, 11:26 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jim Bos, (Mon Nov 15, 11:30 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jim Bos, (Mon Nov 15, 11:37 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char ..., Jeff Law, (Mon Nov 15, 11:42 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jeff Law, (Mon Nov 15, 11:45 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Linus Torvalds, (Mon Nov 15, 11:56 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jakub Jelinek, (Mon Nov 15, 11:58 am)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Linus Torvalds, (Mon Nov 15, 12:04 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jim Bos, (Mon Nov 15, 12:10 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jakub Jelinek, (Mon Nov 15, 12:12 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Linus Torvalds, (Mon Nov 15, 12:21 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jakub Jelinek, (Mon Nov 15, 12:51 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Richard Henderson, (Mon Nov 15, 12:53 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jim Bos, (Mon Nov 15, 1:22 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Richard Guenther, (Mon Nov 15, 3:07 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Andi Kleen, (Mon Nov 15, 3:43 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jakub Jelinek, (Mon Nov 15, 3:46 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jeff Law, (Mon Nov 15, 3:58 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Richard Guenther, (Mon Nov 15, 4:07 pm)
Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/ ..., Jeff Law, (Mon Nov 15, 9:10 pm)