login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
November
»
12
Re: [PATCH] trace-view: Handle unknown events more gracefully
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Jan Kiszka
Subject:
Re: [PATCH] trace-view: Handle unknown events more gracefully
Date: Friday, November 12, 2010 - 1:04 am
Am 14.10.2010 21:23, Jan Kiszka wrote:
quoted text
> Kernel 2.6.35.7 generates invalid trace files due to > /sys/kernel/debug/tracing/events/scsi/scsi_dispatch_cmd_timeout/format > returning "FORMAT TOO BIG" (seems to be fixed in 2.6.36). This makes > pevent_data_event_from_type return NULL, and dereferencing of event > crashes the viewer. > > Catch and report the error properly.
Ping... Jan
quoted text
> > Signed-off-by: Jan Kiszka <jan.kiszka@web.de> > --- > trace-view-store.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/trace-view-store.c b/trace-view-store.c > index 0834df7..34f8155 100644 > --- a/trace-view-store.c > +++ b/trace-view-store.c > @@ -507,12 +507,17 @@ trace_view_store_get_value (GtkTreeModel *tree_model, > case TRACE_VIEW_STORE_COL_INFO: > val = pevent_data_type(pevent, data); > event = pevent_data_event_from_type(pevent, val); > + if (!event) { > + if (column == TRACE_VIEW_STORE_COL_EVENT) > + g_value_set_string(value, "[UNKNOWN EVENT]"); > + break; > + } > + > if (column == TRACE_VIEW_STORE_COL_EVENT) { > g_value_set_string(value, event->name); > break; > } > > - > trace_seq_init(&s); > pevent_event_info(&s, event, data); > g_value_set_string(value, s.buffer);
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] trace-view: Handle unknown events more gracefully
, Jan Kiszka
, (Thu Oct 14, 12:23 pm)
Re: [PATCH] trace-view: Handle unknown events more gracefully
, Jan Kiszka
, (Fri Nov 12, 1:04 am)
Re: [PATCH] trace-view: Handle unknown events more gracefully
, Steven Rostedt
, (Fri Nov 12, 4:55 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Paul Turner
[tg_shares_up rewrite v4 11/11] sched: update tg->shares after cpu.shares write
Mr. James W. Laferriere
Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'
Chuck Ebbert
Re: PCI: Unable to reserve mem region problem
Linus Torvalds
Linux 2.6.34-rc4
Mingming Cao
Re: [RFC 1/4] Large Blocksize support for Ext2/3/4
git
:
Ralf Wildenhues
[PATCH] Fix typos in the documentation
Len Brown
Re: fatal: unable to create '.git/index': File exists
Adeodato
Bazaar's patience diff as GIT_EXTERNAL_DIFF
Denis Bueno
Git clone error
Johannes Schindelin
Re: [PATCH 2/4] Add functions get_relative_cwd() and is_inside_dir()
git-commits-head
:
Linux Kernel Mailing List
ASoC: fix registration of the SoC card in the Freescale MPC8610 drivers
Linux Kernel Mailing List
drivers/acpi: use kasprintf
Linux Kernel Mailing List
nfsd41: sanity check client drc maxreqs
Linux Kernel Mailing List
bnx2x: Moving includes
Linux Kernel Mailing List
V4L/DVB: gspca - sonixj: Adjust minor values of sensor ov7630. - set the color ga...
openbsd-misc
:
Sevan / Venture37
Re: This is what Linus Torvalds calls openBSD crowd
Netmaffia.hu
Tini Lányok AKCIÓBAN OTTHON
Sam Fourman Jr.
Re: Help with Altell PC6700
Siju George
This is what Linus Torvalds calls openBSD crowd
Darrin Chandler
Re: OT: Python (was Re: vi in /bin)
linux-netdev
:
Kurt Van Dijck
Re: [PATCH net-next-2.6 1/2] can: add driver for Softing card
Eric Dumazet
Re: [PATCH net-next-2.6] net: Introduce skb_orphan_try()
Jamie Lokier
Re: POHMELFS high performance network filesystem. Transactions, failover, performa...
Jarek Poplawski
Re: socket api problem: can't bind an ipv6 socket to ::ffff:0.0.0.0
David Miller
Re: [PATCH v2] net: typos in comments in include/linux/igmp.h
Colocation donated by:
Syndicate