On Thu, 2010-11-11 at 19:48 +0000, David Howells wrote:
quoted text
> Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> 
> > Reviewd-by: Mimi Zohar <zohar@watson.ibm.com>
> 
> You've missed an 'e'.

thanks, will fix

quoted text
> > +int tpm_send(u32 chip_num, char *cmd, int buflen)
> > +{
> > ...
> > +	rc = transmit_cmd(chip, (struct tpm_cmd_t *)cmd, buflen,
> > +			  "attempting tpm_cmd");
> 
> Make cmd 'void *' to obviate the cast.  Preferably it should be const too.

will do

quoted text
> > +	module_put(chip->dev->driver->owner);
> 
> Where's the corresponding module_get()?  I suspect this should be wrapped to
> match tpm_chip_find_get().
> 
> David

The module_get() is in tpm_chip_find_get(), which is just a helper.
(It's used this way throughout tpm.c)

thanks,

Mimi

--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/