login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
November
»
11
Re: [PATCH] input: bcm5974: Add support for MacBookAir3
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Dmitry Torokhov
Subject:
Re: [PATCH] input: bcm5974: Add support for MacBookAir3
Date: Thursday, November 11, 2010 - 1:39 am
On Tue, Nov 09, 2010 at 05:38:42PM +0100, Henrik Rydberg wrote:
quoted text
> From: Edgar (gimli) Hucek <gimli@dark-green.com> > > This patch adds support for the MacBookAir3,1 and MacBookAir3,2 > models. > > [rydberg@euromail.se: touchpad range calibration] > Cc:
stable@kernel.org
> Signed-off-by: Edgar (gimli) Hucek <gimli@dark-green.com> > Signed-off-by: Henrik Rydberg <rydberg@euromail.se> > --- > Hi Dmitry, Jiri, > > This patch was seen on lkml last week, and has now been excercised by > a larger set of users. As usual, this patch should go before or > together with the HID changes, so as not to break basic support from > the non-MT HID driver. >
Jiri, It looks like HID changes are more than simply adding USB device IDs so it woudl make sense to merge through your tree, Thanks.
quoted text
> Cheers, > Henrik > > drivers/input/mouse/bcm5974.c | 40 ++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 40 insertions(+), 0 deletions(-) > > diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c > index b952317..ee82851 100644 > --- a/drivers/input/mouse/bcm5974.c > +++ b/drivers/input/mouse/bcm5974.c > @@ -55,6 +55,14 @@ > #define USB_DEVICE_ID_APPLE_WELLSPRING3_ANSI 0x0236 > #define USB_DEVICE_ID_APPLE_WELLSPRING3_ISO 0x0237 > #define USB_DEVICE_ID_APPLE_WELLSPRING3_JIS 0x0238 > +/* MacbookAir3,2 (unibody), aka wellspring5 */ > +#define USB_DEVICE_ID_APPLE_WELLSPRING4_ANSI 0x023f > +#define USB_DEVICE_ID_APPLE_WELLSPRING4_ISO 0x0240 > +#define USB_DEVICE_ID_APPLE_WELLSPRING4_JIS 0x0241 > +/* MacbookAir3,1 (unibody), aka wellspring4 */ > +#define USB_DEVICE_ID_APPLE_WELLSPRING4A_ANSI 0x0242 > +#define USB_DEVICE_ID_APPLE_WELLSPRING4A_ISO 0x0243 > +#define USB_DEVICE_ID_APPLE_WELLSPRING4A_JIS 0x0244 > > #define BCM5974_DEVICE(prod) { \ > .match_flags = (USB_DEVICE_ID_MATCH_DEVICE | \ > @@ -80,6 +88,14 @@ static const struct usb_device_id bcm5974_table[] = { > BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING3_ANSI), > BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING3_ISO), > BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING3_JIS), > + /* MacbookAir3,2 */ > + BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING4_ANSI), > + BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING4_ISO), > + BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING4_JIS), > + /* MacbookAir3,1 */ > + BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING4A_ANSI), > + BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING4A_ISO), > + BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING4A_JIS), > /* Terminating entry */ > {} > }; > @@ -234,6 +250,30 @@ static const struct bcm5974_config bcm5974_config_table[] = { > { DIM_X, DIM_X / SN_COORD, -4460, 5166 }, > { DIM_Y, DIM_Y / SN_COORD, -75, 6700 } > }, > + { > + USB_DEVICE_ID_APPLE_WELLSPRING4_ANSI, > + USB_DEVICE_ID_APPLE_WELLSPRING4_ISO, > + USB_DEVICE_ID_APPLE_WELLSPRING4_JIS, > + HAS_INTEGRATED_BUTTON, > + 0x84, sizeof(struct bt_data), > + 0x81, TYPE2, FINGER_TYPE2, FINGER_TYPE2 + SIZEOF_ALL_FINGERS, > + { DIM_PRESSURE, DIM_PRESSURE / SN_PRESSURE, 0, 300 }, > + { DIM_WIDTH, DIM_WIDTH / SN_WIDTH, 0, 2048 }, > + { DIM_X, DIM_X / SN_COORD, -4620, 5140 }, > + { DIM_Y, DIM_Y / SN_COORD, -150, 6600 } > + }, > + { > + USB_DEVICE_ID_APPLE_WELLSPRING4A_ANSI, > + USB_DEVICE_ID_APPLE_WELLSPRING4A_ISO, > + USB_DEVICE_ID_APPLE_WELLSPRING4A_JIS, > + HAS_INTEGRATED_BUTTON, > + 0x84, sizeof(struct bt_data), > + 0x81, TYPE2, FINGER_TYPE2, FINGER_TYPE2 + SIZEOF_ALL_FINGERS, > + { DIM_PRESSURE, DIM_PRESSURE / SN_PRESSURE, 0, 300 }, > + { DIM_WIDTH, DIM_WIDTH / SN_WIDTH, 0, 2048 }, > + { DIM_X, DIM_X / SN_COORD, -4616, 5112 }, > + { DIM_Y, DIM_Y / SN_COORD, -142, 5234 } > + }, > {} > }; > > -- > 1.7.1 >
-- Dmitry --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] input: bcm5974: Add support for MacBookAir3
, Henrik Rydberg
, (Tue Nov 9, 9:38 am)
Re: [PATCH] input: bcm5974: Add support for MacBookAir3
, Dmitry Torokhov
, (Thu Nov 11, 1:39 am)
Re: [PATCH] input: bcm5974: Add support for MacBookAir3
, Jiri Kosina
, (Mon Nov 15, 6:18 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Fortier,Vincent [Montreal]
2.6.21.5 june 30th to july 1st date hang?
Jeff Dike
[ PATCH 2/6 ] UML - Formatting fixes around os_{read_write}_file callers
Liam Girdwood
[PATCH 07/13] regulator: regulator test harness
Oleg Nesterov
Re: Getting the new RxRPC patches upstream
Stefan Seyfried
Re: 2.6.19-rc5: grub is much slower resuming from suspend-to-disk than in 2.6.18
linux-netdev
:
Arnaud Ebalard
Re: [REGRESSION,BISECTED] MIPv6 support broken by f4f914b58019f0
Jan Engelhardt
Re: [PATCH iptables] extension: add xt_cpu match
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Sebastian Andrzej Siewior
[PATCH 8/8] net/emergency: remove locking from reycling pool if emergncy pools are...
David Miller
Re: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2
git
:
Jakub Narebski
Re: git on MacOSX and files with decomposed utf-8 file names
Brandon Casey
Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the def...
Christian Couder
[PATCH 1/3] rev-parse: add test script for "--verify"
Ramkumar Ramachandra
Re: [GSoC update] git-remote-svn: The final one
Junio C Hamano
Re: git-rm isn't the inverse action of git-add
openbsd-misc
:
Joachim Schipper
Re: UVC Webcams
Florin Andrei
SOLVED [was: firewall is very slow, something's wrong]
Todd Alan Smith
Re: Microsoft gets the Most Secure Operating Systems award
Neal Hogan
Re: Need Advice: Thinkpad T60 or T61?
Sam Fourman Jr.
Re: Real men don't attack straw men
git-commits-head
:
Linux Kernel Mailing List
ACPI: Disable ARB_DISABLE on platforms where it is not needed
Linux Kernel Mailing List
m68knommu: add read_barrier_depends() and irqs_disabled_flags()
Linux Kernel Mailing List
[MTD] Add mtd panic_write function pointer
Linux Kernel Mailing List
[ARM] pxa: remove duplicate select statements from Kconfig
Linux Kernel Mailing List
mlx4_core: Don't read reserved fields in mlx4_QUERY_ADAPTER()
Colocation donated by:
Syndicate